571dab9c7c
Remedied by: - in Circulation.pm changing AnonymiseIssueHistory so that it returns ($rows, $err_history_not_deleted) instead of $rows - consequential change to misc/cronjobs/batch_anonymise.pl to handle updated return value, and fail if there is an error - consequential change to tools/cleanborrowers.pl although this still fails silently (raised as bug 9944) - update of opac-privacy.pl to check return value and pass on error - update of opac-privacy.tt to display error if appropriate Note bug 9942 remains unfixed, which is a similar issue upon issue return. To test: 1. OPAC - enable privacy mode (preference OpacPrivacy) - leave anonymous patron set to zero (preference AnonymousPatron) - attempt to delete user history - observe error - check history - still there - change anonymous patron to a valid user - attempt to delete user history - observe success message - check history - gone 2. cleanborrowers.pl - test it functions as before. bug 9944 has been raised for it continuing to silently fail. 3. batch_anonymise.pl - enable privacy mode (preference OpacPrivacy) - leave anonymous patron set to zero (preference AnonymousPatron) - run script (I use --days -1 for testing) - script should fail with a Carp message - change anonymous patron to a valid user - run script as before - script returns quietly - check history - gone Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> |
||
|---|---|---|
| .. | ||
| admin | ||
| bin | ||
| cronjobs | ||
| interface_customization | ||
| load_testing | ||
| maintenance | ||
| migration_tools | ||
| release_notes | ||
| translator | ||
| batchCompareMARCvsFrameworks.pl | ||
| batchdeletebiblios.pl | ||
| batchDeleteUnusedSubfields.pl | ||
| batchImportMARCWithBiblionumbers.pl | ||
| batchRebuildBiblioTables.pl | ||
| batchRepairMissingBiblionumbers.pl | ||
| batchupdateISBNs.pl | ||
| check_sysprefs.pl | ||
| commit_file.pl | ||
| export_borrowers.pl | ||
| exportauth.pl | ||
| koha-install-log | ||
| kohalib.pl | ||
| link_bibs_to_authorities.pl | ||
| perlmodule_ls.pl | ||
| perlmodule_rm.pl | ||
| recreateIssueStatistics.pl | ||
| sax_parser_print.pl | ||
| sax_parser_test.pl | ||
| stage_file.pl | ||