Koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ
Nick Clemens 489b08ab4c Bug 26950: Make Anonymous patron warnings 'errors' and refer to the system information tab on about.pl
Currently checkins can fail for one of two known reasons:
1 - Duplicate issue ids
2 - Anonymous borrower configuration issues

In the first case we refer to the 'data problems' or 'data corrupted' section of the about page. All errors are on the 'System information' tab and this is what we should mention

In the second case we refer to the data problems section, but information is in another section on the tab. Additionally, during checkin we issue an 'Error' but on the about page we call it a 'Warning' we should upgrade to error and specify what is broken

Additionally this patch fixes the warning that should display while issuing to a patron if anonymous is not set and patron has selected privacy

To test:
 1 - Enable system preference OPACPrivacy
 2 - Set system preference AnonymousPatron to '0'
 3 - Log in a a patron on OPAC and set your privacy to never
 4 - Issue a book to that patron in the staff client
 5 - Note there is no warning
 6 - Return the book
 7 - Note the circulation page displays an error and the checkin fails and refers to 'data problems'
 8 - Apply patch
 9 - Issue another book to patron
10 - Note warning on the circulation page
11 - Try to check in a book again
12 - Check the new message makes sense
13 - Click the link to 'about.pl' check that errors are displayed
14 - Check the logs
15 - Confirm updated error message makes sense

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-01-12 16:13:50 +01:00
..
article-requests.tt Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
bookcount.tt
branchoverdues.tt Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
branchtransfers.tt Bug 26819: (QA follow-up) Fix branchtransfers.tt 2020-11-25 14:38:12 +01:00
checkout-notes.tt
circulation-home.tt
circulation.tt Bug 26950: Make Anonymous patron warnings 'errors' and refer to the system information tab on about.pl 2021-01-12 16:13:50 +01:00
circulation_batch_checkouts.tt Bug 19382: Add blocking of ability to checkout on circulation.pl 2020-10-14 14:50:07 +02:00
offline-mf.tt
offline.tt
on-site_checkouts.tt
overdue.tt Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
pendingreserves.tt Bug 25534: Add missing td in tfoot in pendingreserves 2020-11-27 09:37:00 +01:00
printslip.tt
renew.tt Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
request-article.tt Bug 26727: (follow-up) More markup corrections 2020-11-06 09:40:27 +01:00
reserveratios.tt Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
returns.tt Bug 26950: Make Anonymous patron warnings 'errors' and refer to the system information tab on about.pl 2021-01-12 16:13:50 +01:00
set-library.tt Bug 24665: (QA follow-up) Fix selection default 2020-11-06 15:55:17 +01:00
transferstoreceive.tt Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
view_holdsqueue.tt Bug 23852: Merge biblio-title.inc and biblio-default-view.inc 2020-10-08 15:01:29 +02:00
waitingreserves.tt