dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
190 lines
13 KiB
Text
190 lines
13 KiB
Text
[% USE Koha %]
|
|
[% USE KohaDates %]
|
|
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Recent comments</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% BLOCK cssinclude %][% END %]
|
|
<link rel="alternate" type="application/rss+xml" title="[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog recent comments" href="[% OPACBaseURL | html %]/cgi-bin/koha/opac-showreviews.pl?format=rss" />
|
|
</head>
|
|
[% INCLUDE 'bodytag.inc' bodyid='opac-showreviews' bodyclass='scrollto' %]
|
|
[% INCLUDE 'masthead.inc' %]
|
|
|
|
<div class="main">
|
|
<ul class="breadcrumb">
|
|
<li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li>
|
|
<li><a href="#">Recent comments</a></li>
|
|
</ul>
|
|
|
|
<div class="container-fluid">
|
|
<div class="row-fluid">
|
|
[% IF ( OpacNav || OpacNavBottom ) %]
|
|
<div class="span2">
|
|
<div id="navigation">
|
|
[% INCLUDE 'navigation.inc' %]
|
|
</div>
|
|
</div>
|
|
<div class="span10">
|
|
[% ELSE %]
|
|
<div class="span12">
|
|
[% END %]
|
|
<div id="showreviews" class="searchresults maincontent">
|
|
<h3>Recent comments <a href="[% OPACBaseURL | html %]/cgi-bin/koha/opac-showreviews.pl?format=rss" class="rsssearchlink"><img src="[% interface | html %]/[% theme | html %]/images/feed-icon-16x16.png" alt="Subscribe to recent comments" title="Subscribe to recent comments" border="0" class="rsssearchicon"/></a></h3>
|
|
<table class="table table-striped">
|
|
[% FOREACH review IN reviews %]
|
|
<tr>
|
|
<td>
|
|
<p>
|
|
[% IF ( BiblioDefaultViewmarc ) %]
|
|
<a class="title" href="/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% review.biblionumber |url %]" title="View details for this title">
|
|
[% ELSE %]
|
|
[% IF ( BiblioDefaultViewisbd ) %]
|
|
<a class="title" href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% review.biblionumber |url %]" title="View details for this title">
|
|
[% ELSE %]
|
|
<a class="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% review.biblionumber |url %]#comments" title="View details for this title">
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( review.title ) %][% review.title | html %][% ELSE %]No title[% END %]
|
|
[% FOREACH subtitl IN review.subtitle %] [% subtitl.subfield | html %][% END %]
|
|
</a>
|
|
[% IF ( review.author ) %]
|
|
by <a href="/cgi-bin/koha/opac-search.pl?q=au:[% review.author |url %]" title="Search for works by this author" class="author">[% review.author | html %]</a>
|
|
[% END %]
|
|
</p>
|
|
<p>
|
|
<span class="results_summary">
|
|
<span class="label">Publication:</span>
|
|
[% IF ( review.place ) %][% review.place | html %] [% END %]
|
|
[% IF ( review.publishercode ) %][% review.publishercode | html %][% END %]
|
|
[% IF ( review.publicationyear ) %]
|
|
[% review.publicationyear | html %]
|
|
[% ELSE %]
|
|
[% IF ( review.copyrightdate ) %]
|
|
[% review.copyrightdate | html %]
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( review.pages ) %]. [% review.pages | html %][% END %]
|
|
[% IF ( review.notes ) %], [% review.notes | html %][% END %]
|
|
[% IF ( review.size ) %] [% review.size | html %][% END %]
|
|
</span>
|
|
[% IF ( review.summary ) %]
|
|
<span class="result_summary">
|
|
[% review.summary | html %]
|
|
</span>
|
|
[% END %]
|
|
[% IF ( review.copyrightdate ) %]
|
|
<span class="results_summary">
|
|
<span class="label">Date:</span>
|
|
[% review.copyrightdate | html %]</span>
|
|
[% END %]
|
|
</p>
|
|
|
|
<p class="commentline[% IF ( review.your_comment ) %] yours[% END %]">
|
|
[% IF ( review.avatarurl ) %]
|
|
<img class="avatar" src="[% review.avatarurl | html %]" height="40" width="40" alt="" />
|
|
[% END %]
|
|
[% FILTER html_break %]
|
|
[% review.review | html %]
|
|
[% END %]
|
|
<span style="font-size:87%;font-color:#CCC;">
|
|
[% IF review.your_comment %]
|
|
Added [% review.datereviewed | $KohaDates %] by you
|
|
[% ELSE %]
|
|
[% IF ( review.borrowernumber && ShowReviewer != "none" ) %]
|
|
Added [% review.datereviewed | $KohaDates %] by
|
|
[% SWITCH ShowReviewer %]
|
|
[% CASE 'full' %]
|
|
[% review.borrtitle | html %] [% review.firstname | html %] [% review.surname | html %]
|
|
[% CASE 'first' %]
|
|
[% review.firstname | html %]
|
|
[% CASE 'surname' %]
|
|
[% review.surname | html %]
|
|
[% CASE 'firstandinitial' %]
|
|
[% review.firstname | html %] [% review.surname|truncate(2,'.') | html %]
|
|
[% CASE 'username' %]
|
|
[% review.userid | html %]
|
|
[% END %]
|
|
[% END %][% END %]</span></p>
|
|
</td>
|
|
<td>
|
|
[% IF ( review.BiblioDefaultViewmarc ) %]
|
|
<a class="title" href="/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=[% review.biblionumber |url %]" title="View details for this title">
|
|
[% ELSE %]
|
|
[% IF ( review.BiblioDefaultViewisbd ) %]
|
|
<a class="title" href="/cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=[% review.biblionumber |url %]" title="View details for this title">
|
|
[% ELSE %]
|
|
<a class="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% review.biblionumber |url %]#comments" title="View details for this title">
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% IF ( OPACAmazonCoverImages ) %]
|
|
[% IF ( review.normalized_isbn ) %]
|
|
<img src="https://images-na.ssl-images-amazon.com/images/P/[% review.normalized_isbn | html %].01.TZZZZZZZ.jpg" alt="" class="thumbnail" />
|
|
[% ELSE %]
|
|
<span class="no-image">No cover image available</span>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% IF ( SyndeticsEnabled && SyndeticsCoverImages ) %]
|
|
<img src="https://secure.syndetics.com/index.aspx?isbn=[% review.normalized_isbn | html %]/SC.GIF&client=[% SyndeticsClientCode | html %]&type=xw10&upc=[% review.normalized_upc | html %]&oclc=[% review.normalized_oclc | html %]" alt="" class="thumbnail" />
|
|
[% END %]
|
|
|
|
[% IF ( GoogleJackets ) %]
|
|
[% IF ( review.normalized_isbn ) %]
|
|
<div title="[% review.biblionumber |url %]" class="[% review.normalized_isbn | html %]" id="gbs-thumbnail[% loop.count | html %]"></div>
|
|
[% ELSE %]
|
|
<span class="no-image">No cover image available</span>
|
|
[% END %]
|
|
[% END %]
|
|
</a>
|
|
[% bt_id = ( review.normalized_upc || review.normalized_isbn ) | html %]
|
|
[% IF ( BakerTaylorEnabled ) %]
|
|
[% IF ( bt_id ) %]
|
|
<a href="https://[% review.BakerTaylorBookstoreURL | html %][% bt_id | html %]"><img alt="See Baker & Taylor" src="[% review.BakerTaylorImageURL | html %][% bt_id | html %]" /></a>
|
|
[% ELSE %]
|
|
<span class="no-image">No cover image available</span>
|
|
[% END %]
|
|
[% END %]
|
|
</td>
|
|
</tr>
|
|
[% END # / FOREACH review %]
|
|
</table>
|
|
|
|
[% IF ( PAGE_NUMBERS ) %]
|
|
<div class="pages">
|
|
<!-- Row of numbers corresponding to showreviews result pages -->
|
|
[% IF ( previous_page_offset ) %]
|
|
<a class="nav" href="/cgi-bin/koha/opac-showreviews.pl?offset=[% previous_page_offset | html %]&count=[% results_per_page | html %]"><< Previous</a>
|
|
[% ELSE %]
|
|
[% IF ( previous_page_first ) %]
|
|
<a class="nav" href="/cgi-bin/koha/opac-showreviews.pl?offset=0&count=[% results_per_page | html %]"><< Previous</a>
|
|
[% END %]
|
|
[% END %]
|
|
[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
|
|
[% IF ( PAGE_NUMBER.highlight ) %]
|
|
<span class="currentPage">[% PAGE_NUMBER.pg | html %]</span>
|
|
[% ELSE %]
|
|
<a class="nav" href="/cgi-bin/koha/opac-showreviews.pl?offset=[% PAGE_NUMBER.offset | html %]&count=[% results_per_page | html %]">[% PAGE_NUMBER.pg | html %]</a>
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( next_page_offset ) %]
|
|
<a class="nav" href="/cgi-bin/koha/opac-showreviews.pl?offset=[% next_page_offset | html %]&count=[% results_per_page | html %]">Next >></a>
|
|
[% END %]
|
|
</div>
|
|
[% END # / IF PAGE_NUMBERS %]
|
|
</div> <!-- / #showreviews -->
|
|
</div> <!-- / .span10/12 -->
|
|
</div> <!-- / .row-fluid -->
|
|
</div> <!-- / .container-fluid -->
|
|
</div> <!-- / .main -->
|
|
|
|
[% INCLUDE 'opac-bottom.inc' %]
|
|
[% BLOCK jsinclude %]
|
|
<script>
|
|
//<![CDATA[
|
|
$(document).ready(function(){
|
|
[% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %]
|
|
});
|
|
//]]>
|
|
</script>
|
|
[% END %]
|