Jonathan Druart fa5104a6a1 Bug 8684: Fix duplicate check on creating items in the acquisition module ... The script acqui/check_uniqueness.pl has been introduced by bug 7178. But bug 11425 added a call to a new subroutine SearchItemsByField in order to refactore some code. This subroutine calls SearchItems with an arrayref, which is not what SearchItems is expecting. This broke the duplicate check done on creating items in the acquisition module. To reproduce the issue: 1/ Fill the pref UniqueItemFields with "barcode" and AcqCreateItem with "placing an order" 2/ Create a new basket 3/ Create a new order 4/ Close the basket 5/ Receive items and set barcode with one already in your DB 6/ Save 7/ Nothing happen on the interface, but an error should have been added in your Koha log file: Can't use an undefined value as an ARRAY reference at /home/koha/src/acqui/check_uniqueness.pl line 48. Test plan: 1/ Repeat steps 1-6 2/ You should see a warning on the interface Note that this should also happen with AcqCreateItem set to "creating an order". Works well, no errors. Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>		2015-07-24 13:40:43 -03:00
..
AuthoritiesMarc	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Barcodes	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Bookseller	Bug 10402 follow-up: choose contacts for claims	2014-08-26 11:45:59 -03:00
ClassSortRoutine	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Creators	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
External	Bug 13758: Correct KOHA::VERSION in OverDrive.pm	2015-05-11 09:36:07 -03:00
Form	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Heading	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
ILSDI	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Installer	Bug 14167: Add Koha::Logger based on Log4perl	2015-07-21 10:15:40 -03:00
Labels	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Linker	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Members	Bug 14569: Typo borroewr|borow	2015-07-24 12:55:07 -03:00
OAI	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Output	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Patroncards	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Reports	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Search	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Serials	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
SIP	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Utils	Bug 14436: Noisy warns in C4/Utils/DataTables/Members.pm	2015-07-20 10:13:17 -03:00
VirtualShelves	Bug 13986: Printing a list only prints the results of the page you are viewing	2015-05-15 16:01:33 -03:00
Accounts.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Acquisition.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Auth.pm	Bug 12137: Use Koha.Preference to access pref value	2015-07-20 10:44:06 -03:00
Auth_cas_servers.yaml.orig	Bug 5630 CAS improvements	2011-10-13 10:49:49 +13:00
Auth_with_cas.pm	Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t	2015-07-20 10:32:21 -03:00
Auth_with_ldap.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Auth_with_shibboleth.pm	Bug 5010: Fix OPACBaseURL to include protocol	2015-06-04 10:00:04 -03:00
AuthoritiesMarc.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
BackgroundJob.pm	Bug 13606 Clear job data in session when the job is completed	2015-04-23 13:18:48 -03:00
Barcodes.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Biblio.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Bookseller.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Boolean.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Branch.pm	Bug 14383: (QA followup) missing POD fix in C4/Branch.pm	2015-06-22 17:43:21 -03:00
Breeding.pm	Bug 13987: Fix server name in z39.50 authority search results	2015-04-22 14:39:00 -03:00
Budgets.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Calendar.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Category.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Charset.pm	Bug 11790: Remove dependency C4::Context from C4::Charset	2015-06-08 10:36:11 -03:00
Circulation.pm	Bug 14494: Terribly slow checkout caused by DateTime->new in far future	2015-07-20 10:16:24 -03:00
ClassSortRoutine.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
ClassSource.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Context.pm	Bug 9006: Remove AUTOLOAD in C4::Context	2015-07-20 10:11:41 -03:00
Contract.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
CourseReserves.pm	Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm	2015-05-26 10:42:05 -03:00
Creators.pm	Bug 14059: Delete all export of get_column_names	2015-05-22 17:02:21 -03:00
Csv.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Dates.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Debug.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Heading.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
HoldsQueue.pm	Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings	2015-06-04 11:14:58 -03:00
HTML5Media.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Images.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
ImportBatch.pm	Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool	2015-05-04 15:33:51 -03:00
ImportExportFramework.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
InstallAuth.pm	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
Installer.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
ItemCirculationAlertPreference.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Items.pm	Bug 8684: Fix duplicate check on creating items in the acquisition module	2015-07-24 13:40:43 -03:00
ItemType.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Koha.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Labels.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Languages.pm	Bug 12616: Locale in subscriptions not preselecting correctly	2015-06-22 11:52:35 -03:00
Letters.pm	Bug 14206: Adds delete function for non email templates	2015-06-11 10:14:22 -03:00
Linker.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Log.pm	Bug 13889: (QA followup) Supress warning, set object column to undef instead of 0	2015-05-04 11:12:49 -03:00
MarcModificationTemplates.pm	Bug 11413: Fix field_numbers	2014-11-14 12:05:47 -03:00
Matcher.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Members.pm	Bug 10063: Remove outdated FIXME	2015-06-22 11:09:19 -03:00
Message.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
NewsChannels.pm	Bug 12507 - News does not always display in staff or OPAC	2014-08-24 12:37:06 -03:00
Output.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Overdues.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Patroncards.pm	Bug 8315 - remove use C4::* version	2012-07-13 14:17:20 +02:00
Print.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Ratings.pm	Bug 14383: Fix POD error in C4/Ratings.pm	2015-06-22 17:34:47 -03:00
Record.pm	Revert "Bug 6679: Fix 3 perlcritic violations in C4/Record.pm"	2015-05-26 14:16:06 -03:00
Reports.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Reserves.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Review.pm	Bug 13969: Replace calls to $sth->fetchrow* with a call to $dbh->selectrow* and Cleaning files	2015-05-14 11:11:41 -03:00
Ris.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
RotatingCollections.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Scheduler.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Scrubber.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Search.pm	Bug 11620: Add dissertation-information index for MARC21 (502)	2015-07-20 10:31:06 -03:00
Serials.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Service.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
ShelfBrowser.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
SMS.pm	Bug 14421: Corrected example in SMS.pm to working version with hashref.	2015-06-22 11:08:29 -03:00
SocialData.pm	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Stats.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Suggestions.pm	Bug 13014: Notify budget owner on new suggestion - UT	2015-06-24 11:39:40 -03:00
Tags.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
Templates.pm	Bug 14120: Fixing t/db_dependent/Auth.t noise	2015-06-01 14:09:22 -03:00
TmplToken.pm	Revert "Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm"	2015-05-26 14:16:21 -03:00
TmplTokenType.pm	Revert "Bug 6679: Fix 9 perlcritic violations in C4/TmplTokenType.pm"	2015-05-26 14:16:58 -03:00
TTParser.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
UploadedFile.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
UsageStats.pm	Bug 7981: Remove HomeOrHoldingBranchReturn syspref from C4::UsageStats	2015-06-11 10:41:27 -03:00
VirtualShelves.pm	Bug 13421: (QA followup) Change creation_time to created_on	2015-05-04 12:31:59 -03:00
XISBN.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
XSLT.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00