dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
223 lines
13 KiB
Text
223 lines
13 KiB
Text
[% USE raw %]
|
|
[% SET footerjs = 1 %]
|
|
[% BLOCK translate_label_types %]
|
|
[% SWITCH type %]
|
|
[% CASE 'BIB' %]Biblio
|
|
[% CASE 'BARBIB' %]Barcode/Biblio
|
|
[% CASE 'BIBBAR' %]Biblio/Barcode
|
|
[% CASE 'ALT' %]Alternating
|
|
[% CASE 'BAR' %]Barcode
|
|
[% END %]
|
|
[% END %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Tools › Label creator › Layouts › [% IF ( layout_id ) %]Edit ([% layout_id | html %])[% ELSE %]New[% END %]</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
[% BLOCK translate_justification_types %]
|
|
[% SWITCH type %]
|
|
[% CASE 'L' %]Left
|
|
[% CASE 'C' %]Center
|
|
[% CASE 'R' %]Right
|
|
[% END %]
|
|
[% END %]
|
|
<body id="labels_label-edit-layout" class="tools labels">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'cat-search.inc' %]
|
|
<div id="breadcrumbs">
|
|
<a href="/cgi-bin/koha/mainpage.pl">Home</a> ›
|
|
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> ›
|
|
<a href="/cgi-bin/koha/labels/label-home.pl">Label creator</a> ›
|
|
<a href="/cgi-bin/koha/labels/label-manage.pl?label_element=layout">Layouts</a> ›
|
|
[% IF ( layout_id ) %]Edit ([% layout_id | html %])[% ELSE %]New[% END %]
|
|
</div>
|
|
|
|
<div class="main container-fluid">
|
|
<div class="row">
|
|
<div class="col-sm-10 col-sm-push-2">
|
|
<main>
|
|
|
|
[% INCLUDE 'labels-toolbar.inc' %]
|
|
|
|
<form name="input" action="/cgi-bin/koha/labels/label-edit-layout.pl" method="get">
|
|
<fieldset class="rows">
|
|
<legend>[% IF ( layout_id ) %]Edit[% ELSE %]Create[% END %] label layout</legend>
|
|
<ol>
|
|
<li>
|
|
<label for="layout_name">Layout name: </label>
|
|
<input type="text" name="layout_name" id="layout_name" size="20" value="[% layout_name | html %]" />
|
|
</li>
|
|
<li>
|
|
<label for="barcode_type">Choose barcode type (encoding): </label>
|
|
<select name="barcode_type" id="barcode_type">
|
|
[% FOREACH barcode_type IN barcode_types %]
|
|
[% IF ( barcode_type.selected ) %]
|
|
<option value="[% barcode_type.type | html %]" selected="selected">[% barcode_type.name | html %]</option>
|
|
[% ELSE %]
|
|
<option value="[% barcode_type.type | html %]">[% barcode_type.name | html %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="printing_type">Choose layout type: </label>
|
|
<select name="printing_type" id="printing_type">
|
|
[% FOREACH label_type IN label_types %]
|
|
[% IF ( label_type.selected ) %]
|
|
<option value="[% label_type.type | html %]" selected="selected">[% PROCESS translate_label_types type=label_type.type %]</option>
|
|
[% ELSE %]
|
|
<option value="[% label_type.type | html %]">[% PROCESS translate_label_types type=label_type.type %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<fieldset>
|
|
<legend>Bibliographic data to print</legend>
|
|
<ol>
|
|
<li class="radio">[% IF ( layout_string ) %]
|
|
<input type="radio" name="layout_choice" id="layout_choice_order" value="layout_table" checked="checked" /><label for="layout_choice_order">Choose order of text fields to print</label>
|
|
[% ELSE %]
|
|
<input type="radio" name="layout_choice" id="layout_choice_order" value="layout_table" /><label for="layout_choice_order">Choose Order Of Text Fields to Print</label>
|
|
[% END %]
|
|
<div id="layout_table">
|
|
<p>
|
|
[% FOREACH text_field IN fields %]
|
|
<select name="[% text_field.field_name | html %]" id="[% text_field.field_name |url %]">
|
|
<option value=""></option>
|
|
[% FOREACH orde IN [1..field_count] %]
|
|
[% IF ( orde == text_field.order ) %]
|
|
<option value="[% orde | html %]" selected="1">[% orde | html %]</option>
|
|
[% ELSE %]
|
|
<option value="[% orde | html %]">[% orde | html %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select> <label for="[% text_field.field_name |url %]">[% text_field.field_label | html %]</label>
|
|
|
|
|
|
|
|
[% END %]
|
|
</p>
|
|
</div>
|
|
</li>
|
|
[% UNLESS ( layout_string ) %]
|
|
<li class="radio"><input type="radio" id="layout_choice_list" name="layout_choice" value="layout_string" checked="checked" /> <label for="layout_choice_list">List fields</label></li>
|
|
[% ELSE %]
|
|
<li class="radio"><input type="radio" id="layout_choice_list" name="layout_choice" value="layout_string" /> <label for="layout_choice_list">List Fields</label></li>
|
|
[% END %]
|
|
<li> <fieldset id="layout_string" class="brief">
|
|
<label for="format_string">Data fields</label>
|
|
<input type="text" name="format_string" id="format_string" size="80" value="[% format_string | html %]" />
|
|
<div class="hint">
|
|
<p>Enter a comma separated list of fields to print. You may include any <em>Koha field</em> or MARC subfield.</p>
|
|
<p>See online help for advanced options</p>
|
|
<p>ex: barcode, itemcallnumber, title, "050a 050b", 300a </p>
|
|
<p>Fields homebranch_description, holdingbranch_description, ccode_description, location_description and permanent_location_description show description instead of code.</p>
|
|
</div>
|
|
</fieldset></li>
|
|
</ol>
|
|
</fieldset>
|
|
</li>
|
|
<li>
|
|
<label for="guidebox">Draw guide boxes: </label>
|
|
[% IF ( guidebox ) %]
|
|
<input type="checkbox" name="guidebox" id="guidebox" value="1" checked="checked" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="guidebox" id="guidebox" value="1" />
|
|
[% END %]
|
|
</li>
|
|
<li>
|
|
<label for="callnum_split">Split call numbers: </label>
|
|
[% IF ( callnum_split ) %]
|
|
<input type="checkbox" name="callnum_split" id="callnum_split" value="1" checked="checked" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="callnum_split" id="callnum_split" value="1" />
|
|
[% END %]
|
|
</li>
|
|
<li>
|
|
<label for="text_justify">Text justification: </label>
|
|
<select name="text_justify" id="text_justify">
|
|
[% FOREACH text_justification_type IN text_justification_types %]
|
|
[% IF ( text_justification_type.selected ) %]
|
|
<option value="[% text_justification_type.type | html %]" selected="selected">[% PROCESS translate_justification_types type=text_justification_type.type %]</option>
|
|
[% ELSE %]
|
|
<option value="[% text_justification_type.type | html %]">[% PROCESS translate_justification_types type=text_justification_type.type %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="font">Font: </label>
|
|
<select name="font" id="font">
|
|
[% FOREACH font_type IN font_types %]
|
|
[% IF ( font_type.selected ) %]
|
|
<option value="[% font_type.type | html %]" selected="selected">[% font_type.name | html %]</option>
|
|
[% ELSE %]
|
|
<option value="[% font_type.type | html %]">[% font_type.name | html %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
</li>
|
|
<li>
|
|
<label for="font_size">Font size: </label>
|
|
<input type="text" name="font_size" id="font_size" size="2" value="[% font_size | html %]" />
|
|
</li>
|
|
<li>
|
|
<label for="oblique_title">Oblique title: </label>
|
|
[% IF ( oblique_title ) %]
|
|
<input type="checkbox" name="oblique_title" id="oblique_title" value="1" checked="checked" />
|
|
[% ELSE %]
|
|
<input type="checkbox" name="oblique_title" id="oblique_title" value="1" />
|
|
[% END %]
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
<fieldset class="action">
|
|
<input type="submit" value="Save" />
|
|
<a class="cancel" href="/cgi-bin/koha/labels/label-manage.pl?label_element=layout">Cancel</a>
|
|
<input type="hidden" name="op" value="save" />
|
|
<input type="hidden" name="layout_id" value="[% layout_id | html %]" />
|
|
</fieldset>
|
|
</form>
|
|
</main>
|
|
</div> <!-- /.col-sm-10.col-sm-push-2 -->
|
|
|
|
<div class="col-sm-2 col-sm-pull-10">
|
|
<aside>
|
|
[% INCLUDE 'tools-menu.inc' %]
|
|
</aside>
|
|
</div> <!-- /.col-sm-2.col-sm-pull-10 -->
|
|
</div> <!-- /.row -->
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/tools-menu.js") | $raw %]
|
|
<script>
|
|
$(document).ready(function() {
|
|
$("input[name='layout_choice']").change( function() { layout_method() } );
|
|
layout_method();
|
|
$("#font").on("change",function(){
|
|
checkOblique();
|
|
});
|
|
});
|
|
function layout_method() {
|
|
if( $("input[name='layout_choice']:checked").val() == 'layout_string' ) {
|
|
$('#layout_table').hide();
|
|
$('#layout_string').show();
|
|
} else {
|
|
$('#layout_table').show();
|
|
$('#layout_string').hide();
|
|
}
|
|
}
|
|
function checkOblique() {
|
|
var font = document.getElementById("font");
|
|
var selectedfont = font.options[font.selectedIndex].value;
|
|
if ( selectedfont.match("I$") || selectedfont.match("O$") ) {
|
|
document.getElementById("oblique_title").disabled = true;
|
|
} else {
|
|
document.getElementById("oblique_title").disabled = false;
|
|
}
|
|
}
|
|
</script>
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|