878fa77c30
Calls to C4/Charset.pm's NormalizeString function with an
undefined string were triggering warnings when running:
prove -v t/db_dependent/Holds.t
Sadly, t/Charset.t was also lacking calls to NormalizeString.
TEST PLAN
---------
1) prove -v t/db_dependent/Holds.t
-- This should generate the uninitialized string warnings.
Make sure CPL and MPL are in your branches to save
yourself from headaches due to expected data.
2) cat t/Charset.t
-- note there are no function calls to NormalizeString.
You can see other shortfalls in the tests beyond
NormalizeString with: grep ^sub C4/Charset.pm
3) prove -v t/Charset.t
4) Apply patch
5) prove -v t/Charset.t
-- Run as before with more tests.
6) cat t/Charset.t
-- note there are now function calls to NormalizeString.
7) prove -v t/db_dependent/Holds.t
-- Nice and clean run! :)
8) koha-qa.pl -v 2 -c 1
-- all should be Ok.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
72 lines
2.6 KiB
Perl
Executable file
72 lines
2.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
||
|
||
# This file is part of Koha.
|
||
#
|
||
# Koha is free software; you can redistribute it and/or modify it
|
||
# under the terms of the GNU General Public License as published by
|
||
# the Free Software Foundation; either version 3 of the License, or
|
||
# (at your option) any later version.
|
||
#
|
||
# Koha is distributed in the hope that it will be useful, but
|
||
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
# GNU General Public License for more details.
|
||
#
|
||
# You should have received a copy of the GNU General Public License
|
||
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
||
|
||
use Modern::Perl;
|
||
|
||
use Test::More tests => 16;
|
||
use MARC::Record;
|
||
|
||
use utf8;
|
||
use open ':std', ':encoding(utf8)';
|
||
|
||
BEGIN {
|
||
use_ok('C4::Charset');
|
||
}
|
||
|
||
my $string;
|
||
ok(!defined(NormalizeString($string,undef,1)),'Uninitialized string case 1 normalizes to uninitialized string.');
|
||
|
||
$string = 'Sample';
|
||
ok(defined(NormalizeString($string,undef,0)), 'Initialized string case 1 normalizes to some string.');
|
||
ok(defined(NormalizeString($string,undef,1)), 'Initialized string case 2 normalizes to some string.');
|
||
ok(defined(NormalizeString($string,1,0)), 'Initialized string case 3 normalizes to some string.');
|
||
ok(defined(NormalizeString($string,1,1)), 'Initialized string case 4 normalizes to some string.');
|
||
|
||
my $octets = "abc";
|
||
ok(IsStringUTF8ish($octets), "verify octets are valid UTF-8 (ASCII)");
|
||
|
||
$octets = "flamb\c3\a9";
|
||
ok(!utf8::is_utf8($octets), "verify that string does not have Perl UTF-8 flag on");
|
||
ok(IsStringUTF8ish($octets), "verify octets are valid UTF-8 (LATIN SMALL LETTER E WITH ACUTE)");
|
||
ok(!utf8::is_utf8($octets), "verify that IsStringUTF8ish does not magically turn Perl UTF-8 flag on");
|
||
|
||
$octets = "a\xc2" . "c";
|
||
ok(!IsStringUTF8ish($octets), "verify octets are not valid UTF-8");
|
||
|
||
ok( !SetUTF8Flag(), 'SetUTF8Flag returns undef if no record passed' );
|
||
|
||
my $record = MARC::Record->new();
|
||
ok( !SetUTF8Flag($record), 'SetUTF8Flag returns undef if the record has no subfields' );
|
||
# Add some fields/subfields
|
||
$record->append_fields(
|
||
MARC::Field->new('100', ' ', ' ', a => 'Julio Cortazar'),
|
||
MARC::Field->new('245', ' ', ' ', a => 'Rayuela'),
|
||
);
|
||
# Verify our data serves its purpose
|
||
ok( !utf8::is_utf8($record->subfield('100','a')) &&
|
||
!utf8::is_utf8($record->subfield('245','a')),
|
||
'Verify that the subfields are NOT set the UTF-8 flag yet' );
|
||
|
||
SetUTF8Flag($record);
|
||
|
||
ok( utf8::is_utf8($record->subfield('100','a')) &&
|
||
utf8::is_utf8($record->subfield('245','a')),
|
||
'SetUTF8Flag sets the UTF-8 flag to all subfields' );
|
||
|
||
is( nsb_clean("Le Moyen Âge"), "Le Moyen Âge", "nsb_clean removes and " );
|
||
|
||
1;
|