Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin
History
Marius Mandrescu 351e380a14
Bug 33335: Fix JavaScript error on the MARC overlay rules page 
The "MARC overlay rules" page doesn't display or work correctly
if a patron category code contains a "-".

This happens because of the JavaScript function in
"marc-overlay-rules.tt" line 469. This causes an error
"Uncaught SyntaxError: missing : after property id".

Test plan:
1. Go to Administration > Patron categories.
2. Make sure you don't have a patron category code that contains
   a "-".
3. Go to Administration > Record overlay rules.
4. The table should display correctly, and you can add, edit
   and delete rules.
5. Return to Patron categories.
6. Add a new patron category with a "-" in the patron category code.
7. Return to Record overlay rules page:
   => The page doesn't display and load correctly (see the attached
      image) - the normal DataTables header and footer aren't
      displayed, and you can't add, edit or delete overlay rules.
  => If you turn on web developer tools, an error is displayed in the
     console: "Uncaught SyntaxError: missing : after property id".
8. Apply the patch.
9. Repeat the step 7, the Record overlay rules page should now
   display correctly and you should be able to add, edit and
   delete rules.
10. Sign off.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-05-12 17:50:07 -03:00
..
preferences Bug 31557: Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library 2023-05-12 11:22:47 -03:00
searchengine/elasticsearch Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
additional-fields.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
admin-home.tt Bug 33673: Change "global system preferences" to "system preferences" 2023-05-09 10:58:01 -03:00
adveditorshortcuts.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
aqbudgetperiods.tt Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration 2023-04-12 11:43:13 -03:00
aqbudgets.tt Bug 33696: Fix doubled up home icon in budgets page 2023-05-09 10:57:59 -03:00
aqcontract.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
aqplan.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
audio_alerts.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
auth_subfields_structure.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
auth_tag_structure.tt Bug 33006: (follow-up) Add spans for translatability 2023-04-12 11:22:10 -03:00
authorised_values.tt Bug 33104: DB changes 2023-05-05 10:18:45 -03:00
authtypes.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
background_jobs.tt Bug 33579: Typo: record record 2023-04-24 10:43:36 -03:00
biblio_framework.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
branch_transfer_limits.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
branches.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
cash_registers.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
categories.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
checkmarc.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
cities.tt Bug 33077: Improve ease of translating template title tags 2023-04-12 11:43:22 -03:00
classsources.tt Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 2023-04-12 11:22:11 -03:00
clone-rules.tt
columns_settings.tt
credit_types.tt Bug 26403: Use accounts include in account management pages 2023-05-10 15:26:15 -03:00
curbside_pickup.tt
currency.tt
debit_types.tt Bug 26403: Use accounts include in account management pages 2023-05-10 15:26:15 -03:00
desks.tt
didyoumean.tt
edi_accounts.tt
edi_ean_accounts.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
identity_provider_domains.tt Bug 33699: Typo in identity_provider_domains.tt (presedence) 2023-05-12 11:22:40 -03:00
identity_providers.tt Bug 33111: (QA follow-up) Add more context to breadcrumb parts for easier translation 2023-04-12 11:43:23 -03:00
item_circulation_alerts.tt Bug 33154: Tab WRAPPER follow-up: label text must be translatable 2023-04-13 11:47:54 -03:00
items_search_field.tt Bug 33111: (QA follow-up) Add more context to breadcrumb parts for easier translation 2023-04-12 11:43:23 -03:00
items_search_fields.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
itemtypes.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
koha2marclinks.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
library_groups.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
localization.tt
marc-overlay-rules.tt Bug 33335: Fix JavaScript error on the MARC overlay rules page 2023-05-12 17:50:07 -03:00
marc_subfields_structure.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
marctagstructure.tt Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 2023-04-21 10:36:24 -03:00
matching-rules.tt Bug 33111: Use template wrapper for breadcrumbs: Administration part 4 2023-04-12 11:43:22 -03:00
oai_set_mappings.tt Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 2023-04-21 10:36:24 -03:00
oai_sets.tt Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set 2023-05-05 12:13:56 -03:00
overdrive.tt Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 2023-04-21 10:36:24 -03:00
patron-attr-types.tt Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 2023-04-21 10:36:24 -03:00
preferences.tt Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 2023-04-21 10:36:24 -03:00
restrictions.tt Bug 33549: Improve wording of dialog messages 2023-04-24 10:43:41 -03:00
search_filters.tt Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 2023-04-21 10:36:24 -03:00
share_content.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
smart-rules.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
sms_providers.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
smtp_servers.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
sru_modmapping.tt
sru_modmapping_auth.tt
systempreferences.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
transfer_limits.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
transport-cost-matrix.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
usage_statistics.tt Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 2023-04-14 15:39:39 -03:00
z3950servers.tt Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server 2023-05-05 12:13:55 -03:00