Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/members
History
Jonathan Druart 1c61729e84 Bug 16909: Koha::Patrons - Remove checkuniquemember 
C4::Members::checkuniquemember was not really nicely written, was only
used once and was not covered by tests.
I think it does not make sense to keep such complexity and have this
code in the subroutine/method.
Looking at this patch it seems that what this subroutine did can be done
easily in the pl script in few lines.

Test plan:
1/ Create 2 organisations with the same "surname": you should get a
warning.
2/ Create 2 patrons (non-organisation) with the same
surname/firstname/date of birth, you should get a warning

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2016-07-15 18:14:57 +00:00
..
boraccount.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
default_messageprefs.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
deletemem.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
discharge.pl Bug 15823: Can still access patron discharge slip without having the syspref on 2016-05-06 04:20:48 +00:00
discharges.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
files.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
guarantor_search.pl Bug 15109: Make name the default sort order for all patron searches 2015-11-17 09:49:21 -03:00
mancredit.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
maninvoice.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
member-flags.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
member-password.pl Bug 16853: Move changepassword to Koha::Patron->update_password 2016-07-15 18:09:17 +00:00
member.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
memberentry.pl Bug 16909: Koha::Patrons - Remove checkuniquemember 2016-07-15 18:14:57 +00:00
members-home.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
members-update-do.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
members-update.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
mod_debarment.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
moremember.pl Bug 16849: Move IsDebarred to Koha::Patron->is_debarred 2016-07-15 18:08:14 +00:00
nl-search.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
notices.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
patronimage.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
pay.pl Bug 14605 - Corrects the individual fine's description 2016-06-10 17:34:08 +00:00
paycollect.pl Bug 14605 - Corrects the individual fine's description 2016-06-10 17:34:08 +00:00
print_overdues.pl Bug 12933: (QA followup) Rename GetOverdues to GetOverduesForPatron 2015-11-04 12:41:29 -03:00
printfeercpt.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
printinvoice.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
printslip.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
purchase-suggestions.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
readingrec.pl Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar 2016-06-24 13:20:13 +00:00
routing-lists.pl Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar 2016-06-24 13:20:13 +00:00
setstatus.pl Bug 14910: Redirect to the circulation module after a renew 2015-10-02 14:22:16 -03:00
statistics.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
summary-print.pl Bug 15542: Always display the patron's info the same way. 2016-01-23 19:15:08 +00:00
update-child.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00