Jonathan Druart
9d6d641d1f
On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. This patch tries to standardize our EXPORT to use EXPORT_OK only. That way we will need to explicitely define the subroutine we want to use from a module. This patch is a squashed version of: Bug 17600: After export.pl Bug 17600: After perlimport Bug 17600: Manual changes Bug 17600: Other manual changes after second perlimports run Bug 17600: Fix tests And a lot of other manual changes. export.pl is a dirty script that can be found on bug 17600. "perlimport" is: git clone https://github.com/oalders/App-perlimports.git cd App-perlimports/ cpanm --installdeps . export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib" find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \; The ideas of this patch are to: * use EXPORT_OK instead of EXPORT * perltidy the EXPORT_OK list * remove '&' before the subroutine names * remove some uneeded use statements * explicitely import the subroutines we need within the controllers or modules Note that the private subroutines (starting with _) should not be exported (and not used from outside of the module except from tests). EXPORT vs EXPORT_OK (from https://www.thegeekstuff.com/2010/06/perl-exporter-examples/) """ Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members. @EXPORT and @EXPORT_OK are the two main variables used during export operation. @EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace. @EXPORT_OK does export of symbols on demand basis. """ If this patch caused a conflict with a patch you wrote prior to its push: * Make sure you are not reintroducing a "use" statement that has been removed * "$subroutine" is not exported by the C4::$MODULE module means that you need to add the subroutine to the @EXPORT_OK list * Bareword "$subroutine" not allowed while "strict subs" means that you didn't imported the subroutine from the module: - use $MODULE qw( $subroutine list ); You can also use the fully qualified namespace: C4::$MODULE::$subroutine Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
384 lines
11 KiB
Perl
384 lines
11 KiB
Perl
package C4::Auth_with_shibboleth;
|
|
|
|
# Copyright 2014 PTFS Europe
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Context;
|
|
use Koha::AuthUtils qw( get_script_name );
|
|
use Koha::Database;
|
|
use Koha::Patrons;
|
|
use C4::Members::Messaging;
|
|
use Carp qw( carp );
|
|
use List::MoreUtils qw( any );
|
|
|
|
use Koha::Logger;
|
|
|
|
our (@ISA, @EXPORT_OK);
|
|
BEGIN {
|
|
require Exporter;
|
|
@ISA = qw(Exporter);
|
|
@EXPORT_OK =
|
|
qw(shib_ok logout_shib login_shib_url checkpw_shib get_login_shib);
|
|
}
|
|
|
|
# Check that shib config is not malformed
|
|
sub shib_ok {
|
|
my $config = _get_shib_config();
|
|
|
|
if ($config) {
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
# Logout from Shibboleth
|
|
sub logout_shib {
|
|
my ($query) = @_;
|
|
my $uri = _get_uri();
|
|
my $return = _get_return($query);
|
|
print $query->redirect( $uri . "/Shibboleth.sso/Logout?return=$return" );
|
|
}
|
|
|
|
# Returns Shibboleth login URL with callback to the requesting URL
|
|
sub login_shib_url {
|
|
my ($query) = @_;
|
|
|
|
my $target = _get_return($query);
|
|
my $uri = _get_uri() . "/Shibboleth.sso/Login?target=" . $target;
|
|
|
|
return $uri;
|
|
}
|
|
|
|
# Returns shibboleth user login
|
|
sub get_login_shib {
|
|
|
|
# In case of a Shibboleth authentication, we expect a shibboleth user attribute
|
|
# to contain the login match point of the shibboleth-authenticated user. This match
|
|
# point is configured in koha-conf.xml
|
|
|
|
# Shibboleth attributes are mapped into http environmement variables, so we're getting
|
|
# the match point of the user this way
|
|
|
|
# Get shibboleth config
|
|
my $config = _get_shib_config();
|
|
|
|
my $matchAttribute = $config->{mapping}->{ $config->{matchpoint} }->{is};
|
|
|
|
if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {
|
|
return $ENV{"HTTP_".uc($matchAttribute)} || '';
|
|
} else {
|
|
return $ENV{$matchAttribute} || '';
|
|
}
|
|
}
|
|
|
|
# Checks for password correctness
|
|
# In our case : does the given attribute match one of our users ?
|
|
sub checkpw_shib {
|
|
|
|
my ( $match ) = @_;
|
|
my $config = _get_shib_config();
|
|
|
|
# Does the given shibboleth attribute value ($match) match a valid koha user ?
|
|
my $borrowers = Koha::Patrons->search( { $config->{matchpoint} => $match } );
|
|
if ( $borrowers->count > 1 ){
|
|
# If we have more than 1 borrower the matchpoint is not unique
|
|
# we cannot know which patron is the correct one, so we should fail
|
|
Koha::Logger->get->warn("There are several users with $config->{matchpoint} of $match, matchpoints must be unique");
|
|
return 0;
|
|
}
|
|
my $borrower = $borrowers->next;
|
|
if ( defined($borrower) ) {
|
|
if ($config->{'sync'}) {
|
|
_sync($borrower->borrowernumber, $config, $match);
|
|
}
|
|
return ( 1, $borrower->get_column('cardnumber'), $borrower->get_column('userid') );
|
|
}
|
|
|
|
if ( $config->{'autocreate'} ) {
|
|
return _autocreate( $config, $match );
|
|
} else {
|
|
# If we reach this point, the user is not a valid koha user
|
|
Koha::Logger->get->info("There are several users with $config->{matchpoint} of $match, matchpoints must be unique");
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
sub _autocreate {
|
|
my ( $config, $match ) = @_;
|
|
|
|
my %borrower = ( $config->{matchpoint} => $match );
|
|
|
|
while ( my ( $key, $entry ) = each %{$config->{'mapping'}} ) {
|
|
if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {
|
|
$borrower{$key} = ( $entry->{'is'} && $ENV{"HTTP_" . uc($entry->{'is'}) } ) || $entry->{'content'} || '';
|
|
} else {
|
|
$borrower{$key} = ( $entry->{'is'} && $ENV{ $entry->{'is'} } ) || $entry->{'content'} || '';
|
|
}
|
|
}
|
|
|
|
my $patron = Koha::Patron->new( \%borrower )->store;
|
|
C4::Members::Messaging::SetMessagingPreferencesFromDefaults( { borrowernumber => $patron->borrowernumber, categorycode => $patron->categorycode } );
|
|
|
|
return ( 1, $patron->cardnumber, $patron->userid );
|
|
}
|
|
|
|
sub _sync {
|
|
my ($borrowernumber, $config, $match ) = @_;
|
|
my %borrower;
|
|
$borrower{'borrowernumber'} = $borrowernumber;
|
|
while ( my ( $key, $entry ) = each %{$config->{'mapping'}} ) {
|
|
if ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) {
|
|
$borrower{$key} = ( $entry->{'is'} && $ENV{"HTTP_" . uc($entry->{'is'}) } ) || $entry->{'content'} || '';
|
|
} else {
|
|
$borrower{$key} = ( $entry->{'is'} && $ENV{ $entry->{'is'} } ) || $entry->{'content'} || '';
|
|
}
|
|
}
|
|
my $patron = Koha::Patrons->find( $borrowernumber );
|
|
$patron->set(\%borrower)->store;
|
|
}
|
|
|
|
sub _get_uri {
|
|
|
|
my $protocol = "https://";
|
|
my $interface = C4::Context->interface;
|
|
|
|
my $uri =
|
|
$interface eq 'intranet'
|
|
? C4::Context->preference('staffClientBaseURL')
|
|
: C4::Context->preference('OPACBaseURL');
|
|
|
|
$uri or Koha::Logger->get->warn("Syspref staffClientBaseURL or OPACBaseURL not set!"); # FIXME We should die here
|
|
|
|
$uri ||= "";
|
|
|
|
if ($uri =~ /(.*):\/\/(.*)/) {
|
|
my $oldprotocol = $1;
|
|
if ($oldprotocol ne 'https') {
|
|
Koha::Logger->get->warn('Shibboleth requires OPACBaseURL/staffClientBaseURL to use the https protocol!');
|
|
}
|
|
$uri = $2;
|
|
}
|
|
my $return = $protocol . $uri;
|
|
return $return;
|
|
}
|
|
|
|
sub _get_return {
|
|
my ($query) = @_;
|
|
|
|
my $uri_base_part = _get_uri() . get_script_name();
|
|
|
|
my $uri_params_part = '';
|
|
foreach my $param ( sort $query->url_param() ) {
|
|
# url_param() always returns parameters that were deleted by delete()
|
|
# This additional check ensure that parameter was not deleted.
|
|
my $uriPiece = $query->param($param);
|
|
if ($uriPiece) {
|
|
$uri_params_part .= '&' if $uri_params_part;
|
|
$uri_params_part .= $param . '=';
|
|
$uri_params_part .= $uriPiece;
|
|
}
|
|
}
|
|
$uri_base_part .= '%3F' if $uri_params_part;
|
|
|
|
return $uri_base_part . URI::Escape::uri_escape_utf8($uri_params_part);
|
|
}
|
|
|
|
sub _get_shib_config {
|
|
my $config = C4::Context->config('shibboleth');
|
|
|
|
if ( !$config ) {
|
|
Koha::Logger->get->warn('shibboleth config not defined');
|
|
return 0;
|
|
}
|
|
|
|
if ( $config->{matchpoint}
|
|
&& defined( $config->{mapping}->{ $config->{matchpoint} }->{is} ) )
|
|
{
|
|
my $logger = Koha::Logger->get;
|
|
$logger->debug("koha borrower field to match: " . $config->{matchpoint});
|
|
$logger->debug("shibboleth attribute to match: " . $config->{mapping}->{ $config->{matchpoint} }->{is});
|
|
return $config;
|
|
}
|
|
else {
|
|
if ( !$config->{matchpoint} ) {
|
|
carp 'shibboleth matchpoint not defined';
|
|
}
|
|
else {
|
|
carp 'shibboleth matchpoint not mapped';
|
|
}
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
1;
|
|
__END__
|
|
|
|
=head1 NAME
|
|
|
|
C4::Auth_with_shibboleth
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
use C4::Auth_with_shibboleth;
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
This module is specific to Shibboleth authentication in koha and relies heavily upon the native shibboleth service provider package in your operating system.
|
|
|
|
=head1 CONFIGURATION
|
|
|
|
To use this type of authentication these additional packages are required:
|
|
|
|
=over
|
|
|
|
=item *
|
|
|
|
libapache2-mod-shib2
|
|
|
|
=item *
|
|
|
|
libshibsp5:amd64
|
|
|
|
=item *
|
|
|
|
shibboleth-sp2-schemas
|
|
|
|
=back
|
|
|
|
We let the native shibboleth service provider packages handle all the complexities of shibboleth negotiation for us, and configuring this is beyond the scope of this documentation.
|
|
|
|
But to sum up, to get shibboleth working in koha, as a minimum you will need to:
|
|
|
|
=over
|
|
|
|
=item 1.
|
|
|
|
Create some metadata for your koha instance (if you're in a single instance setup then the default metadata available at https://youraddress.com/Shibboleth.sso/Metadata should be adequate)
|
|
|
|
=item 2.
|
|
|
|
Swap metadata with your Identidy Provider (IdP)
|
|
|
|
=item 3.
|
|
|
|
Map their attributes to what you want to see in koha
|
|
|
|
=item 4.
|
|
|
|
Tell apache that we wish to allow koha to authenticate via shibboleth.
|
|
|
|
This is as simple as adding the below to your virtualhost config (for CGI running):
|
|
|
|
<Location />
|
|
AuthType shibboleth
|
|
Require shibboleth
|
|
</Location>
|
|
|
|
Or (for Plack running):
|
|
|
|
<Location />
|
|
AuthType shibboleth
|
|
Require shibboleth
|
|
ShibUseEnvironment Off
|
|
ShibUseHeaders On
|
|
</Location>
|
|
|
|
IMPORTANT: Please note, if you are running in the plack configuration you should consult https://wiki.shibboleth.net/confluence/display/SHIB2/NativeSPSpoofChecking for security advice regarding header spoof checking settings. (See also bug 17776 on Bugzilla about enabling ShibUseHeaders.)
|
|
|
|
=item 5.
|
|
|
|
Configure koha to listen for shibboleth environment variables.
|
|
|
|
This is as simple as enabling B<useshibboleth> in koha-conf.xml:
|
|
|
|
<useshibboleth>1</useshibboleth>
|
|
|
|
=item 6.
|
|
|
|
Map shibboleth attributes to koha fields, and configure authentication match point in koha-conf.xml.
|
|
|
|
<shibboleth>
|
|
<matchpoint>userid</matchpoint> <!-- koha borrower field to match upon -->
|
|
<mapping>
|
|
<userid is="eduPersonID"></userid> <!-- koha borrower field to shibboleth attribute mapping -->
|
|
</mapping>
|
|
</shibboleth>
|
|
|
|
Note: The minimum you need here is a <matchpoint> block, containing a valid column name from the koha borrowers table, and a <mapping> block containing a relation between the chosen matchpoint and the shibboleth attribute name.
|
|
|
|
=back
|
|
|
|
It should be as simple as that; you should now be able to login via shibboleth in the opac.
|
|
|
|
If you need more help configuring your B<S>ervice B<P>rovider to authenticate against a chosen B<Id>entity B<P>rovider then it might be worth taking a look at the community wiki L<page|http://wiki.koha-community.org/wiki/Shibboleth_Configuration>
|
|
|
|
=head1 FUNCTIONS
|
|
|
|
=head2 logout_shib
|
|
|
|
Sends a logout signal to the native shibboleth service provider and then logs out of koha. Depending upon the native service provider configuration and identity provider capabilities this may or may not perform a single sign out action.
|
|
|
|
logout_shib($query);
|
|
|
|
=head2 login_shib_url
|
|
|
|
Given a query, this will return a shibboleth login url with return code to page with given given query.
|
|
|
|
my $shibLoginURL = login_shib_url($query);
|
|
|
|
=head2 get_login_shib
|
|
|
|
Returns the shibboleth login attribute should it be found present in the http session
|
|
|
|
my $shib_login = get_login_shib();
|
|
|
|
=head2 checkpw_shib
|
|
|
|
Given a shib_login attribute, this routine checks for a matching local user and if found returns true, their cardnumber and their userid. If a match is not found, then this returns false.
|
|
|
|
my ( $retval, $retcard, $retuserid ) = C4::Auth_with_shibboleth::checkpw_shib( $shib_login );
|
|
|
|
=head2 _get_uri
|
|
|
|
_get_uri();
|
|
|
|
A sugar function to that simply returns the current page URI with appropriate protocol attached
|
|
|
|
This routine is NOT exported
|
|
|
|
=head2 _get_shib_config
|
|
|
|
my $config = _get_shib_config();
|
|
|
|
A sugar function that checks for a valid shibboleth configuration, and if found returns a hashref of it's contents
|
|
|
|
This routine is NOT exported
|
|
|
|
=head2 _autocreate
|
|
|
|
my ( $retval, $retcard, $retuserid ) = _autocreate( $config, $match );
|
|
|
|
Given a shibboleth attribute reference and a userid this internal routine will add the given user to Koha and return their user credentials.
|
|
|
|
This routine is NOT exported
|
|
|
|
=head1 SEE ALSO
|
|
|
|
=cut
|