Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Main Koha release repository https://koha-community.org
21434 commits 35 branches 616 tags 1.8 GiB
Perl 45.6%
JavaScript 39.3%
HTML 7.2%
XSLT 3.7%
Vue 1.4%
Other 2.3%
Find a file
Jonathan Druart 35a88a5c44 Bug 12301: Remove warnings on translate scripts 
Using perl v5.18, the following is warned on updating/installing
templates:
  Smartmatch is experimental at ./translate line 54.

Moreover, the following should exist with previous perl versions:

perlcritic xgettext
Subroutine prototypes used at line 29, column 1.  See page 194 of PBP.
(Severity: 5)
Subroutine prototypes used at line 44, column 1.  See page 194 of PBP.
(Severity: 5)
Subroutine prototypes used at line 60, column 1.  See page 194 of PBP.
(Severity: 5)
Subroutine prototypes used at line 72, column 1.  See page 194 of PBP.
(Severity: 5)
Subroutine prototypes used at line 89, column 1.  See page 194 of PBP.
(Severity: 5)
Variable declared in conditional statement at line 105, column 13.
Declare variables outside of the condition.  (Severity: 5)
Subroutine prototypes used at line 127, column 1.  See page 194 of PBP.
(Severity: 5)
Subroutine prototypes used at line 136, column 1.  See page 194 of PBP.
(Severity: 5)
Variable declared in conditional statement at line 190, column 7.
Declare variables outside of the condition.  (Severity: 5)
Subroutine prototypes used at line 237, column 1.  See page 194 of PBP.
(Severity: 5)
Bareword file handle opened at line 238, column 5.  See pages 202,204 of
PBP.  (Severity: 5)
Two-argument "open" used at line 238, column 5.  See page 207 of PBP.
(Severity: 5)
Subroutine prototypes used at line 277, column 1.  See page 194 of PBP.
(Severity: 5)
Subroutine prototypes used at line 311, column 1.  See page 194 of PBP.
(Severity: 5)
Bareword file handle opened at line 350, column 9.  See pages 202,204 of
PBP.  (Severity: 5)
Two-argument "open" used at line 350, column 9.  See page 207 of PBP.
(Severity: 5)
Bareword file handle opened at line 353, column 5.  See pages 202,204 of
PBP.  (Severity: 5)
Bareword file handle opened at line 359, column 5.  See pages 202,204 of
PBP.  (Severity: 5)
Two-argument "open" used at line 359, column 5.  See page 207 of PBP.
(Severity: 5)

perl -wc xgettext.pl
\1 better written as $1 at TmplTokenizer.pm line 474.
main::token_negligible_p() called too early to check prototype at
xgettext.pl line 52.
xgettext.pl syntax OK

Test plan:
Apply this patch and verify the warnings/errors does not appear anymore
and no regression is found on creating/updating/installing templates.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no koha-qa errros.
Tested with perl v5.18.2
No warnings, no problem detected on create/update/install i18n files

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-05-30 15:46:17 -03:00
acqui Bug 3050 - Add an option to upload scanned invoices #2/3 2014-05-25 21:14:42 +00:00
admin Bug 12230: (follow-up) maxsuspensiondays should be set to NULL if not set 2014-05-26 01:40:15 +00:00
authorities Bug 10862: Add search history to the intranet interface 2014-05-05 03:06:33 +00:00
basket Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
C4 Bug 11826: Use XSLT handler object in showmarc, Record.pm 2014-05-26 03:52:45 +00:00
catalogue Bug 11826: Use XSLT handler object in showmarc, Record.pm 2014-05-26 03:52:45 +00:00
cataloguing Bug 10330 - Rename system preference authoritysep to AuthoritySeperator 2014-05-23 13:26:48 +00:00
circ Bug 11629: (follow-up) Add message for librarian that status was updated 2014-05-26 03:23:37 +00:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Bug 12312 - correctly upgrade under Apache 2.2 2014-05-26 03:41:55 +00:00
docs Bug 7143: Updating history with new developers 2014-04-14 14:37:48 +00:00
errors
etc Bug 9612: (follow-up) restore elementSetName in Context.pm 2014-05-19 16:46:57 +00:00
install_misc
installer Bug 11629: DBRev 3.17.00.007 2014-05-26 03:28:46 +00:00
Koha Bug 11826: (follow-up) run perltidy on Koha/XSLT_Handler.pm 2014-05-26 03:59:11 +00:00
koha-tmpl Bug 11629: (follow-up) fix message displayed when item is made available 2014-05-26 03:26:02 +00:00
labels Bug 8375: Use TrueType fonts in PDF::Reuse 2014-05-05 21:53:18 +00:00
members Bug 12292: ensure that patrons are not displayed as restricted even when the last restriction has expired 2014-05-22 16:51:14 +00:00
misc Bug 12301: Remove warnings on translate scripts 2014-05-30 15:46:17 -03:00
offline_circ
opac Bug 11826: Use XSLT handler object in showmarc, Record.pm 2014-05-26 03:52:45 +00:00
OpenILS
patron_lists
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins
reports Bug 12214: display SQL errors in reports to users 2014-05-09 14:40:01 +00:00
reserve Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-01-30 16:19:55 +00:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 11263: Use all languages instead of just the translated ones 2014-05-05 05:01:36 +00:00
services
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 4068: (follow-up) use URI::Escape 2014-05-08 16:36:10 +00:00
svc Bug 12114: (QA Followup) Use JSON instead of JSON::XS 2014-04-25 15:32:06 +00:00
t Bug 6254: (follow-up) work-around to fix a failing test case 2014-05-26 04:19:19 +00:00
tags
test
tmp/modified_authorities
tools Bug 8970 - fix MARC import under plack 2014-05-25 23:51:12 +00:00
virtualshelves Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
xt Bug 12271: (follow-up) teach valid-templates.t how to include specified templates 2014-05-19 16:14:28 +00:00
.htaccess
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
about.pl Bug 11596: report warnings on the about patch if indexing options in koha-conf.xml are missing 2014-04-20 17:07:04 +00:00
changelanguage.pl
edithelp.pl
fix-perl-path.PL
help.pl
INSTALL
install-CPAN.pl
INSTALL.debian
INSTALL.fedora7
INSTALL.opensuse
INSTALL.ubuntu
koha_perl_deps.pl
kohaversion.pl Bug 11629: DBRev 3.17.00.007 2014-05-26 03:28:46 +00:00
LICENSE
mainpage.pl Bug 7567 - Use, display, filter News by library 2014-04-07 18:14:19 +00:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
MANIFEST.SKIP
README
README.robots
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

README 

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/