Nick Clemens
e941dfdc99
This patch adds a new page opac-reset-password where a user cna enter their login
(userid or carndumber), current password, and new password.
If the user has a password expiration date and the current password is correct and
the new passwords match and meet requirements their password will be updated and the
expiration date reset
A patron whose password does not expire will be reidrected to login to change their password
To test:
1 - Apply patch, updatedatabase, enable new syspref EnableExpiredPasswordReset
2 - Set 'Password expiration' for a patron category
Home->Administration->Patron categories->Edit
3 - Create a new patron in this category with a userid/password set, and an email
4 - Update the patron with an expiration to be expired
UPDATE borrowers SET password_expiration='2022-01-01' WHERE borrowernumber=51;
5 - Give the borrower catalogue permission
6 - Attempt to log in to Straff interface
7 - Confirm you are signed out and notified that password must be reset
8 - Click 'Reset your password' link
9 - You should see the reset password page with fields for: login, current password, new password, conmfirm password
10 - enter invalid/incomplete credentials
11 - Confirm you are notified of invlaid credentials
12 - Fill in all fields, but enter current password as new password
13 - Confirm you are notified of no change
14 - Set minimum password length / strong password requirement for category
15 - Confirm you receive error if new password too short or not secure
16 - Enter a valid new password and submit and confirm update is successful
17 - Confirm you have buttons to go to OPAC or Staff and that both work
18 - Confirm you cna log in (i.e. expiration has been reset)
19 - Expire the users password
20 - Remove catalogue permission
21 - Reset password again and confirm only OPAC link
Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
107 lines
3.8 KiB
Perl
Executable file
107 lines
3.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
|
|
use C4::Auth qw( get_template_and_user checkpw checkpw_hash );
|
|
use C4::Context;
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use Koha::Patrons;
|
|
|
|
use Try::Tiny qw( catch try );
|
|
|
|
my $query = CGI->new;
|
|
|
|
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "opac-reset-password.tt",
|
|
query => $query,
|
|
type => "opac",
|
|
authnotrequired => 1,
|
|
}
|
|
);
|
|
|
|
my $op = $query->param('op');
|
|
|
|
if ( $op eq 'update' ) {
|
|
my $userid = $query->param('userid');
|
|
my $currentpassword = $query->param('currentpassword');
|
|
my $newpassword = $query->param('newpassword');
|
|
my $confirmpassword = $query->param('confirmpassword');
|
|
|
|
my $patron = Koha::Patrons->find( { userid => $userid } );
|
|
$patron = Koha::Patrons->find( { cardnumber => $userid } ) unless $patron;
|
|
|
|
if ( $patron && $patron->password_expiration_date ) {
|
|
if ( $patron->account_locked ) {
|
|
$template->param( error => 'account_locked' );
|
|
}
|
|
elsif ( $currentpassword && $newpassword && $confirmpassword ) {
|
|
my $error;
|
|
if ( C4::Auth::checkpw_hash( $currentpassword, $patron->password ) ) {
|
|
|
|
if ( $newpassword ne $confirmpassword ) {
|
|
$template->param( 'error' => 'passwords_mismatch' );
|
|
}
|
|
elsif ( $currentpassword eq $newpassword ) {
|
|
$template->param( 'error' => 'no_change' );
|
|
}
|
|
else {
|
|
try {
|
|
$patron->set_password( { password => $newpassword } );
|
|
$template->param( 'password_updated' => '1' );
|
|
$template->param( 'staff_access' => 1 )
|
|
if $patron->has_permission( { catalogue => 1 } );
|
|
}
|
|
catch {
|
|
$error = 'password_too_short'
|
|
if $_->isa('Koha::Exceptions::Password::TooShort');
|
|
$error = 'password_too_weak'
|
|
if $_->isa('Koha::Exceptions::Password::TooWeak');
|
|
$error = 'password_has_whitespaces'
|
|
if $_->isa(
|
|
'Koha::Exceptions::Password::WhitespaceCharacters');
|
|
$template->param( 'error' => $error );
|
|
};
|
|
}
|
|
}
|
|
else {
|
|
$template->param( 'error' => 'invalid_credentials' );
|
|
$patron->update(
|
|
{ login_attempts => $patron->login_attempts + 1 } )
|
|
if !$patron->account_locked;
|
|
}
|
|
}
|
|
else {
|
|
$template->param( 'incomplete_form' => '1' );
|
|
}
|
|
}
|
|
elsif ( !$patron ) {
|
|
template->param( 'error' => 'invalid_credentials' );
|
|
}
|
|
elsif ( !$patron->password_expiration_date ) {
|
|
$template->param( 'error' => 'no_expire' );
|
|
}
|
|
else {
|
|
$template->param( 'error' => 'unknown' );
|
|
}
|
|
}
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output, undef,
|
|
{ force_no_caching => 1 };
|