6f599652b1
This patch fixes a major issue introduced by the
commit 5c4fdcf Bug 11742: A letter code should be unique.
The interface should let the possibility to create a default template
letter and some specific ones, with the same letter code (letter.code).
The patches submitted on bug 11742 tried to fix an issue based on a
(very bad) assumption: letter.code should be considered as a primary key and
should be uniq.
This patch reintroduces this behavior.
Note that the interface will block a letter code used in different
module (this is consistent not to have the same letter code used for different
needs).
This patch is absolutely not perfect, it just tries to change as less
change as possible and to use new tested subroutines.
Test plan:
1/ Verify that the problem raised on bug 11742 does not appears anymore.
2/ Verify there are no regression on adding, editing, copying, deleting
letters.
3/ Verify you are allowed to create a default letter template with a letter
code and to reuse for a specific letter (i.e. for a given library).
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
63 lines
1.4 KiB
Perl
Executable file
63 lines
1.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Copyright 2014 BibLibre
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Service;
|
|
use C4::Letters qw( GetLetters );
|
|
|
|
=head1 NAME
|
|
|
|
svc/letters - Web service for getting letters
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
GET /svc/letters
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
For the moment, this service is only used to get a letter from a letter code.
|
|
|
|
=head1 METHODS
|
|
|
|
=cut
|
|
|
|
=head2 set_preference
|
|
|
|
=over 4
|
|
|
|
GET /svc/letters/$code
|
|
|
|
=back
|
|
|
|
Used to get letters with a given letter code.
|
|
|
|
=cut
|
|
|
|
our ( $query, $response ) = C4::Service->init( tools => 'edit_notices' );
|
|
|
|
sub get_letters {
|
|
my $letters = GetLetters({ code => $query->param('code'), branchcode => $query->param('branchcode') });
|
|
$response->param( letters => $letters );
|
|
C4::Service->return_success( $response );
|
|
}
|
|
|
|
C4::Service->dispatch(
|
|
[ 'GET /', [ 'code' ], \&get_letters ],
|
|
);
|