Koha/koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js
Jonathan Druart 37370c415a
Bug 25563: (bug 24386 follow-up) Don't disable submit button if form has not been submitted yet
On bug 24386 we prevent double form submission using the our own preventDoubleFormSubmit JS function.

The problem is that we are checking some conditions, and prevent the
form submission if something is not filled (for instance no checkbox
checked, or no fund selected).

Technically it means that:
- click the submit button
- it submits the form
- we disable the submit button
- we prevent the form to be submitted before something is wrong
At this stage the button is disabled and the form cannot be longer be
submitted.

This patch replaces the "on submit" event of the form with the "on click" event of the submit button.
Which means we are going to:
- click the submit button
- we prevent the form to be submitted before something is wrong
=> The button will only be disabled if the form is really submitted

Test plan:
- stage a marc record
- acquisitions: have a basket
- click on "Add to basket"
- "From a staged file"
- Don't tick the record
- Save
- You should see an expected error message
- Tick the record
- Save
- You should see an expected error message
- Choose a fund
- Click the "Save" button as many times as you can, to try double submit
it.
=> The order is saved

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-05-22 09:07:02 +01:00

157 lines
5.9 KiB
JavaScript

/* global dataTablesDefaults ERR_NO_RECORD_SELECTED ERR_INVALID_QUANTITY ERR_FUNDS_MISSING MSG_LOADING */
$(document).ready(function() {
$("#Aform").preventDoubleFormSubmit();
$("#files").dataTable($.extend(true, {}, dataTablesDefaults, {
"aoColumnDefs": [
{ "bSortable": false, "bSearchable": false, 'aTargets': [ 'NoSort' ] },
{ "sType": "anti-the", "aTargets" : [ "anti-the" ] },
{ "sType": "title-string", "aTargets" : [ "title-string" ] }
],
"sPaginationType": "full",
"aaSorting": []
}) );
checkOrderBudgets();
var all_budget_id = $("#all_budget_id");
$("#all_budget_id,[name='budget_id'],.budget_code_item,[name='import_record_id']").on("change", function(){
checkOrderBudgets();
});
$("#records_to_import fieldset.rows div").hide();
$('input:checkbox[name="import_record_id"]').change(function(){
var container = $(this).parents("fieldset");
if ( $(this).is(':checked') ) {
$(container).addClass("selected");
$(container).removeClass("unselected");
$(container).find("div").toggle(true);
} else {
$(container).addClass("unselected");
$(container).removeClass("selected");
$(container).find("div").toggle(false);
}
} );
$("input:checkbox").prop("checked", false);
$("div.biblio.unselected select").prop('disabled', false);
$("div.biblio.unselected input").prop('disabled', false);
$("#checkAll").click(function(){
$("#Aform").checkCheckboxes();
$("input:checkbox[name='import_record_id']").change();
return false;
});
$("#unCheckAll").click(function(){
$("#Aform").unCheckCheckboxes();
$("input:checkbox[name='import_record_id']").change();
return false;
});
$("input#add_order").on("click", function(e){
e.preventDefault();
if ( $("input:checkbox[name='import_record_id']:checked").length < 1 ) {
alert( ERR_NO_RECORD_SELECTED );
return false;
}
var error = 0;
$("input:checkbox[name='import_record_id']:checked").parents('fieldset').find('input[name="quantity"]').each(function(){
if ( $(this).val().length < 1 || isNaN( $(this).val() ) ) {
error++;
}
});
if ( error > 0 ) {
alert( error + " " + ERR_INVALID_QUANTITY );
return false;
}
error = checkOrderBudgets();
if ( error > 0 ) {
alert( ERR_FUNDS_MISSING );
return false;
}
disableUnchecked($(this.form));
$(this.form).submit();
});
$('#tabs').tabs();
$(".previewData").on("click", function(e){
e.preventDefault();
var ltitle = $(this).text();
var page = $(this).attr("href");
$("#dataPreviewLabel").text(ltitle);
$("#dataPreview .modal-body").load(page + " div");
$('#dataPreview').modal({show:true});
});
$("#dataPreview").on("hidden.bs.modal", function(){
$("#dataPreviewLabel").html("");
$("#dataPreview .modal-body").html("<div id=\"loading\"><img src=\"[% interface | html %]/[% theme | html %]/img/spinner-small.gif\" alt=\"\" /> " + MSG_LOADING + "</div>");
});
});
function disableUnchecked(){
$("fieldset.biblio.unselected").each(function(){
$(this).remove();
});
return 1;
}
function checkOrderBudgets(){
var unset_funds = 0;
var all_budget_id = $("#all_budget_id");
// If we don't have an overarching default set we need to check each selected order
if ( !all_budget_id.val() ) {
$("fieldset.biblio.rows.selected").each(function(){
var default_order_fund = $(this).find("[name='budget_id']");
// For each order we see if budget is set for order
if( !default_order_fund.val() ){
$(this).find(".item_fund.required").show();
//If not we need to check each item on the order
var item_funds = $(this).find(".budget_code_item");
if( item_funds.length ){
item_funds.each(function(){
if( !$(this).val() ){
$(this).addClass('required').prop("required", true);
unset_funds++;
} else {
$(this).removeClass('required').prop("required", false);
}
});
} else {
//If the order has no items defined then the order level fund is required
default_order_fund.addClass('required').prop("required", true);
$(this).find(".fund span.required").show();
$(this).find(".item_fund.required").hide();
unset_funds++;
}
} else {
$(this).find(".fund span.required").hide();
// If fund is set for order then none of the others are required
$(this).find(".budget_code_item").each(function(){
if( !$(this).val() ){
$(this).val( default_order_fund.val() );
$(this).removeClass('required').prop("required", false);
}
});
$(this).removeClass('required').prop("required", false);
}
});
} else {
// Default is set overall, we just need to populate it through
// to each order/item
$("[name='budget_id'],.budget_code_item").each(function(){
if( !$(this).val() ){
$(this).val( all_budget_id.val() );
$(this).removeClass('required').prop("required", false);
$(".item_fund.required").hide();
$(".fund span.required").hide();
}
});
}
return unset_funds;
}