Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin
History
Mark Tompsett fea7b9b4d4 Bug 4502: An attempt to make things more sensible. 
The reason the budget_period_id was not defined was because in
two cases it was not passed! This patch adds those missing
parameters. And as a result, cuts out the attempt to default the
authcat to '' unless the budget_period_id is defined.

Additionally, the start and end months don't seem to be passed,
so rather than have it blow up, checking them forces the else
case logic.

budget_period_id is the budget id. If you have two budgets,
you can craft a URL to work with budget_period_id matching
those two ids. Anything else should trigger the new error which
was modified to reflect more of what the problem is.

Follow the test plan in comment #6. Feel free to also to attempt
crafting URLs and triggering errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Well, works and does not explode any more
No errors

To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl
on your staff page, an intriguing 'Planning for by Asort1' appears :)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2015-11-19 20:23:46 -03:00
..
add_user_search.pl Bug 15109: Make name the default sort order for all patron searches 2015-11-17 09:49:21 -03:00
admin-home.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
aqbudgetperiods.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
aqbudgets.pl Bug 14931: Remove C4::Dates from files admin/aq*.pl 2015-10-29 12:00:28 -03:00
aqcontract.pl Bug 14931: (qa followu-up) small improvements 2015-10-29 12:00:42 -03:00
aqplan.pl Bug 4502: An attempt to make things more sensible. 2015-11-19 20:23:46 -03:00
audio_alerts.pl Bug 11431: (QA followup) Typo in help file / variable name 2015-11-04 12:33:44 -03:00
auth_subfields_structure.pl Bug 9006: Remove AUTOLOAD in C4::Context 2015-07-20 10:11:41 -03:00
auth_tag_structure.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
authorised_values.pl Bug 10937: cleanup and rename DOCTYPECAT to ITEMTYPECAT 2015-10-22 11:06:22 -03:00
authtypes.pl Bug 10947: Fix editing the default authority type 2015-05-19 09:25:59 -03:00
biblio_framework.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
branch_transfer_limits.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
branches.pl Bug 8802: On editing a library group category type is not set 2015-06-23 10:14:13 -03:00
categorie.pl Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* 2015-11-05 10:57:41 -03:00
check_budget_parent.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
check_parent_total.pl Bug 14383: admin: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
checkmarc.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
cities.pl Bug 14888: Update copyright and wording 2015-10-05 12:00:38 -03:00
classsources.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
clone-rules.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
columns_settings.pl Bug 13875: Columns configuration - Allow underscore in table name 2015-04-08 14:51:59 -03:00
columns_settings.yml Bug 14841: Fine column is not manage by columns settings 2015-10-13 11:38:23 -03:00
currency.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
didyoumean.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
env_tz_test.pl Bug 14383: admin: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
fieldmapping.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
import_export_framework.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
item_circulation_alerts.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
items_search_field.pl Bug 11425: Add item search form in staff interface 2014-11-04 19:08:12 -03:00
items_search_fields.pl Bug 11425: Add item search form in staff interface 2014-11-04 19:08:12 -03:00
itemtypes.pl Bug 15093: Load/show saved item type group and hideinopac 2015-11-01 17:10:44 -03:00
koha2marclinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
localization.pl Bug 14100: Generic solution for language overlay - Item types 2015-10-27 12:34:06 -03:00
marc_subfields_structure.pl Bug 9006: Remove AUTOLOAD in C4::Context 2015-07-20 10:11:41 -03:00
marctagstructure.pl Bug 1487: Store the "display only used tags/subf" value in a cookie 2015-04-30 15:23:01 -03:00
matching-rules.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
oai_set_mappings.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
oai_sets.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
patron-attr-types.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
preferences.pl Bug 14145: Noisy warns in admin/preferences.pl 2015-05-22 09:37:24 -03:00
printers.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
smart-rules.pl Bug 15087: hardduedate should not be inserted as 0000-00-00 but NULL 2015-11-02 11:32:06 -03:00
sru_modmapping.pl Bug 6536: Add a form for SRU Field mapping 2014-09-01 10:08:50 -03:00
stopwords.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
systempreferences.pl Bug 11584: Add wysiwyg editor to system preferences dealing with HTML 2015-08-28 10:28:50 -03:00
transport-cost-matrix.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
z3950servers.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00