Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Marcel de Rooy 37d07b28ce Bug 18996: [QA Follow-up] Remove global variables from Message.t 
As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.

Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-08-20 08:27:27 -03:00
..
Acquisition Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
api/v1 Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth Bug 15756: Some tests for haspermission in C4::Auth 2016-02-23 20:54:42 +00:00
Authorities Bug 9988: Refactor the cron script 2017-04-13 08:53:47 -04:00
Biblio Bug 18951: Adjust Isbd.t 2017-07-24 13:37:18 -03:00
Circulation Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
data
Exporter Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
Items Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
LDAP
Letters Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible 2017-06-15 15:56:00 -03:00
Members Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-13 16:18:59 -03:00
Patron Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
Reserves Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-26 14:36:34 -03:00
selenium Bug 18982: Remove data in the correct order 2017-07-26 13:50:44 -03:00
Serials Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
SIP Bug 18996: [QA Follow-up] Remove global variables from Message.t 2017-08-20 08:27:27 -03:00
Template/Plugin Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
www Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
XSLT_Handler
00-strict.t Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl 2017-05-08 09:22:27 -04:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Acquisition.t Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
AdditionalField.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
ArticleRequests.t Bug 18766: Remove itemtype-related warnings from ArticleRequests.t 2017-06-09 10:50:53 -03:00
AudioAlerts.t
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-07-26 14:36:34 -03:00
Auth_with_cas.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Bookseller.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Breeding.t
Budgets.t Bug 18941 - Unit tests 2017-08-10 16:25:34 -03:00
Calendar.t Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
Circulation.t Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1; 2017-08-15 12:17:42 -03:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
DecreaseLoanHighHolds.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t
Hold.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds.t Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds 2017-07-05 13:42:52 -03:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-07-24 14:12:27 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-14 13:57:49 +00:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_Database.t
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Elasticsearch_Indexer.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 19042: Add mock IndependentBranches=0 for the other test 2017-08-10 16:25:32 -03:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Plugins.t Bug 15879: Add Tests 2017-01-11 14:03:00 +00:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
Reserves.t Bug 19047: Fix AddBiblio call in Reserves.t 2017-08-10 16:25:32 -03:00
rollingloans.t Bug 17829: Execute rollingloans tests in a transaction 2017-07-26 16:39:17 -03:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-07-08 13:08:09 +00:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Tags.t
Templates.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
TestBuilder.t Bug 18182: Tests all Koha::Objects-based modules 2017-04-21 00:10:50 +00:00
Upload.t Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
UsageStats.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
Virtualshelves.t Bug 18672: [QA Follow-up] Simplify without sleep 2017-07-17 13:19:43 -03:00
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t
zebra_config.pl