Jonathan Druart
1139972748
Test plan: = Koha = Apply the first patch, prove xt/vue_tidy.t and notice the failure Apply this patch, now it passes = QA test = Apply the change to the merge request linked with this qa-test-tools' issue: https://gitlab.com/koha-community/qa-test-tools/-/issues/62 inside your ktd container (at /kohadevbox/qa-test-tools/) Edit a .js within koha-tmpl/intranet-tmpl/prog/js/vue and a .ts file (cypress test) with something not pretty Commit and run the QA script => It's failing! Pretty the change, commit again, run the QA script => It's happy! = KTD - git hook = Go to the merge request linked with this ktd's issue: https://gitlab.com/koha-community/koha-testing-docker/-/issues/374 Copy the modified git hook to .git/hooks/ktd/pre-commit Edit a .js within koha-tmpl/intranet-tmpl/prog/js/vue and a .ts file (cypress test) with something not pretty Commit => Notice that the commit content is pretty! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
319 lines
11 KiB
TypeScript
319 lines
11 KiB
TypeScript
import { mount } from "@cypress/vue";
|
|
const dayjs = require("dayjs"); /* Cannot use our calendar JS code, it's in an include file (!)
|
|
Also note that moment.js is deprecated */
|
|
|
|
const dates = {
|
|
today_iso: dayjs().format("YYYY-MM-DD"),
|
|
today_us: dayjs().format("MM/DD/YYYY"),
|
|
tomorrow_iso: dayjs().add(1, "day").format("YYYY-MM-DD"),
|
|
tomorrow_us: dayjs().add(1, "day").format("MM/DD/YYYY"),
|
|
};
|
|
function get_license() {
|
|
return {
|
|
license_id: 1,
|
|
name: "license 1",
|
|
description: "my first license",
|
|
type: "local",
|
|
status: "active",
|
|
started_on: dates["today_iso"],
|
|
ended_on: dates["tomorrow_iso"],
|
|
user_roles: [],
|
|
documents: [
|
|
{
|
|
license_id: 1,
|
|
file_description: "file description",
|
|
file_name: "file.json",
|
|
notes: "file notes",
|
|
physical_location: "file physical location",
|
|
uri: "file uri",
|
|
uploaded_on: "2022-10-27T11:57:02+00:00",
|
|
},
|
|
],
|
|
};
|
|
}
|
|
|
|
describe("License CRUD operations", () => {
|
|
beforeEach(() => {
|
|
cy.login();
|
|
cy.title().should("eq", "Koha staff interface");
|
|
cy.intercept(
|
|
"GET",
|
|
"/cgi-bin/koha/svc/config/systempreferences/?pref=ERMModule",
|
|
'{"value":"1"}'
|
|
);
|
|
cy.intercept(
|
|
"GET",
|
|
"/cgi-bin/koha/svc/config/systempreferences/?pref=ERMProviders",
|
|
'{"value":"local"}'
|
|
);
|
|
});
|
|
|
|
it("List license", () => {
|
|
// GET license returns 500
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", {
|
|
statusCode: 500,
|
|
error: "Something went wrong",
|
|
});
|
|
cy.visit("/cgi-bin/koha/erm/erm.pl");
|
|
cy.get("#navmenulist").contains("Licenses").click();
|
|
cy.get("main div[class='dialog alert']").contains(
|
|
/Something went wrong/
|
|
);
|
|
|
|
// GET licenses returns empty list
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", []);
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
cy.get("#licenses_list").contains("There are no licenses defined");
|
|
|
|
// GET licenses returns something
|
|
let license = get_license();
|
|
let licenses = [license];
|
|
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", {
|
|
statusCode: 200,
|
|
body: licenses,
|
|
headers: {
|
|
"X-Base-Total-Count": "1",
|
|
"X-Total-Count": "1",
|
|
},
|
|
});
|
|
cy.intercept("GET", "/api/v1/erm/licenses/*", license);
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
cy.get("#licenses_list").contains("Showing 1 to 1 of 1 entries");
|
|
});
|
|
|
|
it("Add license", () => {
|
|
// Click the button in the toolbar
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
cy.contains("New license").click();
|
|
cy.get("#licenses_add h2").contains("New license");
|
|
|
|
// Fill in the form for normal attributes
|
|
let license = get_license();
|
|
|
|
cy.get("#licenses_add").contains("Submit").click();
|
|
cy.get("input:invalid,textarea:invalid,select:invalid").should(
|
|
"have.length",
|
|
4
|
|
);
|
|
cy.get("#license_name").type(license.name);
|
|
cy.get("#license_description").type(license.description);
|
|
cy.get("#licenses_add").contains("Submit").click();
|
|
cy.get("#license_type .vs__search").type(license.type + "{enter}", {
|
|
force: true,
|
|
});
|
|
cy.get("#license_status .vs__search").type(license.status + "{enter}", {
|
|
force: true,
|
|
});
|
|
|
|
cy.get("#started_on+input").click();
|
|
cy.get(".flatpickr-calendar")
|
|
.eq(0)
|
|
.find("span.today")
|
|
.click({ force: true });
|
|
|
|
cy.get("#ended_on+input").click();
|
|
cy.get(".flatpickr-calendar")
|
|
.eq(1)
|
|
.find("span.today")
|
|
.next("span")
|
|
.click();
|
|
|
|
// Add new document
|
|
cy.get("#documents").contains("Add new document").click();
|
|
cy.get("#document_0 input[id=file_0]").click();
|
|
cy.get("#document_0 input[id=file_0]").selectFile(
|
|
"t/cypress/fixtures/file.json"
|
|
);
|
|
cy.get("#document_0 .file_information span").contains("file.json");
|
|
cy.get("#document_0 input[id=file_description_0]").type(
|
|
"file description"
|
|
);
|
|
cy.get("#document_0 input[id=physical_location_0]").type(
|
|
"file physical location"
|
|
);
|
|
cy.get("#document_0 input[id=uri_0]").type("file URI");
|
|
cy.get("#document_0 input[id=notes_0]").type("file notes");
|
|
|
|
// Submit the form, get 500
|
|
cy.intercept("POST", "/api/v1/erm/licenses", {
|
|
statusCode: 500,
|
|
error: "Something went wrong",
|
|
});
|
|
cy.get("#licenses_add").contains("Submit").click();
|
|
cy.get("main div[class='dialog alert']").contains(
|
|
"Something went wrong: Error: Internal Server Error"
|
|
);
|
|
|
|
// Submit the form, success!
|
|
cy.intercept("POST", "/api/v1/erm/licenses", {
|
|
statusCode: 201,
|
|
body: license,
|
|
});
|
|
cy.get("#licenses_add").contains("Submit").click();
|
|
cy.get("main div[class='dialog message']").contains("License created");
|
|
});
|
|
|
|
it("Edit license", () => {
|
|
let license = get_license();
|
|
let licenses = [license];
|
|
// Click the 'Edit' button from the list
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", {
|
|
statusCode: 200,
|
|
body: licenses,
|
|
headers: {
|
|
"X-Base-Total-Count": "1",
|
|
"X-Total-Count": "1",
|
|
},
|
|
});
|
|
cy.intercept("GET", "/api/v1/erm/licenses/*", license).as(
|
|
"get-license"
|
|
);
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
cy.get("#licenses_list table tbody tr:first").contains("Edit").click();
|
|
cy.wait("@get-license");
|
|
cy.wait(500); // Cypress is too fast! Vue hasn't populated the form yet!
|
|
cy.get("#licenses_add h2").contains("Edit license");
|
|
|
|
// Form has been correctly filled in
|
|
cy.get("#license_name").should("have.value", license.name);
|
|
cy.get("#license_description").should(
|
|
"have.value",
|
|
license.description
|
|
);
|
|
cy.get("#license_type .vs__selected").contains("Local");
|
|
cy.get("#license_status .vs__selected").contains("Active");
|
|
cy.get("#started_on").invoke("val").should("eq", dates["today_iso"]);
|
|
cy.get("#ended_on").invoke("val").should("eq", dates["tomorrow_iso"]);
|
|
|
|
// Test related document
|
|
cy.get("#document_0 .file_information span").contains("file.json");
|
|
|
|
// Submit the form, get 500
|
|
cy.intercept("PUT", "/api/v1/erm/licenses/*", {
|
|
statusCode: 500,
|
|
error: "Something went wrong",
|
|
});
|
|
cy.get("#licenses_add").contains("Submit").click();
|
|
cy.get("main div[class='dialog alert']").contains(
|
|
"Something went wrong: Error: Internal Server Error"
|
|
);
|
|
|
|
// Submit the form, success!
|
|
cy.intercept("PUT", "/api/v1/erm/licenses/*", {
|
|
statusCode: 200,
|
|
body: license,
|
|
});
|
|
cy.get("#licenses_add").contains("Submit").click();
|
|
cy.get("main div[class='dialog message']").contains("License updated");
|
|
});
|
|
|
|
it("Show license", () => {
|
|
let license = get_license();
|
|
let licenses = [license];
|
|
// Click the "name" link from the list
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", {
|
|
statusCode: 200,
|
|
body: licenses,
|
|
headers: {
|
|
"X-Base-Total-Count": "1",
|
|
"X-Total-Count": "1",
|
|
},
|
|
});
|
|
cy.intercept("GET", "/api/v1/erm/licenses/*", license).as(
|
|
"get-license"
|
|
);
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
let name_link = cy.get(
|
|
"#licenses_list table tbody tr:first td:first a"
|
|
);
|
|
name_link.should(
|
|
"have.text",
|
|
license.name + " (#" + license.license_id + ")"
|
|
);
|
|
name_link.click();
|
|
cy.wait("@get-license");
|
|
cy.wait(500); // Cypress is too fast! Vue hasn't populated the form yet!
|
|
cy.get("#licenses_show h2").contains("License #" + license.license_id);
|
|
});
|
|
|
|
it("Delete license", () => {
|
|
let license = get_license();
|
|
let licenses = [license];
|
|
|
|
// Click the 'Delete' button from the list
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", {
|
|
statusCode: 200,
|
|
body: licenses,
|
|
headers: {
|
|
"X-Base-Total-Count": "1",
|
|
"X-Total-Count": "1",
|
|
},
|
|
});
|
|
cy.intercept("GET", "/api/v1/erm/licenses/*", license);
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
|
|
cy.get("#licenses_list table tbody tr:first")
|
|
.contains("Delete")
|
|
.click();
|
|
cy.get(".dialog.alert.confirmation h1").contains("remove this license");
|
|
cy.contains(license.name);
|
|
|
|
// Accept the confirmation dialog, get 500
|
|
cy.intercept("DELETE", "/api/v1/erm/licenses/*", {
|
|
statusCode: 500,
|
|
error: "Something went wrong",
|
|
});
|
|
cy.contains("Yes, delete").click();
|
|
cy.get("main div[class='dialog alert']").contains(
|
|
"Something went wrong: Error: Internal Server Error"
|
|
);
|
|
|
|
// Accept the confirmation dialog, success!
|
|
cy.intercept("DELETE", "/api/v1/erm/licenses/*", {
|
|
statusCode: 204,
|
|
body: null,
|
|
});
|
|
cy.get("#licenses_list table tbody tr:first")
|
|
.contains("Delete")
|
|
.click();
|
|
cy.get(".dialog.alert.confirmation h1").contains("remove this license");
|
|
cy.contains("Yes, delete").click();
|
|
cy.get("main div[class='dialog message']")
|
|
.contains("License")
|
|
.contains("deleted");
|
|
|
|
// Delete from show
|
|
// Click the "name" link from the list
|
|
cy.intercept("GET", "/api/v1/erm/licenses*", {
|
|
statusCode: 200,
|
|
body: licenses,
|
|
headers: {
|
|
"X-Base-Total-Count": "1",
|
|
"X-Total-Count": "1",
|
|
},
|
|
});
|
|
cy.intercept("GET", "/api/v1/erm/licenses/*", license).as(
|
|
"get-license"
|
|
);
|
|
cy.visit("/cgi-bin/koha/erm/licenses");
|
|
let name_link = cy.get(
|
|
"#licenses_list table tbody tr:first td:first a"
|
|
);
|
|
name_link.should(
|
|
"have.text",
|
|
license.name + " (#" + license.license_id + ")"
|
|
);
|
|
name_link.click();
|
|
cy.wait("@get-license");
|
|
cy.wait(500); // Cypress is too fast! Vue hasn't populated the form yet!
|
|
cy.get("#licenses_show h2").contains("License #" + license.license_id);
|
|
|
|
cy.get("#licenses_show .action_links .fa-trash").click();
|
|
cy.get(".dialog.alert.confirmation h1").contains("remove this license");
|
|
cy.contains("Yes, delete").click();
|
|
|
|
//Make sure we return to list after deleting from show
|
|
cy.get("#licenses_list table tbody tr:first");
|
|
});
|
|
});
|