Koha/C4/Serials/Frequency.pm
Jonathan Druart 9d6d641d1f Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.

This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests

And a lot of other manual changes.

export.pl is a dirty script that can be found on bug 17600.

"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \;

The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules

Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).

EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members.

@EXPORT and @EXPORT_OK are the two main variables used during export operation.

@EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace.

@EXPORT_OK does export of symbols on demand basis.
"""

If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
  - use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-16 08:58:47 +02:00

290 lines
5.6 KiB
Perl

package C4::Serials::Frequency;
# Copyright 2011-2013 Biblibre SARL
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
use C4::Context;
use vars qw(@ISA @EXPORT);
BEGIN {
require Exporter;
@ISA = qw(Exporter);
@EXPORT = qw(
GetSubscriptionFrequencies
GetSubscriptionFrequency
AddSubscriptionFrequency
ModSubscriptionFrequency
DelSubscriptionFrequency
GetSubscriptionsWithFrequency
);
}
=head1 NAME
C4::Serials::Frequency - Serials Frequency module
=head1 FUNCTIONS
=head2 GetSubscriptionFrequencies
=over 4
=item C<@frequencies> = &GetSubscriptionFrequencies();
gets frequencies restricted on filters
=back
=cut
sub GetSubscriptionFrequencies {
my $dbh = C4::Context->dbh;
my $query = qq{
SELECT *
FROM subscription_frequencies
ORDER BY displayorder
};
my $sth = $dbh->prepare($query);
$sth->execute();
my $results = $sth->fetchall_arrayref( {} );
return @$results;
}
=head2 GetSubscriptionFrequency
=over 4
=item $frequency = &GetSubscriptionFrequency($frequencyid);
gets frequency where $frequencyid is the identifier
=back
=cut
sub GetSubscriptionFrequency {
my ($frequencyid) = @_;
my $dbh = C4::Context->dbh;
my $query = qq{
SELECT *
FROM subscription_frequencies
WHERE id = ?
};
my $sth = $dbh->prepare($query);
$sth->execute($frequencyid);
return $sth->fetchrow_hashref;
}
=head2 AddSubscriptionFrequency
=over 4
=item C<$frequencyid> = &AddSubscriptionFrequency($frequency);
Add a new frequency
=item C<$frequency> is a hashref that can contains the following keys
=over 2
=item * description
=item * unit
=item * issuesperunit
=item * unitsperissue
=item * expectedissuesayear
=item * displayorder
=back
Only description is mandatory.
=back
=cut
sub AddSubscriptionFrequency {
my $frequency = shift;
unless(ref($frequency) eq 'HASH' && defined $frequency->{'description'} && $frequency->{'description'} ne '') {
return;
}
my @keys;
my @values;
foreach (qw/ description unit issuesperunit unitsperissue expectedissuesayear displayorder /) {
if(exists $frequency->{$_}) {
push @keys, $_;
push @values, $frequency->{$_};
}
}
my $dbh = C4::Context->dbh;
my $query = "INSERT INTO subscription_frequencies";
$query .= '(' . join(',', @keys) . ')';
$query .= ' VALUES (' . ('?,' x (scalar(@keys)-1)) . '?)';
my $sth = $dbh->prepare($query);
my $rv = $sth->execute(@values);
if(defined $rv) {
return $dbh->last_insert_id(undef, undef, "subscription_frequencies", undef);
}
return $rv;
}
=head2 ModSubscriptionFrequency
=over 4
=item &ModSubscriptionFrequency($frequency);
Modifies a frequency
=item C<$frequency> is a hashref that can contains the following keys
=over 2
=item * id
=item * description
=item * unit
=item * issuesperunit
=item * unitsperissue
=item * expectedissuesayear
=item * displayorder
=back
Only id is mandatory.
=back
=cut
sub ModSubscriptionFrequency {
my $frequency = shift;
unless(
ref($frequency) eq 'HASH'
&& defined $frequency->{'id'} && $frequency->{'id'} > 0
&& (
(defined $frequency->{'description'}
&& $frequency->{'description'} ne '')
|| !defined $frequency->{'description'}
)
) {
return;
}
my @keys;
my @values;
foreach (qw/ description unit issuesperunit unitsperissue expectedissuesayear displayorder /) {
if(exists $frequency->{$_}) {
push @keys, $_;
push @values, $frequency->{$_};
}
}
my $dbh = C4::Context->dbh;
my $query = "UPDATE subscription_frequencies";
$query .= ' SET ' . join(' = ?,', @keys) . ' = ?';
$query .= ' WHERE id = ?';
my $sth = $dbh->prepare($query);
return $sth->execute(@values, $frequency->{'id'});
}
=head2 DelSubscriptionFrequency
=over 4
=item &DelSubscriptionFrequency($frequencyid);
Delete a frequency
=back
=cut
sub DelSubscriptionFrequency {
my $frequencyid = shift;
my $dbh = C4::Context->dbh;
my $query = qq{
DELETE FROM subscription_frequencies
WHERE id = ?
};
my $sth = $dbh->prepare($query);
$sth->execute($frequencyid);
}
=head2 GetSubscriptionsWithFrequency
my @subs = GetSubscriptionsWithFrequency($frequencyid);
Returns all subscriptions that are using a particular frequency
=cut
sub GetSubscriptionsWithFrequency {
my ($frequencyid) = @_;
return unless $frequencyid;
my $dbh = C4::Context->dbh;
my $query = qq{
SELECT *
FROM subscription
LEFT JOIN biblio ON subscription.biblionumber = biblio.biblionumber
WHERE periodicity = ?
};
my $sth = $dbh->prepare($query);
my @results;
if ($sth->execute($frequencyid)) {
@results = @{ $sth->fetchall_arrayref({}) };
}
return @results;
}
1;
__END__
=head1 AUTHOR
Koha Development team <info@koha.org>
=cut