Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin
History
Jonathan Druart 39597b86ae Bug 15773: Fix and standardise checkboxes code in framework 
When creating a new subfield for an authority framework, the checkboxes
don't behave as they should.
If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's
label, the checkbox from the second tab will be checked/unchecked.
This is caused by a non-unique id of the input element.

I have found this bug when working on the removal of CGI::checkbox in
both admin/auth_subfields_structure.pl and
admin/marc_subfields_structure.pl scripts.

This patch remove the use of CGI::checkbox as well as the generation of
html code from these 2 pl scripts (which should be avoided).
The code these scripts are now pretty similar.

Test plan:
Add/modify/remove subfield for a MARC framework and an Authority
framework.
Use as many field as possible and confirm that the values are correctly
inserted/displayed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
2016-03-23 01:06:55 +00:00
..
add_user_search.pl Bug 15109: Make name the default sort order for all patron searches 2015-11-17 09:49:21 -03:00
admin-home.pl Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script 2016-02-14 12:40:05 +00:00
aqbudgetperiods.pl Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
aqbudgets.pl Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
aqcontract.pl Bug 14931: (qa followu-up) small improvements 2015-10-29 12:00:42 -03:00
aqplan.pl Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
audio_alerts.pl Bug 11431: (QA followup) Typo in help file / variable name 2015-11-04 12:33:44 -03:00
auth_subfields_structure.pl Bug 15773: Fix and standardise checkboxes code in framework 2016-03-23 01:06:55 +00:00
auth_tag_structure.pl Bug 15381: Remove getauthtypes and getauthtype 2015-12-31 18:59:02 +00:00
authorised_values.pl Bug 10937: cleanup and rename DOCTYPECAT to ITEMTYPECAT 2015-10-22 11:06:22 -03:00
authtypes.pl Bug 16012: Restore the ability to edit default authority type 2016-03-21 22:41:44 +00:00
biblio_framework.pl Bug 14889: Fix error msg on duplicate 2015-12-31 19:04:45 +00:00
branch_transfer_limits.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
branches.pl Bug 16015: Restore the ability to delete a group of libraries 2016-03-21 17:19:44 +00:00
categories.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
check_budget_parent.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
check_parent_total.pl Bug 14383: admin: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
checkmarc.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
cities.pl Bug 14888: Update copyright and wording 2015-10-05 12:00:38 -03:00
classsources.pl Bug 16013: Make classification sources deletable 2016-03-21 22:40:37 +00:00
clone-rules.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
columns_settings.pl Bug 13875: Columns configuration - Allow underscore in table name 2015-04-08 14:51:59 -03:00
columns_settings.yml Bug 14753: Add the "page" parameter in the yml file 2016-03-02 04:18:33 +00:00
currency.pl Bug 15962: Block the currency deletion if used 2016-03-21 22:56:11 +00:00
didyoumean.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
env_tz_test.pl Bug 14383: admin: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
fieldmapping.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
import_export_framework.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
item_circulation_alerts.pl Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used 2016-01-27 20:46:58 +00:00
items_search_field.pl Bug 11425: Add item search form in staff interface 2014-11-04 19:08:12 -03:00
items_search_fields.pl Bug 11425: Add item search form in staff interface 2014-11-04 19:08:12 -03:00
itemtypes.pl Bug 15306: Do not display the translate link if only 1 language is installed 2016-02-23 23:59:20 +00:00
koha2marclinks.pl Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
localization.pl Bug 14100: Generic solution for language overlay - Item types 2015-10-27 12:34:06 -03:00
marc_subfields_structure.pl Bug 15773: Fix and standardise checkboxes code in framework 2016-03-23 01:06:55 +00:00
marctagstructure.pl Bug 1487: Store the "display only used tags/subf" value in a cookie 2015-04-30 15:23:01 -03:00
matching-rules.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
oai_set_mappings.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
oai_sets.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
patron-attr-types.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
preferences.pl Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
printers.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
smart-rules.pl Bug 15755: Display default item type as "All" in circ rules 2016-03-03 22:24:08 +00:00
sms_providers.pl Bug 9021 [QA Followup] - Switch to Koha::Object(s) 2016-02-14 12:40:06 +00:00
sru_modmapping.pl Bug 6536: Add a form for SRU Field mapping 2014-09-01 10:08:50 -03:00
systempreferences.pl Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
transport-cost-matrix.pl Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
z3950servers.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00