Joonas Kylmälä 399b24d537 Bug 28479: Use primary keys to check object existence in TestBuilder ... The TestBuilder::build_object function used any foreign keys to check whether an object already exists or not. This brought incorrectly results of unrelated objects because using any other keys other than primary keys don't guarantee our results to point to one single object. For example, as is put here in the unit test, if you created two items with the same biblionumber and then tried to create a hold using build_object() we were using the biblionumber to check whether an item was linked to the hold already. Thus, we were checking whether a random item was already linked to the hold instead of the one we wanted either by passing it explicitly to build_object() or the one build_object() created implicitly. This also resulted in following warnings when there were more than one match: DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /kohadevbox/koha/t/lib/TestBuilder.pm line 235 To test: $ prove t/db_dependent Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2021-06-21 12:07:28 +02:00
..
Acquisition	Bug 27203: Adjust unit tests	2021-05-11 14:46:10 +02:00
api/v1	Bug 28271: Add the ability to set a new lost status when a claim is resolved	2021-06-21 10:50:09 +02:00
Auth
AuthoritiesMarc	Bug 21958: (QA follow-up) Correct indirect object notation	2021-04-01 17:13:56 +02:00
Authority
Biblio	Bug 25306: Remove framework paramter from ModBiblioMarc	2021-01-12 16:13:50 +01:00
Circulation	Bug 28520: Allow creating a transfer back automatically if a hold is canceled during transit	2021-06-15 16:41:47 +02:00
CourseReserves
Creators
cronjobs
data	Bug 27968: Fix framework import if isurl has an incorrect value	2021-04-23 10:03:30 +02:00
Exporter
Holds	Bug 27069: Adjust tests	2021-04-07 16:08:04 +02:00
Illrequest
Items	Bug 4037: Add item type filter to inventory tool	2021-02-09 09:23:51 +01:00
Koha	Bug 24434: Add Unit Tests for relations	2021-06-15 11:46:13 +02:00
Labels
LDAP
Letters	Bug 26734: (QA follow-up) Unit tests for C4::Letters	2021-04-27 16:23:49 +02:00
Members
misc/translator
OAI	Bug 27584: Refactor OAI-PMH paging to improve performance	2021-05-07 14:44:00 +02:00
Patron	Bug 26937: Add an optional delay to the CheckPrevCheckout syspref.	2021-03-01 15:14:22 +01:00
Record
Reports	Bug 27380: FIX Reports/Guided.t	2021-02-12 14:31:01 +01:00
Reserves	Bug 26634: Remove GetHoldRule subroutine in C4::Reserves	2020-12-21 10:07:38 +01:00
Search
selenium	Bug 28489: Add selenium tests	2021-06-14 17:35:19 +02:00
Serials
SIP	Bug 28320: Add DB connection check to the SIP SC status message	2021-05-17 12:34:33 +02:00
Template/Plugin	Bug 24154: (follow-up) Make parameter and variable more explicit, add tests	2021-05-10 10:27:53 +02:00
Utils	Bug 23271: Replace search_limited with search_with_library_limits	2021-04-21 15:25:07 +02:00
www
00-strict.t
01-test_dbic.t
Accounts.t	Bug 27636: (QA follow-up) Unit tests for AutoReconcile	2021-04-30 17:07:31 +02:00
Acquisition.t	Bug 23971: Rename pref with AcquisitionLog	2021-04-23 11:58:49 +02:00
Amazon.t
ArticleRequests.t
AudioAlerts.t
Auth.t	Bug 21325: Add tests	2021-04-16 14:15:37 +02:00
Auth_with_cas.t	Bug 20854: Add more CAS tests	2021-04-21 10:51:29 +02:00
Auth_with_ldap.t
AuthorisedValues.t	Bug 23830: Make Koha::AuthorisedValues use Koha::Objects::Limit::Library	2021-02-08 17:09:34 +01:00
AuthoritiesMarc.t	Bug 21958: Fix bibliographic record field comparison with authority	2021-04-01 17:13:56 +02:00
AuthUtils.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t	Bug 27577: Unit test	2021-05-06 15:52:38 +02:00
Breeding.t
Budgets.t	Bug 23195: (follow-up) One text invoice should be open	2021-04-22 14:50:11 +02:00
Cache.t
Calendar.t
Charset.t
check_kohastructure.t
check_sysprefs.t
Circulation.t	Bug 24434: Unit tests for updateWrongTransfer	2021-06-15 15:49:16 +02:00
Clubs.t
Context.t
Contract.t
CourseReserves.t
db_structure.t
DecreaseLoanHighHolds.t
Filter_MARC_ViewPolicy.t
Fines.t
FrameworkPlugin.t
Heading.t	Bug 21958: Allow 'e' subfield for authorities	2021-04-06 15:56:30 +02:00
Heading_MARC21.t
Hold.t	Bug 26498: (QA follow-up) Add handling for update	2021-04-07 13:10:31 +02:00
Holds.t	Bug 16787: 'Too many holds' message appears inappropriately and is missing data	2021-04-22 14:37:14 +02:00
HoldsQueue.t	Bug 27069: Adjust tests	2021-04-07 16:08:04 +02:00
Holidays.t
Illcomments.t
Illrequestattributes.t
Illrequests.t
ILSDI_Services.t	Bug 16787: (follow-up) Add and adjust ILSDI tests	2021-04-22 17:31:03 +02:00
ImportBatch.t	Bug 24469: Move the new queries to a dedicated ImportBatch subroutine	2021-02-18 11:52:59 +01:00
ImportExportFramework.t	Bug 27569: Add tests for ODS export	2021-02-16 10:22:13 +01:00
Installer.t	Bug 28281: Add tests	2021-05-07 14:44:00 +02:00
Items.t	Bug 27837: Check the MARC directly, not the transformed item	2021-05-19 15:06:42 +02:00
Koha.t
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t
Koha_ExternalContent_OverDrive.t
Koha_ExternalContent_RecordedBooks.t
Koha_Misc_Files.t
Languages.t
Letters.t	Bug 28108: Fix filtering	2021-05-10 15:52:53 +02:00
LibraryGroups.t
Linker_Default.t
Linker_FirstMatch.t
Log.t
MarcModificationTemplates.t	Bug 26894: Handle subfield 0 and delete empty fields	2021-01-12 16:02:35 +01:00
Members.t	Bug 28001: (bug 27050 follow-up) Fix delete_patrons if no category passed	2021-04-16 12:28:17 +02:00
Message.t	Bug 28230: Regression tests	2021-04-28 11:07:05 +02:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t	Bug 28144: Add a regression test	2021-04-27 16:23:49 +02:00
Passwordrecovery.t
Patroncards.t
PatronLists.t
Patrons.t	Bug 27554: Clarify and add tests for update_category_to	2021-02-01 16:21:25 +01:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reserves.t	Revert "Bug 20985: Unit tests"	2021-06-16 14:44:14 +02:00
rollingloans.t
RotatingCollections.t	Bug 17202: Unit tests	2021-04-28 11:07:06 +02:00
Search.t	Bug 27928: FindDuplicate should use simple_search_compat	2021-04-01 18:03:23 +02:00
Serials.t	Bug 27842: Add tests	2021-04-28 11:07:06 +02:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t
Stats.t
StockRotationItems.t	Bug 22569: Add Unit Tests	2021-03-11 11:51:40 +01:00
StockRotationRotas.t
StockRotationStages.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t
sysprefs.t
TablesSettings.t
Tags.t
Templates.t
TestBuilder.t	Bug 28479: Use primary keys to check object existence in TestBuilder	2021-06-21 12:07:28 +02:00
Upload.t	Bug 28123: Fix expected value in unit test	2021-04-16 12:28:18 +02:00
UsageStats.t	Bug 28108: Fix filtering	2021-05-10 15:52:53 +02:00
Virtualshelves.t
XISBN.t	Bug 28288: Prevent XSISBN.t to fail if service is returning 500	2021-05-04 16:38:27 +02:00
XSLT.t	Bug 23406: Unit test	2021-05-11 15:37:42 +02:00
yaml.t	Bug 22824: Adjust tests to match final behaviours	2021-03-04 16:18:42 +01:00
zebra_config.pl