Koha/C4
Katrin Fischer 39d2885d13 Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted
The numerical restricted value was overwritten in GetItemsInfo
with the description. So OpacHiddenItems would only work for
restricted using the description, not the numerical value
of the authorised value like for other similar status fields.

This changes GetItemsInfo to use a separate variable for
the description, as it's already done for notforloan and
changes the template files where the variable is used
accordingly.

To test
- Before applying patch
- Configure OpacHiddenItems with:
  restricted: [1]
- Find a record with more than one item and mark one of the items
  as "Restricted Access"
  (assume standard sample data - check authorised value if status doesn't exist)
- Verify the item is still shown in OPAC.
- Apply patch
- Verify that the item is now hidden
- Verify that the status still displays nicely in the staff detail page
- Delete OpacHiddenItems
- Verify that the status is showing nicely in the OPAC detail page

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-02-15 18:42:48 +00:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
ClassSplitRoutine Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Creators Bug 15766: Fix incorrect GROUP BY 2018-10-24 17:15:36 +00:00
External Bug 21403: Add Indian Amazon Affiliate option to AmazonLocale setting 2018-10-02 00:03:03 +00:00
Form
Heading Bug 21826: (QA follow-up) Add UNIMARC support 2019-01-25 20:13:39 +00:00
ILSDI Bug 21738: check items count in C4:ILSDI::HoldTitle 2019-02-08 20:44:06 +00:00
Installer Bug 21955: Remove Cache::Memory as fallback for L2 cache 2018-12-11 19:10:46 +00:00
Labels Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Linker
Members Bug 20444: Remove sub GetAttributes 2018-05-03 13:26:49 -03:00
OAI
Output
Patroncards Bug 20084: Fix Industrial2of5 and COOP2of5 patron card layouts 2018-07-12 12:39:34 +00:00
Reports Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Search
Serials
SIP Bug 19832: (QA follow-up) Remove obsolete pending_queue call 2019-02-15 18:42:45 +00:00
Utils Bug 17353: Add phone number column to checkout search 2019-01-28 13:06:35 +00:00
Accounts.pm Bug 19066: Add branchcode to accountlines 2019-01-03 18:58:38 +00:00
Acquisition.pm Bug 21467: Do not erase the internal note of the first order 2018-11-13 19:31:10 +00:00
Auth.pm Bug 21911: Fix OPAC scoping to work with new group system 2018-12-11 19:12:39 +00:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm
Auth_with_ldap.pm Bug 22048: Use set_password in Auth_with_ldap.pm 2019-01-25 20:15:31 +00:00
Auth_with_shibboleth.pm Bug 18507: Shibboleth auto-provisioning - Sync 2018-11-08 20:43:32 +00:00
AuthoritiesMarc.pm Bug 21962: Fix authority search using 'all' 2018-12-11 19:15:39 +00:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 22155: Adapt uses of biblio_metadata.marcflavour to schema 2019-01-30 11:35:34 +00:00
Bookseller.pm
Boolean.pm
Breeding.pm Bug 12747: (QA follow-up) Treat 010 according to marcflavour 2018-10-01 13:56:26 +00:00
Budgets.pm Bug 21604: Fix add/edit fund/budget 2018-11-02 10:33:01 +00:00
Calendar.pm
Charset.pm
Circulation.pm Bug 22049: (QA follow-up) update MarkIssueReturned call in process_koc.pl 2019-01-25 20:46:48 +00:00
ClassSortRoutine.pm
ClassSource.pm Bug 15836: Remove deprecated subroutines 2018-11-13 18:56:18 +00:00
ClassSplitRoutine.pm Bug 15836: Add the ability to defined custom methods to split call number in labels 2018-11-13 15:18:22 +00:00
Context.pm Bug 14302: (follow-up) Remove traces in C4::Search and C4::Context 2018-08-31 11:24:22 +00:00
Contract.pm
CourseReserves.pm Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
Creators.pm
Debug.pm
Heading.pm Bug 21826: Remove strict and warning from Heading.pm 2019-01-25 20:13:41 +00:00
HoldsQueue.pm
HTML5Media.pm Bug 21742: Fix YouTube variable propagation 2018-11-01 18:59:33 +00:00
Images.pm
ImportBatch.pm Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls 2018-08-30 13:40:35 +00:00
ImportExportFramework.pm Bug 21749: Fix import of CSV biblio framework 2018-11-15 12:47:36 +00:00
InstallAuth.pm Bug 21137: Replace USER_INFO with logged_in_user 2018-08-14 12:43:10 +00:00
Installer.pm Bug 21654: Remove refund_lost_item_fee_rules.sql from the installer process 2018-10-26 17:09:59 +00:00
ItemCirculationAlertPreference.pm
Items.pm Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted 2019-02-15 18:42:48 +00:00
Koha.pm Bug 18322: Add a facet for ccode fields to Zebra 2018-07-18 17:42:48 +00:00
Labels.pm
Languages.pm Bug 20115: Set the languages order with the pref values 2018-04-04 15:45:43 -03:00
Letters.pm Bug 21829: Correctly format dateexpiry in notices (date only) 2019-02-11 18:32:40 +00:00
Linker.pm
Log.pm Bug 22003: Remove unused subroutines displaylog and GetLogStatus from C4::Log 2019-01-11 12:20:49 +00:00
MarcModificationTemplates.pm Bug 13560: Add an 'Add' option for marc modification templates 2018-07-19 17:22:18 +00:00
Matcher.pm Bug 19365: Fix several issues with the Elasticsearch code 2018-11-26 16:11:01 +00:00
Members.pm Bug 19920: Removed unnecessary code from C4/Members.pm 2019-01-25 16:11:48 +00:00
Message.pm Bug 19743: Update header and footer on each item for checkin / checkout / renewal notices 2018-08-14 11:55:07 +00:00
NewsChannels.pm
Output.pm Bug 20661: (QA follow-up) Add POD for output_and_exit 2018-08-10 12:23:03 +00:00
Overdues.pm Bug 21753: (QA follow-up) Remove fourth %s in sprintf 2019-01-04 03:14:14 +00:00
Patroncards.pm
Print.pm
Record.pm Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Reports.pm
Reserves.pm Bug 21738: make call of CanBookBeReserved more safe 2019-02-08 20:44:07 +00:00
Ris.pm
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 22140: Use of EasyAnalyticalRecords pref in search 2019-02-15 13:34:57 +00:00
Serials.pm Bug 17047: SQL reports management with Mana-KB 2019-01-23 14:39:26 +00:00
Service.pm
ShelfBrowser.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
SMS.pm
SocialData.pm
Stats.pm Bug 20510: Remove unused sub TotalPaid from C4::Stats 2018-04-05 14:17:36 -03:00
Suggestions.pm Bug 21241: (follow-up) Made SQL change idempotent 2019-01-28 11:42:32 +00:00
Tags.pm
Templates.pm Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere 2018-04-13 11:49:44 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
XISBN.pm Bug 21235: Remove table services_throttle 2018-09-07 15:09:39 +00:00
XSLT.pm