Tomas Cohen Arazi
333ee72600
This patch makes request.pl pass the holding library object to the template, if it is a valid pickup location for the item. This way, the template can set a good default to save clicks. To test: 1. Have "Hold pickup library match" set to "Item's home library" 2. Have a record with items in three different branches. For example: - item1: homebranch: MPL, holdingbranch: MPL - item2: homebranch: FPL, holdingbranch: FPL - item3: homebranch: CPL, holdingbranch: IPT 3. Have FPL marked as 'No' for pickup location 4. On the record, open the page for placing a hold for a patron (acevedo?) => SUCCESS: You are presented the regular hold placing page, with an extra column on the items for pickup location setting => SUCCESS: The item2 (on FPL) cannot be selected, there's a clear message about not having valid pickup locations => FAIL: The other ones don't have anything pre-selected on the dropdowns 5. Apply this patch 6. Repeat 4 (go back to the record, etc) => SUCCESS: Nothing changed BUT the item with holding branch = MPL has it set by default in the dropdown. => SUCCESS: IPT is not a valid pickup location for item3, so not set by default in this case. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
184 lines
6.8 KiB
Perl
Executable file
184 lines
6.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
#script to place reserves/requests
|
|
#written 2/1/00 by chris@katipo.oc.nz
|
|
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Output;
|
|
use C4::Reserves;
|
|
use C4::Circulation;
|
|
use C4::Members;
|
|
use C4::Auth qw/checkauth/;
|
|
|
|
use Koha::Items;
|
|
use Koha::Patrons;
|
|
|
|
my $input = CGI->new();
|
|
|
|
checkauth($input, 0, { reserveforothers => 'place_holds' }, 'intranet');
|
|
|
|
my @bibitems = $input->multi_param('biblioitem');
|
|
my @reqbib = $input->multi_param('reqbib');
|
|
my $biblionumber = $input->param('biblionumber');
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
my $notes = $input->param('notes');
|
|
my $branch = $input->param('pickup');
|
|
my $startdate = $input->param('reserve_date') || '';
|
|
my @rank = $input->multi_param('rank-request');
|
|
my $type = $input->param('type');
|
|
my $title = $input->param('title');
|
|
my $checkitem = $input->param('checkitem');
|
|
my $expirationdate = $input->param('expiration_date');
|
|
my $itemtype = $input->param('itemtype') || undef;
|
|
my $non_priority = $input->param('non_priority');
|
|
|
|
my $borrower = Koha::Patrons->find( $borrowernumber );
|
|
$borrower = $borrower->unblessed if $borrower;
|
|
|
|
my $biblionumbers = $input->param('biblionumbers');
|
|
$biblionumbers ||= $biblionumber . '/';
|
|
|
|
my $bad_bibs = $input->param('bad_bibs');
|
|
my $holds_to_place_count = $input->param('holds_to_place_count') || 1;
|
|
|
|
my %bibinfos = ();
|
|
my @biblionumbers = split '/', $biblionumbers;
|
|
foreach my $bibnum (@biblionumbers) {
|
|
my %bibinfo = ();
|
|
$bibinfo{title} = $input->param("title_$bibnum");
|
|
$bibinfo{rank} = $input->param("rank_$bibnum");
|
|
$bibinfo{pickup} = $input->param("pickup_$bibnum");
|
|
$bibinfos{$bibnum} = \%bibinfo;
|
|
}
|
|
|
|
my $found;
|
|
|
|
if ( $type eq 'str8' && $borrower ) {
|
|
|
|
foreach my $biblionumber ( keys %bibinfos ) {
|
|
my $count = @bibitems;
|
|
@bibitems = sort @bibitems;
|
|
my $i2 = 1;
|
|
my @realbi;
|
|
$realbi[0] = $bibitems[0];
|
|
for ( my $i = 1 ; $i < $count ; $i++ ) {
|
|
my $i3 = $i2 - 1;
|
|
if ( $realbi[$i3] ne $bibitems[$i] ) {
|
|
$realbi[$i2] = $bibitems[$i];
|
|
$i2++;
|
|
}
|
|
}
|
|
|
|
my $can_override = C4::Context->preference('AllowHoldPolicyOverride');
|
|
if ( defined $checkitem && $checkitem ne '' ) {
|
|
|
|
my $item_pickup_location = $input->param("item_pickup_$checkitem");
|
|
|
|
my $item = Koha::Items->find($checkitem);
|
|
|
|
if ( $item->biblionumber ne $biblionumber ) {
|
|
$biblionumber = $item->biblionumber;
|
|
}
|
|
|
|
my $can_item_be_reserved = CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $item_pickup_location)->{status};
|
|
|
|
if ( $can_item_be_reserved eq 'OK' || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) ) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $item_pickup_location,
|
|
borrowernumber => $borrower->{'borrowernumber'},
|
|
biblionumber => $biblionumber,
|
|
priority => $rank[0],
|
|
reservation_date => $startdate,
|
|
expiration_date => $expirationdate,
|
|
notes => $notes,
|
|
title => $title,
|
|
itemnumber => $checkitem,
|
|
found => $found,
|
|
itemtype => $itemtype,
|
|
non_priority => $non_priority,
|
|
}
|
|
);
|
|
|
|
}
|
|
|
|
} elsif (@biblionumbers > 1) {
|
|
my $bibinfo = $bibinfos{$biblionumber};
|
|
if ( $can_override || CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $bibinfo->{pickup},
|
|
borrowernumber => $borrower->{'borrowernumber'},
|
|
biblionumber => $biblionumber,
|
|
priority => $bibinfo->{rank},
|
|
reservation_date => $startdate,
|
|
expiration_date => $expirationdate,
|
|
notes => $notes,
|
|
title => $bibinfo->{title},
|
|
itemnumber => $checkitem,
|
|
found => $found,
|
|
itemtype => $itemtype,
|
|
non_priority => $non_priority,
|
|
}
|
|
);
|
|
}
|
|
} else {
|
|
# place a request on 1st available
|
|
for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) {
|
|
if ( $can_override || CanBookBeReserved($borrower->{'borrowernumber'}, $biblionumber)->{status} eq 'OK' ) {
|
|
AddReserve(
|
|
{
|
|
branchcode => $branch,
|
|
borrowernumber => $borrower->{'borrowernumber'},
|
|
biblionumber => $biblionumber,
|
|
priority => $rank[0],
|
|
reservation_date => $startdate,
|
|
expiration_date => $expirationdate,
|
|
notes => $notes,
|
|
title => $title,
|
|
itemnumber => $checkitem,
|
|
found => $found,
|
|
itemtype => $itemtype,
|
|
non_priority => $non_priority,
|
|
}
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($bad_bibs) {
|
|
$biblionumbers .= $bad_bibs;
|
|
}
|
|
print $input->redirect("request.pl?biblionumbers=$biblionumbers");
|
|
}
|
|
elsif ( $borrowernumber eq '' ) {
|
|
print $input->header();
|
|
print "Invalid borrower number please try again";
|
|
|
|
# Not sure that Dump() does HTML escaping. Use firebug or something to trace
|
|
# instead.
|
|
#print $input->Dump;
|
|
}
|