Jonathan Druart
3bb1578354
This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
||
---|---|---|
.. | ||
preferences | ||
admin-home.tt | ||
aqbudgetperiods.tt | ||
aqbudgets.tt | ||
aqcontract.tt | ||
aqplan.tt | ||
audio_alerts.tt | ||
auth_subfields_structure.tt | ||
auth_tag_structure.tt | ||
authorised_values.tt | ||
authtypes.tt | ||
biblio_framework.tt | ||
branch_transfer_limits.tt | ||
branches.tt | ||
categories.tt | ||
checkmarc.tt | ||
cities.tt | ||
classsources.tt | ||
clone-rules.tt | ||
columns_settings.tt | ||
currency.tt | ||
didyoumean.tt | ||
edi_accounts.tt | ||
edi_ean_accounts.tt | ||
fieldmapping.tt | ||
item_circulation_alerts.tt | ||
items_search_field.tt | ||
items_search_fields.tt | ||
itemtypes.tt | ||
koha2marclinks.tt | ||
localization.tt | ||
marc_subfields_structure.tt | ||
marctagstructure.tt | ||
matching-rules.tt | ||
oai_set_mappings.tt | ||
oai_sets.tt | ||
patron-attr-types.tt | ||
preferences.tt | ||
printers.tt | ||
smart-rules.tt | ||
sms_providers.tt | ||
sru_modmapping.tt | ||
systempreferences.tt | ||
transport-cost-matrix.tt | ||
z3950servers.tt |