Koha/debian/scripts/koha-enable
Tomas Cohen Arazi 3bca90eb0c Bug 10101 - make koha-enable more robust
koha-enable now:

- checks for the existence of the instance before any other action on it.
- checks if the instance is already enabled before changing stuff in the config files.
- only reloads apache if it is needed!
- handles more than one instance name as parameter (the code was there, a check for the cardinality of the args prevented it from working).
- documents this behaviour change in the docs
- doesn't break if the provided (invalid) instance name is a prefix/suffix of a real one (added -x to the relevant grep command).

To test:
- Aplpy the patch, build your packages
- Run koha-enable on
  - Non existent instance (try using a prefix or a suffix of an already created one too).
  - Already enabled existent instance name.
  - Disabled instance.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-05-01 22:00:13 -04:00

97 lines
2 KiB
Bash
Executable file

#!/bin/sh
#
# koha-enable -- enable a Koha instance.
# Copyright 2010 Catalyst IT, Ltd
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
set -e
die()
{
echo "$@" 1>&2
exit 1
}
warn()
{
echo "$@" 1>&2
}
is_enabled()
{
local instancename=$1
if ! is_instance $instancename; then
return 1
fi
if grep -q '^[[:space:]]*Include /etc/koha/apache-shared-disable.conf' \
"/etc/apache2/sites-available/$instancename" ; then
return 1
else
return 0
fi
}
is_instance()
{
local instancename=$1
if find /etc/koha/sites -mindepth 1 -maxdepth 1 \
-type d -printf '%f\n'\
| grep -q -x $instancename ; then
return 0
else
return 1
fi
}
enable_instance()
{
local instancename=$1
if ! is_enabled $instancename; then
sed -i 's:^\(\s*Include /etc/koha/apache-shared-disable.conf\)$:#\1:' \
"/etc/apache2/sites-available/$instancename"
return 0
else
return 1
fi
}
# Parse command line.
[ "$#" > 1 ] || die "Usage: $0 instancename..."
restart_apache="no"
for name in "$@"
do
if is_instance $name ; then
if enable_instance $name; then
restart_apache="yes"
else
warn "Instance $name already enabled."
fi
else
warn "Unknown instance $name."
fi
done
if [ "$restart_apache" = "yes" ]; then
/etc/init.d/apache2 restart
fi
exit 0