Owen Leonard
679fdaebb1
This patch makes many changes to templates and JavaScript related to the integration of Mana with serials reports: - Many incorrect uses of the raw filter with html - Corrections to Bootstrap modal markup - Untranslatable strings moved out of JavaScript - Removed markup and JavaScript related to reports comments, a feature which doesn't exist in this version. New include file: mana/mana-comment-status.inc This file contains hidden-by-default messages which are shown during the process of submitting a comment on a subscription. New include file: mana/mana-share-report.inc This file contains the "Share report" modal markup formerly in guided_reports_start.tt New JavaScript file: mana.js Previously mana.inc, an include file containing only JavaScript which didn't include any template processing. Changed: mana/mana-report-search-result.inc This include file is now a full template so that jQuery's load() function can be used to pull its contents into the reports search modal. Changed: svc/mana/search This script was returning json-encoded HTML. Now it returns regular HTML. To test you must have Mana configured and enabled. Apply the patch and go to Reports -> Saved reports. - Choose New report -> New SQL from Mana. A "Mana search" modal should appear. - Perform a search which will return results, e.g. "circulation." - A "Loading" indicator should appear while the results are being retrieved. It should disappear when results appear. - Results should appear in the DataTable with sorting, paging, and search options. - In the "Notes" column, notes longer than 200 characters should be truncated with a "Show more" link. Clicking it should expand the comment and reveal a "Show less" link in its place. - Click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - When the import is complete you should be redirected to a view of your new report. Go to Serials and click the "Search on Mana" link in the sidebar. - Perform a search for a serial - Results should appear in a DataTable with sorting, paging, and search options. - Sorting by title should ignore articles "a," "an," and "the." Create a new subscription or edit an existing subscription which will match a record in Mana. - On the second step of adding/editing the subscription a message should appear at the top of the form, "Searching for subscription in Mana Knowledge Base," with a loading icon. - When searching has completed a "Show Mana results" link should appear. - Clicking the link should trigger a modal showing search results which match your subscription, displayed in a DataTable with sorting, paging, and search options. - The last column of the table should contain "Import" and "Report" buttons. - Clicking the "Report" button should trigger a menu. Any existing comments will be listed as well as a "New comment" item. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should redisplay the search results. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. - In the table of search results, click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - The modal should close and the data from Mana should be loaded into the subscription entry form. View the detail page of a subscription which has saved with Mana data. - There should be a "Report mistake" button in the toolbar. Clicking it should reveal a menu of comments like the one you saw previously. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form modal. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should hide the modal. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> |
||
---|---|---|
.. | ||
catalogue | ||
csv_headers | ||
mana | ||
modals | ||
str | ||
virtualshelves/merge | ||
accounts.inc | ||
acquisitions-add-to-basket.inc | ||
acquisitions-menu.inc | ||
acquisitions-search.inc | ||
acquisitions-toolbar.inc | ||
additem.js.inc | ||
additional-fields-display.inc | ||
additional-fields-entry.inc | ||
admin-items-search-field-form.inc | ||
admin-menu.inc | ||
adv-search.inc | ||
auth-finder-search.inc | ||
authorities-search-results.inc | ||
authorities-search.inc | ||
authorities-toolbar.inc | ||
authorities.inc | ||
authorities_js.inc | ||
av-build-dropbox.inc | ||
biblio-default-view.inc | ||
biblio-view-menu.inc | ||
blocked-fines.inc | ||
blocking_errors.inc | ||
borrower_debarments.inc | ||
branch-selector.inc | ||
browser-strings.inc | ||
budgets-active-currency.inc | ||
budgets-admin-search.inc | ||
budgets-admin-toolbar.inc | ||
calendar.inc | ||
cat-menu.inc | ||
cat-search.inc | ||
cat-toolbar.inc | ||
catalog-strings.inc | ||
cataloging-search.inc | ||
cateditor-ui.inc | ||
cateditor-widgets-marc21.inc | ||
chart.inc | ||
checkin-search.inc | ||
checkouts-table-footer.inc | ||
checkouts-table.inc | ||
circ-menu.inc | ||
circ-nav.inc | ||
circ-patron-search-results.inc | ||
circ-search.inc | ||
cities-admin-search.inc | ||
columns_settings.inc | ||
contracts-admin-search.inc | ||
country-list.inc | ||
currencies-admin-search.inc | ||
datatables.inc | ||
date-format.inc | ||
delimiter_text.inc | ||
doc-head-close-receipt.inc | ||
doc-head-close.inc | ||
doc-head-open.inc | ||
empty_line.inc | ||
facets.inc | ||
filter-orders.inc | ||
form-blocks.inc | ||
format_price.inc | ||
greybox.inc | ||
guided-reports-view.inc | ||
header.inc | ||
holds_table.inc | ||
home-search.inc | ||
html_helpers.inc | ||
i18n.inc | ||
ill-list-table-strings.inc | ||
ill-list-table.inc | ||
ill-toolbar.inc | ||
installer-doc-head-close.inc | ||
installer-intranet-bottom.inc | ||
installer-strings.inc | ||
intranet-bottom.inc | ||
intranetstylesheet.inc | ||
js_includes.inc | ||
labels-toolbar.inc | ||
langmenu-staff-top.inc | ||
last-borrower.inc | ||
letters-search.inc | ||
member-alt-address-style-de.inc | ||
member-alt-address-style-fr.inc | ||
member-alt-address-style-us.inc | ||
member-alt-contact-style-de.inc | ||
member-alt-contact-style-fr.inc | ||
member-alt-contact-style-us.inc | ||
member-display-address-style-de.inc | ||
member-display-address-style-fr.inc | ||
member-display-address-style-us.inc | ||
member-display-alt-address-style-de.inc | ||
member-display-alt-address-style-fr.inc | ||
member-display-alt-address-style-us.inc | ||
member-main-address-style-de.inc | ||
member-main-address-style-fr.inc | ||
member-main-address-style-us.inc | ||
members-toolbar.inc | ||
merge-record-strings.inc | ||
merge-record.inc | ||
messaging-preference-form.inc | ||
noadd-warnings.inc | ||
onboarding_messages.inc | ||
page-numbers.inc | ||
password_check.inc | ||
patron-article-requests.inc | ||
patron-search-box.inc | ||
patron-search.inc | ||
patron-title.inc | ||
patron-toolbar.inc | ||
patroncards-errors.inc | ||
patroncards-toolbar.inc | ||
patrons-admin-search.inc | ||
permissions.inc | ||
popup-bottom.inc | ||
prefs-admin-search.inc | ||
prefs-menu.inc | ||
quotes-toolbar.inc | ||
quotes-upload-toolbar.inc | ||
reports-menu.inc | ||
reports-toolbar.inc | ||
resort_form.inc | ||
rotating-collections-toolbar.inc | ||
search_indexes.inc | ||
select2.inc | ||
serials-menu.inc | ||
serials-search.inc | ||
serials-toolbar.inc | ||
slip-print.inc | ||
stockrotation-toolbar.inc | ||
strings.inc | ||
subscriptions-search.inc | ||
subtypes_unimarc.inc | ||
suggestions-add-search.inc | ||
timepicker.inc | ||
tools-item-action.inc | ||
tools-menu.inc | ||
tools-nomatch-action.inc | ||
tools-overlay-action.inc | ||
validator-strings.inc | ||
vendor-menu.inc | ||
virtualshelves-toolbar.inc | ||
waiting_holds.inc | ||
wysiwyg-systempreferences.inc | ||
xslt-handler.inc | ||
z3950-admin-search.inc | ||
z3950_search.inc |