Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin
History
Tomas Cohen Arazi 084d64b84a Bug 27250: Fix stacked event listeners in SMTP delete modal 
There is a design issue on the click event listener that makes the modal
get added new event listeners on each row being deleted. This makes the
page call all the event listeners and generates an error.

This patch replaces the flawed logic (adding the event listener inside
the event listener). It makes the event listener be defined at startup
time, and make the .on('click') action just pass information around as
required.

To test:
1. Create at least 2 SMTP servers
2. Open the browser inspector, on the network tab
3. Click "Delete" for server 1
=> SUCCESS: You get a successful message (OK)
4. Click "Delete" for server 2
=> SUCCESS: You get a successful message (OK)
=> FAIL: You get also an alert message about server 1 (KO)
=> FAIL: The inspector shows more than one AJAX call has been made
5. Apply this patch and reload the page
6. Repeat 3-4
=> SUCCESS: Everything goes smooth this time
7. Sign off :-D

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-12-26 18:14:11 +01:00
..
preferences Bug 27044: Mark the PayPal integration as deprecated on the user interface 2020-11-24 21:27:59 +01:00
searchengine/elasticsearch Bug 19482: (follow-up) Fix update, add tests, restore closing </td> 2020-11-04 12:59:33 +01:00
additional-fields.tt Bug 23013: Upgrade DataTables in the staff client 2019-08-22 15:23:19 +01:00
admin-home.tt Bug 26809: Removes full stops from admin-home.tt 2020-10-26 00:16:14 +01:00
adveditorshortcuts.tt Bug 21411: (follow-up) Clean up for QA 2019-05-10 18:59:39 +00:00
aqbudgetperiods.tt Bug 24012: (QA follow-up) Use standard patterns 2020-11-04 12:59:32 +01:00
aqbudgets.tt Bug 26217: Move translatable strings out of templates into acq.js 2020-09-29 14:28:18 +02:00
aqcontract.tt Bug 25744: Replace <i> with <em> in staff interface 2020-09-18 11:08:35 +02:00
aqplan.tt Bug 26496: Add op field to Budget Planning 2020-10-22 09:46:43 +02:00
audio_alerts.tt Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js 2020-09-29 14:28:18 +02:00
auth_subfields_structure.tt Bug 25744: Replace <i> with <em> in staff interface 2020-09-18 11:08:35 +02:00
auth_tag_structure.tt Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
authorised_values.tt Bug 25534: (QA follow-up) Add AV category 2020-08-25 15:07:28 +02:00
authtypes.tt Bug 25282: Correct Bootstrap dropdown button markup 2020-04-29 16:20:08 +01:00
background_jobs.tt Bug 22417: Remove list of pending jobs 2020-10-05 15:26:36 +02:00
biblio_framework.tt Bug 26551: Correct modal markup to prevent long heading from overflowing 2020-10-08 11:36:32 +02:00
branch_transfer_limits.tt Bug 26768: Remove the use of jquery.checkboxes plugin from library transfer limits page 2020-11-03 10:57:35 +01:00
branches.tt Bug 22818: (QA follow-up) Add hint to new library ILL email setting 2020-11-11 08:35:10 +01:00
cash_registers.tt Bug 26946: Set maxlength for cash register name 2020-12-09 11:23:43 +01:00
categories.tt Bug 22818: (follow-up) Respond to feedback 2020-11-11 08:35:10 +01:00
checkmarc.tt Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
cities.tt Bug 25279: (QA follow-up) Use .escapeHtml 2020-05-12 11:40:22 +01:00
classsources.tt
clone-rules.tt
columns_settings.tt Bug 26160: Make POS items table configurable 2020-08-12 12:07:12 +02:00
credit_types.tt Bug 19036: Add ability to enable credit number for only some credit types 2020-08-20 12:31:59 +02:00
currency.tt Bug 26234: Teach our KohaTable constructor the specific th classes 2020-08-19 08:24:04 +02:00
debit_types.tt Bug 23354: (follow-up) Make display of debit types configurable 2020-01-13 14:05:14 +00:00
desks.tt Bug 13881: (QA follow-up) Some documentation and terminology fixes 2020-03-25 09:20:00 +00:00
didyoumean.tt Bug 20399: (QA follow-up) Remove mention of INTRAdidyoumean from text and delete commented code 2020-03-26 11:55:46 +00:00
edi_accounts.tt Bug 26908: (follow-up) Alter template check 2020-11-05 15:24:20 +01:00
edi_ean_accounts.tt
item_circulation_alerts.tt
items_search_field.tt
items_search_fields.tt Bug 26230: Move translatable strings out of item_search_fields.tt and into item_search_fields.js 2020-09-29 14:28:18 +02:00
itemtypes.tt Bug 25744: replace <b> with <strong> in the staff interface 2020-09-18 11:08:35 +02:00
koha2marclinks.tt Bug 26007: Add/fix warning for changes to the Koha to MARC mappings 2020-09-09 15:39:51 +02:00
library_groups.tt Bug 22937: Add hint to groups editor 2020-04-08 11:52:25 +01:00
localization.tt Bug 23351: Clean up localization template 2019-10-02 13:53:28 +01:00
marc_subfields_structure.tt Bug 26456: (follow-up) Add markup comments 2020-10-14 14:50:06 +02:00
marctagstructure.tt Bug 25282: Correct Bootstrap dropdown button markup 2020-04-29 16:20:08 +01:00
matching-rules.tt Bug 24899: (follow-up) Add markup comments 2020-10-14 14:50:07 +02:00
oai_set_mappings.tt Bug 21520: QA Follow-up: do not build html tags with TT conditions 2020-01-15 13:50:09 +00:00
oai_sets.tt Bug 25282: Correct Bootstrap dropdown button markup 2020-04-29 16:20:08 +01:00
overdrive.tt Bug 23013: Upgrade DataTables in the staff client 2019-08-22 15:23:19 +01:00
patron-attr-types.tt Bug 26973: (bug 26119 follow-up) Restore patron's attributes during self-registration 2020-11-17 11:51:28 +01:00
preferences.tt Bug 23823: (QA follow-up) Fix filter in link 2020-11-04 17:32:35 +01:00
share_content.tt Bug 23075: Correct indendation 2019-11-06 17:05:34 +00:00
smart-rules.tt Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" 2020-12-26 18:14:11 +01:00
sms_providers.tt Bug 26240: Move translatable strings out of sms_providers.tt and into sms_providers.js 2020-09-29 14:28:18 +02:00
smtp_servers.tt Bug 27250: Fix stacked event listeners in SMTP delete modal 2020-12-26 18:14:11 +01:00
sru_modmapping.tt
sru_modmapping_auth.tt
systempreferences.tt Bug 21574: Local use system preferences page doesn't have the system preferences menu 2019-11-26 11:43:57 +00:00
transport-cost-matrix.tt Bug 26726: (QA follow-up) Add line break and 'the' for readability 2020-10-26 00:16:14 +01:00
usage_statistics.tt Bug 23866: Prompt for HEA configuration 2019-10-31 11:35:52 +00:00
z3950servers.tt Bug 25282: Correct Bootstrap dropdown button markup 2020-04-29 16:20:08 +01:00