Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Kyle M Hall 3c9d50d134 Bug 12803 - Add ability to skip closed libraries when generating the holds queue 
The holds queue is typically generated many times a day in order to
select items to fill holds. Often these items are to be sent to a
different library. However, if the library whose item is picked to fill
a hold is closed, that hold will remain unfilled even if there are other
open libraries who own that item. It would be helpful if we could skip
closed libraries for the purpose of selecting items to fill holds.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a record with two items on it, one at Branch A, and one at
   Branch B
4) Place a hold for pickup at Branch C
5) Generate the holds queue
6) Note which branch's item is selected for the hold
7) Enable the new system preference HoldsQueueSkipClosed
8) Add today as a holiday for that branch noted in step 6
9) Regenerate the holds queue
10) View the holds queue, notice the item selected is not from
    the closed branch!
11) prove t/db_dependent/HoldsQueue.t

Signed-off by: Jason Robb <jrobb@sekls.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
2016-03-03 20:19:00 +00:00
..
Acquisition Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
api/v1 Bug 13799: Rename t/.../v1/borrowers.t to t/.../v1/patrons.t 2015-11-04 13:47:33 -03:00
Auth Bug 15756: Some tests for haspermission in C4::Auth 2016-02-23 20:54:42 +00:00
Biblio Bug 15572: Add tests for TransformHtmlToMarc 2016-01-25 07:09:50 -07:00
Circulation Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Creators Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
data
Exporter Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Holds Bug 14878: (QA followup) Remove useless diag 2015-11-06 15:51:52 -03:00
Items Bug 11023: Automatic item modification by age (Was Toggle "new" status") 2016-03-02 22:56:31 +00:00
Koha Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) 2016-02-24 03:55:05 +00:00
Labels Bug 14468: (QA followup) remove useless diags 2015-10-27 10:38:15 -03:00
LDAP
Letters
Members Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
OAI Bug 14939: Remove the Capture::Tiny dependency 2015-12-31 15:15:35 +00:00
Record Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
Reports
Reserves Bug 13592: Add an option to charge for any hold placed 2015-12-31 15:59:05 +00:00
Search Bug 10933: (followup of the followup) fix the previous patch to work with master 2015-10-27 13:06:01 -03:00
Serials Bug 15168: (followup) remove useless diags 2015-11-17 15:47:46 -03:00
Template/Plugin Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Utils Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
www Bug 10363: (QA followups) Fix tests 2015-10-21 17:23:38 -03:00
XSLT_Handler
00-strict.t
Accounts.t Bug 14402: (QA followup) Add notes to usage text about --fees 2015-11-09 15:00:02 -03:00
Acquisition.t
AdditionalField.t
Amazon.t
AudioAlerts.t Bug 11431: (QA followup) remove diags 2015-11-06 15:08:37 -03:00
Auth.t Bug 15288: (QA followup) Tests still point to old 500.tt file 2016-03-02 23:13:35 +00:00
Auth_with_cas.t
Auth_with_ldap.t
AuthorisedValues.t
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t Bug 15081: (QA followup) Fix issue with Barcodes_ValueBuilder.t 2015-11-04 12:32:57 -03:00
Biblio.t Bug 7683: Cataloguing statistics wizard improvements 2016-01-27 06:37:27 +00:00
BiblioObject.t Bug 15586 - References to Koha::Branches remain in unit tests 2016-01-19 12:32:39 +00:00
Bookseller.t
Borrower.t Bug 14778: Make 3 tests pass 2015-10-23 12:01:17 -03:00
Borrower_Debarments.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Borrower_Discharge.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Borrower_Files.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Borrowers.t
Branch.t Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories 2016-02-24 03:55:07 +00:00
Breeding.t
Budgets.t Bug 15004: Ensure that the reset_all_budgets behavior is kept 2016-01-27 06:05:02 +00:00
Category.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Charset.t
check_sysprefs.t
Circulation.t Bug 15675 - Add issue_id column to accountlines and use it for updating fines 2016-03-02 03:24:45 +00:00
Circulation_Branch.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_dateexpiry.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Circulation_issue.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_Issuingrule.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_issuingrules.t Bug 14778: Use mock_dbh where it should be used 2015-10-23 12:01:18 -03:00
Circulation_OfflineOperation.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Circulation_transfers.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
ClassSource.t
ColumnsSettings.t
Context.t Bug 15446: Add tests 2016-02-12 12:35:56 -07:00
Contract.t
CourseReserves.t Bug 15530 - Add Unit Test 2016-01-27 00:58:14 +00:00
Csv.t
db_structure.t Bug 15517: Change wording for tests 2016-02-23 23:08:20 +00:00
default_search_class.pl
External_BakerTaylor.t
Fines.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t
Hold.t Bug 14310 [QA Followup] - Adapt existing code to use new methods 2016-01-27 06:20:19 +00:00
Holds.t Bug 14310 [QA Followup] - Adapt existing code to use new methods 2016-01-27 06:20:19 +00:00
HoldsQueue.t Bug 12803 - Add ability to skip closed libraries when generating the holds queue 2016-03-03 20:19:00 +00:00
Holidays.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
ILSDI_Services.t Bug 15629: Koha::Libraries - Remove GetBranchDetail 2016-02-24 03:55:06 +00:00
ImportBatch.t
Installer.t
Items.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Items_DelItem.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 4941: Make tests non DB dependent 2016-02-26 12:13:04 +00:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_borrower_modifications.t
Koha_Database.t
Koha_Misc_Files.t
Koha_template_plugin_Branches.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Koha_template_plugin_KohaDates.t Bug 14977: Remove C4::Dates from files t/db_dependent/*.t 2015-10-29 11:58:44 -03:00
Languages.t
Letters.t Bug 12426: Simplify the code adding a new subroutine GetMessage 2016-03-03 20:16:07 +00:00
Linker_FirstMatch.t
Log.t Bug 15939: Action logs - Do not default dates to today 2016-03-02 00:53:14 +00:00
MarcModificationTemplates.t
Members.t Bug 15343 [QA Followup] 2016-02-24 04:04:05 +00:00
Members_Attributes.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Members_columns.t
MungeMarcPrice.t
NewsChannels.t Bug 14977: Followup to fix issue with NewsChannels.t 2015-10-29 11:58:52 -03:00
Overdues.t Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 2015-12-31 12:47:16 +00:00
Passwordrecovery.t Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t 2016-01-27 06:40:54 +00:00
PatronLists.t
Plugins.t
QueryParser.t
Ratings.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Record.t Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Reports.t
Reports_Guided.t Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data 2015-11-16 15:55:22 -03:00
ReportsGuided.t Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory 2016-03-02 03:54:16 +00:00
Reserves.t Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration 2015-12-11 16:08:50 +00:00
Review.t Bug 15199: t/db_dependent/Review.t should not depend on existing data 2015-11-17 23:45:25 -03:00
rollingloans.t
RotatingCollections.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Search.t Bug 9819: Make the tests pass 2015-12-30 15:50:15 +00:00
Serials.t Bug 15168: Remove C4:Serials::ItemizeSerials 2015-11-17 15:34:00 -03:00
Serials_2.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Service.t
ShelfBrowser.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
SIP_ILS.t
SIPILS.t Bug 15947: move SIPILS.t to DB-dependent test directory 2016-03-02 22:02:10 +00:00
Sitemapper.t Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t 2015-10-23 12:01:18 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
sysprefs.t
Tags.t
Templates.t
TestBuilder.t Bug 15601: Fix TestBuilder tests 2016-01-23 19:01:41 +00:00
Upload.t Bug 14893: Separate temporary storage per instance in Upload.pm 2016-01-29 01:17:55 +00:00
UsageStats.t Bug 14097: Fixed missing test cases 2016-02-24 03:04:36 +00:00
Virtualshelves.t Bug 14544: [QA Follow-up] Added some test descriptions 2015-11-05 10:00:31 -03:00
XISBN.t
XSLT_Handler.t
zebra_config.pl Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection 2015-10-29 14:10:23 -03:00