Koha/admin
Jonathan Druart 9215ca42d2
Bug 22786: Prevent fund creation for locked budgets
If a budget is locked, there is a "New fund for $budget" link that is
disabled but clickable.
We should ensure that the link is not clickable and prevent it at
controller level (do we need it at module level, ie.
Koha::Acquisition::Fund->store?)

Test plan:
- Create a budget, lock it
- Go to /cgi-bin/koha/admin/aqbudgetperiods.pl
- Click on the name of the budget you just created
=> The "New > New fund for $budget_name" button should be disabled
- Click it anyway
=> Without this patch the form to add a new fund is displayed
=> With this patch applied nothing happens
- Hit /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=XXX
With XXX the budget's id
=> Without this patch the form is displayed
=> With this patch applied you get a message:
  "The budget is locked, fund creation is not possible."
And you are not able to create a new fund

QA notes:
1. See description
2. The add_validate op can still be forced, let trust librarians with
administration permissions for now.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2019-09-06 13:17:47 +01:00
..
searchengine/elasticsearch Bug 22258: Increase Elasticsearch maximum field count to 10000 2019-09-06 12:53:57 +01:00
add_user_search.pl
additional-fields.pl Bug 15774: (QA follow-up) Fix use statemenets 2019-03-07 20:37:06 +00:00
admin-home.pl
adveditorshortcuts.pl Bug 21411: Address QA concerns 2019-05-10 18:59:39 +00:00
aqbudgetperiods.pl Bug 10577: (QA follow-up) Remove bad call signature 2019-03-28 12:46:14 +00:00
aqbudgets.pl Bug 22786: Prevent fund creation for locked budgets 2019-09-06 13:17:47 +01:00
aqcontract.pl
aqplan.pl
audio_alerts.pl
auth_subfields_structure.pl
auth_tag_structure.pl
authorised_values.pl
authtypes.pl
biblio_framework.pl
branch_transfer_limits.pl
branches.pl
categories.pl Bug 10796: Handle can_change_password on the staff interface 2019-04-12 02:32:07 +00:00
check_budget_parent.pl
check_parent_total.pl
checkmarc.pl
cities.pl
classsources.pl
clone-rules.pl
columns_settings.pl
columns_settings.yml Bug 23307: Add columns configuration to cataloguing/z3950_search.tt 2019-08-08 16:08:36 +01:00
currency.pl
didyoumean.pl
edi_accounts.pl
edi_ean_accounts.pl
import_export_framework.pl
item_circulation_alerts.pl
items_search_field.pl
items_search_fields.pl
itemtypes.pl Bug 22575: Item type administration uses invalid error class for dialog 2019-03-23 09:03:41 +00:00
koha2marclinks.pl
library_groups.pl
localization.pl
marc_subfields_structure.pl Bug 23309: Use Koha::MarcSubfieldStructures to create to subfields 2019-08-15 09:07:38 +01:00
marctagstructure.pl
matching-rules.pl
oai_set_mappings.pl
oai_sets.pl
overdrive.pl
patron-attr-types.pl
preferences.pl Bug 21582: Use CodeMirror for *UserJS & *UserCSS 2019-04-12 02:28:17 +00:00
printers.pl
share_content.pl Bug 23034: (RM follow-up) Consistent coding style 2019-06-24 14:49:24 +01:00
smart-rules.pl Bug 18930: (follow-up) Amend Koha::RefundLostItemFeeRules->find 2019-07-15 11:28:00 +01:00
sms_providers.pl
sru_modmapping.pl
systempreferences.pl
transport-cost-matrix.pl
usage_statistics.pl
z3950servers.pl Bug 23242: Fix insert of Z3950 servers with strict SQL modes 2019-08-16 11:39:24 +01:00