a529262501
Adds a new placeholder {ISSN} to the system preference SearchForTitleIn.
For a record with multiple ISSNs only the first ISSN will be used.
Addition: Makes a small change to GetMarcControlnumber so that it checks for
NORMARC too. If you set your system preference to NORMARC, it should output
{CONTROLNUMBER} correctly now.
For testing add following code to the system preference and check output
of SearchForTitleIn for different records in your OPAC and all 3 available
views (normal, MARC and ISBD):
<li>ISSN: {ISSN}</li>
<li>ISBN: {ISBN}</li>
<li>001: {CONTROLNUMBER}</li>
Patch also includes some unit tests:
perl t/db_dependent/Biblio.t
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Tested with marcflavour = NORMARC, on one book and one periodical record.
* Book
- Before the patch:
ISSN: {ISSN}
ISBN: 0375726446
001:
- After the patch:
ISSN:
ISBN: 0375726446
001: 022976914
* Journal
- Before the patch:
ISSN: {ISSN}
ISBN:
001:
- After the patch:
ISSN: 1890-6931
ISBN:
001: 080721370
Looks good in all 3 views! Thanks for fixing the 001 thing for NORMARC!
Also tested with marcflavour = MARC21, on the same records with the same good
results. Signing off!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Tested marcflavour= UNIMARC, works fine too
113 lines
3.6 KiB
Perl
Executable file
113 lines
3.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# This Koha test module is a stub!
|
|
# Add more tests here!!!
|
|
|
|
use strict;
|
|
use warnings;
|
|
use Test::More tests => 17;
|
|
use MARC::Record;
|
|
use C4::Biblio;
|
|
|
|
BEGIN {
|
|
use_ok('C4::Biblio');
|
|
}
|
|
|
|
my $isbn = '0590353403';
|
|
my $title = 'Foundation';
|
|
|
|
my $marc_record=MARC::Record->new;
|
|
my $field = MARC::Field->new('020','','','a' => $isbn);
|
|
$marc_record->append_fields($field);
|
|
my($biblionumber,$biblioitemnumber) = AddBiblio($marc_record,'');
|
|
my $data = &GetBiblioData($biblionumber);
|
|
is($data->{Title},undef,'Makes sure title field in biblio is empty.');
|
|
|
|
$field = MARC::Field->new('245','','','a' => $title);
|
|
$marc_record->append_fields($field);
|
|
ModBiblio($marc_record,$biblionumber,'');
|
|
$data = &GetBiblioData($biblionumber);
|
|
is($data->{title},$title,'uses ModBiblio to add a title to the previously created record and checks that its there.');
|
|
is($data->{isbn},$isbn,'Makes sure the isbn is still there after using ModBiblio.');
|
|
|
|
my $itemdata = &GetBiblioItemData($biblioitemnumber);
|
|
is($itemdata->{title},$title,'First test of GetBiblioItemData to get same result of previous two GetBiblioData tests.');
|
|
is($itemdata->{isbn},$isbn,'Second test checking it returns the correct isbn.');
|
|
|
|
my $success = 0;
|
|
$field = MARC::Field->new(
|
|
655, ' ', ' ',
|
|
'a' => 'Auction catalogs',
|
|
'9' => '1'
|
|
);
|
|
eval {
|
|
$marc_record->append_fields($field);
|
|
$success = ModBiblio($marc_record,$biblionumber,'');
|
|
} or do {
|
|
diag($@);
|
|
$success = 0;
|
|
};
|
|
ok($success, "ModBiblio handles authority-linked 655");
|
|
|
|
eval {
|
|
$field->delete_subfields('a');
|
|
$marc_record->append_fields($field);
|
|
$success = ModBiblio($marc_record,$biblionumber,'');
|
|
} or do {
|
|
diag($@);
|
|
$success = 0;
|
|
};
|
|
ok($success, "ModBiblio handles 655 with authority link but no heading");
|
|
|
|
eval {
|
|
$field->delete_subfields('9');
|
|
$marc_record->append_fields($field);
|
|
$success = ModBiblio($marc_record,$biblionumber,'');
|
|
} or do {
|
|
diag($@);
|
|
$success = 0;
|
|
};
|
|
ok($success, "ModBiblio handles 655 with no subfields");
|
|
|
|
# Testing GetMarcISSN
|
|
my $issns;
|
|
$issns = GetMarcISSN( $marc_record, 'MARC21' );
|
|
is( $issns->[0], undef,
|
|
'GetMarcISSN handles records without 022 (list is empty)' );
|
|
is( scalar @$issns, 0, 'GetMarcISSN handles records without 022 (number of elements correct)' );
|
|
|
|
my $issn = '1234-1234';
|
|
$field = MARC::Field->new( '022', '', '', 'a', => $issn );
|
|
$marc_record->append_fields($field);
|
|
$issns = GetMarcISSN( $marc_record, 'MARC21' );
|
|
is( $issns->[0], $issn,
|
|
'GetMarcISSN handles records with single 022 (first element is correct)' );
|
|
is( scalar @$issns, 1, 'GetMARCISSN handles records with single 022 (number of elements correct)'
|
|
);
|
|
|
|
my @more_issns = qw/1111-1111 2222-2222 3333-3333/;
|
|
foreach (@more_issns) {
|
|
$field = MARC::Field->new( '022', '', '', 'a', => $_ );
|
|
$marc_record->append_fields($field);
|
|
}
|
|
$issns = GetMarcISSN( $marc_record, 'MARC21' );
|
|
is( scalar @$issns, 4, 'GetMARCISSN handles records with multiple 022 (number of elements correct)'
|
|
);
|
|
|
|
# Testing GetMarcControlnumber
|
|
my $controlnumber;
|
|
$controlnumber = GetMarcControlnumber( $marc_record, 'MARC21' );
|
|
is( $controlnumber, '', 'GetMarcControlnumber handles records without 001' );
|
|
|
|
$field = MARC::Field->new( '001', '' );
|
|
$marc_record->append_fields($field);
|
|
$controlnumber = GetMarcControlnumber( $marc_record, 'MARC21' );
|
|
is( $controlnumber, '', 'GetMarcControlnumber handles records with empty 001' );
|
|
|
|
$field = $marc_record->field('001');
|
|
$field->update('123456789X');
|
|
$controlnumber = GetMarcControlnumber( $marc_record, 'MARC21' );
|
|
is( $controlnumber, '123456789X', 'GetMarcControlnumber handles records with 001' );
|
|
|
|
# clean up after ourselves
|
|
DelBiblio($biblionumber);
|