Kyle M Hall
181d3aa56d
If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
88 lines
3 KiB
XML
88 lines
3 KiB
XML
<acsconfig xmlns="http://openncip.org/acs-config/1.0/">
|
|
<!-- above address gets nothing, it's just a namespace -->
|
|
<error-detect enabled="true" />
|
|
|
|
<!--
|
|
Set Net::Server::PreFork runtime parameters
|
|
syslog_ident will identify SIP2 Koha server entries in syslog
|
|
For OpenSolaris, add: syslog_logsock=stream
|
|
-->
|
|
<server-params
|
|
min_servers='1'
|
|
min_spare_servers='0'
|
|
log_file='Sys::Syslog'
|
|
syslog_ident='koha_sip'
|
|
syslog_facility='local6'
|
|
/>
|
|
|
|
<listeners>
|
|
<!-- vestigial HTTP, never implemented: just use the OPAC!
|
|
<service
|
|
port="0:8080/tcp"
|
|
transport="http"
|
|
protocol="NCIP/1.0" />
|
|
-->
|
|
<service
|
|
port="8023/tcp"
|
|
transport="telnet"
|
|
protocol="SIP/2.00"
|
|
timeout="60" />
|
|
|
|
<service
|
|
port="127.0.0.1:6001/tcp"
|
|
transport="RAW"
|
|
protocol="SIP/2.00"
|
|
timeout="60" />
|
|
</listeners>
|
|
|
|
<accounts>
|
|
<login id="term1" password="term1" delimiter="|" error-detect="enabled" institution="CPL" encoding="ascii" checked_in_ok="1" />
|
|
<login id="koha" password="koha" delimiter="|" error-detect="enabled" institution="kohalibrary" encoding="utf8" />
|
|
<login id="koha2" password="koha" institution="kohalibrary2" terminator="CR" />
|
|
<login id="lpl-sc" password="1234" institution="LPL" />
|
|
<login id="lpl-sc-beacock" password="xyzzy"
|
|
delimiter="|" error-detect="enabled" institution="LPL"
|
|
send_patron_home_library_in_af="1" >
|
|
<screen_msg_regex find="Greetings from Koha." replace="Welcome to your library!" />
|
|
<screen_msg_regex find="Invalid patron barcode." replace="Barcode not found, are you sure this is your library card?" />
|
|
</login>
|
|
</accounts>
|
|
|
|
<!--
|
|
Institution tags are for enabled branches. There needs to be one
|
|
institution stanza for each institution named in the accounts above.
|
|
The implementation attribute is actually used to find the code to run,
|
|
in our case "ILS".
|
|
-->
|
|
|
|
<institutions>
|
|
<institution id="MAIN" implementation="ILS" parms="">
|
|
<policy checkin="true" renewal="true" checkout="true"
|
|
status_update="false" offline="false"
|
|
timeout="100"
|
|
retries="5" />
|
|
</institution>
|
|
<institution id="CPL" implementation="ILS" parms="">
|
|
<policy checkin="true" renewal="true" checkout="true"
|
|
status_update="false" offline="false"
|
|
timeout="25"
|
|
retries="5" />
|
|
</institution>
|
|
<institution id="kohalibrary" implementation="ILS" parms="">
|
|
<policy checkin="true" renewal="false" checkout="true"
|
|
status_update="false" offline="false"
|
|
timeout="100"
|
|
retries="5" />
|
|
</institution>
|
|
<institution id="kohalibrary2" implementation="ILS" parms="">
|
|
<policy checkin="true" renewal="false" checkout="true"
|
|
timeout="100"
|
|
retries="3" />
|
|
</institution>
|
|
<institution id="LPL" implementation="ILS">
|
|
<policy checkin="true" renewal="false" checkout="true"
|
|
timeout="100"
|
|
retries="5" />
|
|
</institution>
|
|
</institutions>
|
|
</acsconfig>
|