Koha/t/db_dependent/api/v1/ill_requests.t
Tomas Cohen Arazi 1a8903ae85
Bug 33834: Fix random failure on api/v1/ill_requests.t
This patch makes the GET request results more deterministic so we avoid
random failures. It does so by adding a fixed value to each ILL request
and then sorting by it.

To test:
1. Run:
   $ DB_IMAGE=mysqli:8.0 ktd up -d
   # wait until it finished:
   $ ktd --logs
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/ill_requests.t
  (repeat a few times)
=> FAIL: It sometimes fails
3. Apply this patch
4. Repeat 2
=> SUCCESS: It doesn't fail
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-05-26 09:50:04 -03:00

258 lines
8.4 KiB
Perl
Executable file

#!/usr/bin/env perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 1;
use Test::MockModule;
use Test::MockObject;
use Test::Mojo;
use JSON qw(encode_json);
use t::lib::TestBuilder;
use t::lib::Mocks;
use Koha::AuthorisedValueCategories;
use Koha::Illrequests;
use Koha::DateUtils qw( format_sqldatetime );
my $schema = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;
t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
my $t = Test::Mojo->new('Koha::REST::V1');
subtest 'list() tests' => sub {
plan tests => 34;
# Mock ILLBackend (as object)
my $backend = Test::MockObject->new;
$backend->set_isa('Koha::Illbackends::Mock');
$backend->set_always('name', 'Mock');
$backend->set_always('capabilities', sub { return 'bar'; } );
$backend->mock(
'metadata',
sub {
my ( $self, $rq ) = @_;
return {
ID => $rq->illrequest_id,
Title => $rq->patron->borrowernumber
}
}
);
$backend->mock(
'status_graph', sub {},
);
# Mock Koha::Illrequest::load_backend (to load Mocked Backend)
my $illreqmodule = Test::MockModule->new('Koha::Illrequest');
$illreqmodule->mock( 'load_backend',
sub { my $self = shift; $self->{_my_backend} = $backend; return $self }
);
$schema->storage->txn_begin;
Koha::Illrequests->search->delete;
# create an authorized user
my $librarian = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 2 ** 22 } # 22 => ill
}
);
my $password = 'thePassword123';
$librarian->set_password( { password => $password, skip_validation => 1 } );
my $userid = $librarian->userid;
# create an unauthorized user
my $patron = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 0 }
}
);
$patron->set_password( { password => $password, skip_validation => 1 } );
my $unauth_userid = $patron->userid;
# Make sure the ILL_STATUS_ALIAS authorised value category is defined
unless ( Koha::AuthorisedValueCategories->search( { category_name => 'ILL_STATUS_ALIAS' } )->count > 0 ) {
$builder->build_object(
{ class => 'Koha::AuthorisedValueCategories', value => { category_name => 'ILL_STATUS_ALIAS' } } );
}
my $tag = "Print copy";
my $av_code = "print_copy";
my $av = $builder->build_object(
{ class => 'Koha::AuthorisedValues',
value => {
category => 'ILL_STATUS_ALIAS',
authorised_value => $av_code,
lib => $tag,
}
}
);
# No requests, expect empty
$t->get_ok("//$userid:$password@/api/v1/ill/requests")
->status_is(200)
->json_is( [] );
# Prepare some expected response structure
my $request_status = {
code =>"REQ",
str =>"Requested"
};
my $response_status = {
backend => $backend->name,
code =>$request_status->{code},
str =>$request_status->{str},
type =>"ill_status"
};
my $response_status_av = {
category => "ILL_STATUS_ALIAS",
code => $av_code,
str => $tag,
type => "av"
};
# Create some ILL requests
my $req_1 = $builder->build_object(
{
class => 'Koha::Illrequests',
value => {
borrowernumber => $patron->borrowernumber,
status => $request_status->{code},
backend => $backend->name,
notesstaff => '1'
}
}
);
my $req_2 = $builder->build_object(
{
class => 'Koha::Illrequests',
value => {
status => $request_status->{code},
backend => $backend->name,
status_alias => $av->authorised_value,
notesstaff => '2'
}
}
);
my $ret = $builder->build_object({ class => 'Koha::Illrequests', value => { status => 'RET' } });
# Three requests exist, expect all three to be returned
$t->get_ok("//$userid:$password@/api/v1/ill/requests")
->status_is(200)
->json_is( [ $req_1->to_api, $req_2->to_api, $ret->to_api ]);
my $status_query = encode_json({ status => 'REQ' });
my $status_alias_query = encode_json({ status_av => $av_code });
# x-koha-embed: +strings
# Two requests exist with status 'REQ', expect them to be returned
# One of which also has a status_alias, expect that to be in that request's body
$t->get_ok("//$userid:$password@/api/v1/ill/requests?q=$status_query" => {"x-koha-embed" => "+strings"} )
->status_is(200)
->json_is( [
{ _strings => { status => $response_status }, %{$req_1->to_api} },
{ _strings => { status => $response_status, status_av => $response_status_av }, %{$req_2->to_api} }
]
);
# One request with status_alias 'print_copy' exists, expect that to be returned
$t->get_ok("//$userid:$password@/api/v1/ill/requests?q=$status_alias_query" => {"x-koha-embed" => "+strings"} )
->status_is(200)
->json_is( [
{ _strings => { status => $response_status, status_av => $response_status_av }, %{$req_2->to_api} }
]
);
# x-koha-embed: patron
my $patron_query = encode_json({ borrowernumber => $patron->borrowernumber });
# One request related to $patron, make sure it comes back
$t->get_ok("//$userid:$password@/api/v1/ill/requests" => {"x-koha-embed" => "patron"} )
->status_is(200)
->json_has('/0/patron', $patron->to_api);
# x-koha-embed: comments
# Create comment
my $comment_text = "This is the comment";
my $comment = $builder->build_object({ class => 'Koha::Illcomments', value => { illrequest_id => $req_1->illrequest_id, comment => $comment_text , borrowernumber => $patron->borrowernumber } } );
# Make sure comments come back
$t->get_ok("//$userid:$password@/api/v1/ill/requests" => {"x-koha-embed" => "comments"} )
->status_is(200)
->json_has('/0/comments', $comment_text);
# x-koha-embed: id_prefix
# Mock Illrequest::Config to return a static prefix
my $id_prefix = 'ILL';
my $config = Test::MockObject->new;
$config->set_isa('Koha::Illrequest::Config::Mock');
$config->set_always('getPrefixes', $id_prefix);
# Make sure id_prefix comes back
$t->get_ok("//$userid:$password@/api/v1/ill/requests" => {"x-koha-embed" => "id_prefix"} )
->status_is(200)
->json_has('/0/id_prefix', $id_prefix);
# ILLHiddenRequestStatuses syspref
# Hide 'REQ', expect to return just 1 'RET'
t::lib::Mocks::mock_preference( 'ILLHiddenRequestStatuses', 'REQ' );
$t->get_ok( "//$userid:$password@/api/v1/ill/requests" )
->status_is(200)
->json_is( [ $ret->to_api ] );
# Hide 'RET', expect to return 2 'REQ'
t::lib::Mocks::mock_preference( 'ILLHiddenRequestStatuses', 'RET' );
$t->get_ok( "//$userid:$password@/api/v1/ill/requests?_order_by=staff_notes" )
->status_is(200)
->json_is( [ $req_1->to_api, $req_2->to_api ]);
# Status code
# Warn on unsupported query parameter
$t->get_ok( "//$userid:$password@/api/v1/ill/requests?request_blah=blah" )
->status_is(400)
->json_is(
[{ path => '/query/request_blah', message => 'Malformed query string'}]
);
# Unauthorized attempt to list
$t->get_ok(
"//$unauth_userid:$password@/api/v1/ill/requests")
->status_is(403);
# DELETE method not supported
$t->delete_ok(
"//$unauth_userid:$password@/api/v1/ill/requests/1")
->status_is(404);
#TODO; test complex query on extended_attributes
$schema->storage->txn_rollback;
};