b07f4debb7
At the moment we cache numerous pieces of information in module-level
variables which then do not get updated in other threads/processes when
they are changed by the user. This is a serious usability issue.
Examples of this include the way we treat sysprefs (there is now a
method to disable the syspref cache, but by default it is enabled),
notices, frameworks, field mappings, and koha-conf.xml, at least.
This patch sets the stage for eliminating this problem by making it
possible to convert module-level cache variables into variables that
are actually backed by whatever caching system may be configured. This
is done through a special Koha::Cache::Object class which can be tied
to the variables that are being used for caching and provided with a
constructor method/closure to allow the cache to be reloaded when it
expires. For example:
my $cache = Koha::Cache->new();
my $data = 'whatever';
my $variable = Koha::Cache->create_scalar(
{
'key' => 'whatever',
'timeout' => 2,
'constructor' => sub { return $data; },
}
);
print "$$variable\n"; # Prints "whatever"
The one change this necessitates for accessing the data is that the
variable must be dereferenced an additional time before use (i.e.
$$variable instead of $variable). There is no difference when the
variable tied is a hash (created with Koha::Cache->create_hash). This
is a small price to pay for Koha working in a multi-threaded, persistent
environment. This change will also make caching easier in general.
CHI was incompatible with the variable tying, so this patch also removes
the dependency on CHI, using instead Cache::Memcached::Fast,
Cache::FastMmap, and Cache::Memory, when they are available.
To test:
1) Apply patch.
2) Run unit test t/Cache.t (after setting the MEMCACHED_SERVERS and
CACHING_SYSTEM environment variables). As no changes were made to
the tests already in that file, this passing demonstrates there
are no regressions.
3) With memcached caching enabled (you must set the MEMCACHED_SERVERS
and CACHING_SYSTEM environment variables) and DEBUG turned on (i.e.
the DEBUG environment variable set to 1), try running a report via
the web service ([intranet]/cgi-bin/koha/svc/report?id=1 and check
your web server logs to confirm that there are messages like
"get_from_cache for intranet:report:id:1" in them.
4) If the reports worked, sign off.
NOTE: Technically you could test this without needing memcached by
installing libcache-fastmmap-perl and setting CACHING_SYSTEM to
'fastmmap' instead of 'memcached'. You could also install libcache-perl
and set CACHING_SYSTEM to 'memory' but there would be little point as
the cached variables would go out of scope in between runs.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
52 lines
1.5 KiB
Perl
52 lines
1.5 KiB
Perl
# This script is called by the pre-commit git hook to test modules compile
|
|
|
|
use strict;
|
|
use warnings;
|
|
use Test::More;
|
|
use File::Spec;
|
|
use File::Find;
|
|
|
|
my $lib = File::Spec->rel2abs('C4');
|
|
find({
|
|
bydepth => 1,
|
|
no_chdir => 1,
|
|
wanted => sub {
|
|
my $m = $_;
|
|
return unless $m =~ s/[.]pm$//;
|
|
$m =~ s{^.*/C4/}{C4/};
|
|
$m =~ s{/}{::}g;
|
|
return if $m =~ /Auth_with_ldap/; # Dont test this, it will fail on use
|
|
return if $m =~ /SIP/; # SIP modules will not load clean
|
|
return if $m =~ /C4::VirtualShelves$/; # Requires a DB
|
|
return if $m =~ /C4::Auth$/; # DB
|
|
return if $m =~ /C4::Tags$/; # DB
|
|
return if $m =~ /C4::Service/; # DB
|
|
return if $m =~ /C4::Auth_with_cas/; # DB
|
|
return if $m =~ /C4::BackgroundJob/; # DB
|
|
return if $m =~ /C4::UploadedFile/; # DB
|
|
return if $m =~ /C4::Reports::Guided/; # DB
|
|
return if $m =~ /C4::VirtualShelves::Page/; # DB
|
|
return if $m =~ /C4::Members::Statistics/; # DB
|
|
use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'");
|
|
},
|
|
}, $lib);
|
|
|
|
$lib = File::Spec->rel2abs('Koha');
|
|
find(
|
|
{
|
|
bydepth => 1,
|
|
no_chdir => 1,
|
|
wanted => sub {
|
|
my $m = $_;
|
|
return unless $m =~ s/[.]pm$//;
|
|
$m =~ s{^.*/Koha/}{Koha/};
|
|
$m =~ s{/}{::}g;
|
|
return if $m =~ /Koha::SearchEngine/; # Koha::SearchEngine::* are experimental
|
|
use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'");
|
|
},
|
|
},
|
|
$lib
|
|
);
|
|
|
|
|
|
done_testing();
|