Koha/t/db_dependent
Jonathan Druart 405c2ac6b6
Bug 37870: Fix sort order of class sources
There are several things going on here.
The tests are failing randomly when some additional class sources are in the
DB. This should never happen on Jenkins, but it happened, see the third
patch of this patch set (spoiler: tests not run within a txn)

There were also a sorting problem: by default sort will show
uppercases first:
  A, B, C, a, b, c
However we want:
  a, A, b, B, c, C
which is what fc does (https://perldoc.perl.org/functions/fc)

Test plan:
0. Checkout the main branch, without patches from this patchset.
1. Run t/db_dependent/ClassSources.t several times
=> Notice that new entries in the DB table 'class_sources' are created
2. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and
t/db_dependent/Koha/UI/Form/Builder/Item.t
=> They fail (if not, run t/db_dependent/ClassSources.t again)
3. Apply the patches
4. Run t/db_dependent/ClassSources.t
=> No more additional entries in DB, tests are correctly run within
transactions
5. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and
   t/db_dependent/Koha/UI/Form/Builder/Item.t several times
=> They always pass

Note that the sort should actually be done on the description, not the
code. But that's for another bug...

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-09-12 13:52:35 +02:00
..
Acquisition Bug 32132: Fix failing tests 2024-04-23 16:47:05 +01:00
api/v1 Bug 37686: Fix render_resource_not_found() and render_resource_deleted() misses 2024-08-29 18:16:19 +02:00
Auth Bug 36056: Clarify subpermissions AND behavior 2024-03-07 17:35:40 +01:00
AuthoritiesMarc
Authority Bug 36917: (follow-up) Add FIXME for marcflavour 2024-05-24 15:36:43 +02:00
Biblio Bug 35993: (follow-up) Another fix for MarcOverlayRules.t 2024-05-02 15:03:41 +02:00
Budgets
Circulation Bug 35539: Remove 'issuelimit' column/field from categories table 2024-07-25 11:11:16 +01:00
CourseReserves
Creators
cronjobs
data Bug 35418: Add TR_B2 tests 2023-11-29 17:36:11 -03:00
Exporter
Holds Bug 36923: Remove warnings from Holds/LocalHoldsPriority.t 2024-05-24 15:36:46 +02:00
HoldsQueue Bug 35826: Add unit tests. 2024-04-26 18:06:18 +02:00
Illrequest Bug 34838: (QA follow-up): TypeDisclaimer tests - Add 'type' to request metadata 2024-06-11 13:28:17 +01:00
Items Bug 36010: Fix Items/AutomaticItemModificationByAge.t failing since Bug 32029 2024-03-07 16:36:46 +01:00
Koha Bug 37870: Fix sort order of class sources 2024-09-12 13:52:35 +02:00
Labels Bug 36687: (RM follow-up) Fix unit tests 2024-05-09 09:22:00 +01:00
LDAP
Letters Bug 31383: Adjust and add tests 2023-10-20 14:43:57 -03:00
Members Bug 33947: Remove GetAllIssues 2023-10-20 11:03:03 -03:00
misc/translator
OAI
Patron Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
Record
Reports Bug 37508: (QA follow-up) Use ->check_columns 2024-08-16 16:22:26 +02:00
Reserves Bug 35959: Add missing use statements in tests 2024-07-08 17:49:19 +02:00
Search
selenium Bug 37748: Adjust the 'Update child to patron' selenium test 2024-08-29 17:24:03 +02:00
Serials
SIP Bug 28924: (QA follow-up): Fix unit tests 2024-07-18 18:25:57 +02:00
Template/Plugin Bug 37628: (follow-up) Remove get_opac_news_by_id 2024-08-16 17:33:51 +02:00
Utils Bug 34913: Adjust C4::Utils::DataTables::VirtualShelves 2024-01-26 15:13:42 +01:00
www Bug 32693: Fix history.t 2024-05-08 18:23:57 +02:00
00-strict.t Bug 36999: Fix 00-strict.t fails to find koha_perl_deps.pl 2024-06-13 13:43:47 +01:00
Accounts.t Bug 34912: Add 14 hours to 1970 date in Account(s).t 2023-10-04 09:15:39 -04:00
Acquisition.t Bug 32132: (RM follow-up) Use testbuilder in Acquisitions.t 2024-04-24 10:08:28 +01:00
Amazon.t
ArticleRequests.t
AudioAlerts.t
Auth.t Bug 37104: Unit tests 2024-07-01 18:55:52 +02:00
Auth_with_cas.t
Auth_with_ldap.t Bug 36575: Unit tests for checkpw_ldap 2024-06-20 17:55:30 +02:00
Auth_with_shibboleth.t Bug 36575: Unit tests for checkpw_shib 2024-06-20 17:55:31 +02:00
AuthorisedValues.t Bug 28869: Unit tests 2024-05-17 10:36:24 +02:00
AuthoritiesMarc.t Bug 35989: (QA follow-up): Fix QA tests 2024-06-06 15:18:43 +01:00
AuthoritiesMarc_GetTagsLabels.t
AuthUtils.t
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t Bug 36938: Adjusts tests to remove warns 2024-06-10 16:20:16 +01:00
Biblio_holdsqueue.t
Breeding.t Bug 28166: (QA follow-up) Fix and tidy tests and code 2023-10-23 11:33:50 -03:00
Breeding_Auth.t
Budgets.t Bug 31631: (QA follow-up) Tidy code 2023-10-18 15:41:37 -03:00
Cache.t
Calendar.t
Charset.t
check_kohastructure.t
check_sysprefs.t Bug 29948: Adjust sysprefs.sql 2024-05-13 16:24:17 +02:00
Circulation.t Bug 37016: Unit tests 2024-06-27 11:50:05 +02:00
Circulation_holdsqueue.t Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
ClassSources.t Bug 23387: Add caching to C4::ClassSource 2024-08-26 17:39:31 +02:00
Clubs.t
Context.t
Contract.t
CourseReserves.t Bug 36687: (RM follow-up) Fix unit tests 2024-05-09 09:22:00 +01:00
db_structure.t
DecreaseLoanHighHolds.t Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
Filter_MARC_ViewPolicy.t
Fines.t
FrameworkPlugin.t Bug 37146: Add tests 2024-08-01 17:26:37 +02:00
Heading.t
Heading_MARC21.t
Hold.t Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
Holds.t Bug 17617: Unit tests 2023-11-08 11:41:26 -03:00
HoldsQueue.t Bug 32565: (follow-up) Tidy 2024-04-30 14:32:07 +02:00
Holidays.t Bug 27249: Replace DateTime->now by dt_from_string 2023-10-17 14:45:34 -03:00
ILSDI_Services.t Bug 36453: Update tests 2024-06-11 10:43:53 +01:00
ImportBatch.t
ImportExportFramework.t
Installer.t
Items.t Bug 36535: (bug 33568 follow-up) Add missing tests 2024-04-26 14:14:48 +02:00
Koha.t
Koha_Database.t Bug 36367: Remove schema_stack 2024-06-14 11:17:18 +01:00
Koha_Elasticsearch.t Bug 35138: Fix Koha_Elasticsearch.t 2024-04-30 12:00:59 +02:00
Koha_ExternalContent_OverDrive.t
Koha_MetadataRecord_Authority.t
Koha_Misc_Files.t
Languages.t
Letters.t Bug 37623: Make t/db_dependent/Letters.t idempotent 2024-08-19 17:29:53 +02:00
LibraryGroups.t
Linker_Default.t Bug 35125: Respect LinkerConsiderThesaurus in update_cache 2024-07-01 18:55:42 +02:00
Linker_FirstMatch.t
Log.t Bug 25159: (QA follow-up) Tidy changes 2024-05-02 16:47:44 +02:00
MarcModificationTemplates.t Bug 24480: (follow-up) Adjust tests 2023-11-03 12:04:35 -03:00
Matcher.t
Members.t Bug 26170: Add protected status for patrons 2023-11-01 17:23:06 -03:00
Message.t
MungeMarcPrice.t
Overdues.t Bug 36128: (QA follow-up) Add regression test 2024-06-27 14:04:47 +02:00
Passwordrecovery.t
Patroncards.t
PatronLists.t Bug 32730: Add Patron Lists tab to patron details and circulation pages 2023-11-01 17:23:09 -03:00
Patrons.t Bug 36508: Unit tests 2024-04-30 14:32:04 +02:00
Prices.t Bug 34967: Move to db_dependent 2023-10-03 09:24:50 -04:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
Reports.t
Reserves.t Bug 36687: (RM follow-up) Fix unit tests 2024-05-09 09:22:00 +01:00
rollingloans.t Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
RotatingCollections.t
Search.t Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" 2024-05-23 17:51:15 +02:00
Serials.t Bug 37476: Unit tests 2024-07-26 14:50:45 +01:00
Serials_2.t
Service.t
ShelfBrowser.t
Sitemapper.t
SocialData.t
StockRotationItems.t
StockRotationRotas.t
StockRotationStages.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 19097: Adjust some GetMarcFromKohaField calls 2024-04-29 09:35:47 +02:00
sysprefs.t Bug 36793: Unit test 2024-05-17 10:36:34 +02:00
TablesSettings.t
Tags.t
Templates.t
TestBuilder.t
Upload.t
UsageStats.t
Virtualshelves.t Bug 13888: (follow-up) fix tests for Virtualshelves 2024-07-23 09:19:23 +01:00
XISBN.t
XSLT.t
yaml.t
zebra_config.pl