Koha/acqui
Adrien Saurat 28ef6c199b Bug 6893 : Updates suggestions list when adding orders
A suggestion added through addorder.pl now changes
to the ORDERED status as initially intended (but so
far it stayed as ACCEPTED).

This fixes the list of potential suggestions to order,
the ORDERED ones don't appear anymore.

Bug 6893 : Follow-up: Disabled WHERE clause excluding ORDERED status

In SearchSuggestions, a WHERE clause was excluding the ORDERED
suggestions from the results. Now replaced with 1=1.

(before 6893 correction, the WHERE clause was excluding the
STATUS='CLAIMED' suggestions, but this status cannot be found anywhere
else in the code... so I changed to STATUS='ORDERED' which
seemed more accurate, but it had impacts on OPAC and some Admin tabs)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Both patches applied cleanly, sqashed them together after testing.

Tested:
1) Creating new suggestions
- from OPAC, shows up in patron account as 'requested', pending in staff
- from staff, shows up in list of pending suggestions
Status in database is ASKED

Note: suggestions made from staff for the same patron have suggestedby = 0
in the database, so are not showing up in the patron account. Is this by
intention? (if not, I think this is a separate bug)

2) Accepting suggestions
- from list
- from edit page
Status in database is ACCEPTED
Patron account shows 'Accepted by the library (Bestseller)'

Note: after changing the status from the list, bug 4068 kicks in and
some tabs and even suggestions are hidden. Going back to the acq start
page and going back to the suggestions page from there helps.

3) Rejecting suggestions
- from list
- from edit page
Status in database is REJECTED
Patron account in OPAC shows 'Suggestion declined'

Note: bug 4068 again.

4) Ordering from suggestions
- new basket
- ordered 2 accepted suggestions
SUCCESS! Great improvement:
- Status in database is now ORDERED
- Already ordered suggestions no longer show up on list of
  suggestions to order from.
- Patron account shows 'Ordered by the library (Bestseller)'
- Suggestion management page shows a new tab 'Ordered'
- For the suggestion with a valid 'suggestedby' borrowernumber,
  a mail was generated. (bug 7094)

5) Receive ordered suggestions
- received my ordered suggestions
This is is not in the scope of this bug, but for documentation:
- No message was generated to inform the patron
- Status stays ORDERED
- Patron account still shows item as ordered, no change to 4)

Looking at the suggestion.tt I think there should be another status
AVAILABLE.
216     [% ELSIF (suggestion.suggestiontypelabel == "Available") %]Available

Signing off, fixes bug reported. Danke!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2011-12-06 20:30:04 +01:00
..
pdfformat Bug 5970: Adds the ability to use a free delivery address for basket 2011-04-05 15:10:17 +12:00
acqui-home.pl bug 6834 followup removing param_map 2011-09-03 06:39:24 +12:00
addorder.pl Bug 6893 : Updates suggestions list when adding orders 2011-12-06 20:30:04 +01:00
addorderiso2709.pl BZ6074: setting import flag when staged file imported in aqbasket 2011-10-07 10:08:41 +13:00
basket.pl Bug 5680: Order cancelling improvement : delete attached items & biblio if avalaible 2011-10-19 16:58:46 +13:00
basketgroup.pl Bug 7138: Can't print basket group order pdf 2011-11-09 17:07:26 +01:00
basketheader.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
booksellers.pl Bug 6390 Followup: Basket's authorisedby might not be a borrowernumber 2011-11-06 17:55:37 +01:00
check_budget_total.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
check_duplicate_barcode_ajax.pl Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. 2011-11-04 10:22:28 +01:00
currency.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
finishreceive.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
histsearch.pl Bug 6807 - Add ISBN filter to advanced order search. 2011-10-14 10:57:30 +13:00
lateorders.pl Bug5063: C4::Bookseller Changes 2011-03-12 08:42:26 +13:00
neworderbiblio.pl Bug 6994: Wrong 'no budget defined' alert 2011-11-06 11:43:30 +01:00
neworderempty.pl Follow-up patch : use the subfield associated with items.barcode 2011-11-04 10:22:52 +01:00
newordersuggestion.pl Bug5063: C4::Bookseller Changes 2011-03-12 08:42:26 +13:00
orderreceive.pl Bug5063: C4::Bookseller Changes 2011-03-12 08:42:26 +13:00
parcel.pl Bug 5680: Follow Up for Order cancelling improvement : the same for parcel.pl 2011-10-19 16:59:12 +13:00
parcels.pl Bug 6072: fixing permission inconsistencies MT5306 2011-04-08 13:10:12 +12:00
supplier.pl Bug 3388: Restore account number on vendor page 2011-11-25 11:07:11 +01:00
uncertainprice.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
updatesupplier.pl Bug 3388: Restore account number on vendor page 2011-11-25 11:07:11 +01:00
z3950_search.pl Bug 5445: Nicer breadcrumbs when ordering from different sources 2011-04-27 16:10:46 +12:00