Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/Koha
History
Tomas Cohen Arazi 56a2607c46 Bug 14646: Koha::RecordProcessor should accept more than one filter 
The docs say that Koha::RecordProcessor accepts more than one filter
at a time. But as the regression tests show it doesn't.

This is really important to extend its usage in record processing
(either to enforce policy, transform, etc).

This patch makes ->new evaluate the reference type of the passed filters
and builds an array with a single item if a scalar has been passed. The
loop now explicitly casts the filters as an array.

To test:
- Apply the test patch
- Run
  $ prove t/RecordProcessor.t
=> FAIL: tests fail because Koha::RecordProcessor doesn't hanlde
         more than one filter at a time.
- Apply this patch
- Run
  $ prove t/RecordProcessor.t
=> SUCCESS: tests now pass
- Easy, right? Sign off :-D

NOTE: Read code. Don't like the ? operator logic, but it is
      functional despite readability issues.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
2015-08-20 13:44:15 -03:00
..
Acquisition Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber 2015-02-10 11:24:08 -03:00
Borrower Bug 14280: Add branches fields to discharges letters 2015-06-11 13:12:32 -03:00
Cache Bug 12041 - improve Koha::Cache 2014-06-19 13:05:04 -03:00
Config Bug 13967 - System preferences need a package 2015-06-04 10:39:11 -03:00
Filter/MARC Bug 14456: EmbedSeeFromHeadings record filter shouldn't process MARC holding fields 2015-07-24 13:39:53 -03:00
Indexer Bug 10143 - Fixing license headers 2013-05-01 06:47:50 -04:00
Item/Search Bug 11425: Add unit tests 2014-11-04 19:10:28 -03:00
List Bug 15065: (follow-up) update license header 2013-10-14 21:50:10 +00:00
Misc Bug 3050 - Add an option to upload scanned invoices #1/3 2014-05-25 21:14:00 +00:00
Number Bug 13836: Does not separate symbol and value if symbol is not displayed. 2015-03-19 14:10:21 -03:00
Plugins Bug 14467: Security updates break some Koha plugins 2015-07-07 14:50:43 -03:00
QueryParser/Driver Bug 12647: PQF QueryParser driver and unit tests fixes 2014-08-11 10:09:38 -03:00
RecordProcessor Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Schema/Result Bug 6874: (RM followup) DBIx updates 2015-08-11 11:57:21 -03:00
SuggestionEngine Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Template/Plugin Bug 7380: Refactor the patron search box header 2015-05-19 10:10:31 -03:00
Util Bug 13437: Preliminary changes for marc21 plugins field 008 2015-06-10 12:51:26 -03:00
Authority.pm Bug 5202: QA follow-up - correct license and POD errors 2013-10-10 21:39:15 +00:00
AuthUtils.pm Bug 11944: Authentication 2015-01-13 13:07:14 -03:00
Biblio.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
Biblios.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
Borrower.pm Bug 13019 - Add base classes on which to build Koha objects 2015-02-12 15:21:01 -03:00
Borrowers.pm Bug 13019 - Add base classes on which to build Koha objects 2015-02-12 15:21:01 -03:00
Branch.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
Branches.pm Bug 13851: Fix typo in POD 2015-07-29 15:47:47 -03:00
Cache.pm Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Calendar.pm Bug 14066: Correct and optimize 2015-05-06 11:05:22 -03:00
Database.pm Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
DateUtils.pm Bug 13601: The fallback regex should contain the time part 2015-03-30 13:40:07 -03:00
Email.pm Bug 9530: Adding a new Koha::Email module 2014-10-27 10:38:14 -03:00
FrameworkPlugin.pm Bug 9006: Remove AUTOLOAD in C4::Context 2015-07-20 10:11:41 -03:00
Hold.pm Bug 13853: Show waiting hold expiration date for waiting holds in holds ajax datatable 2015-08-11 14:48:35 -03:00
Holds.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
I18N.pm Bug 11848: (follow-up) update license statment 2014-05-05 04:51:42 +00:00
Item.pm Bug 13853: Show waiting hold expiration date for waiting holds in holds ajax datatable 2015-08-11 14:48:35 -03:00
Items.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
Linktracker.pm Bug 8917 : [ Sign followup ] Track clicks to links external to Koha 2013-03-07 11:14:25 -05:00
Logger.pm Bug 14167: (QA followup) use warn instead of just STDERR 2015-07-21 10:50:17 -03:00
MetadataRecord.pm Bug 9755 QA follow-up: move MARC-specific functionality to utility class 2013-07-23 23:10:21 +00:00
NorwegianPatronDB.pm Bug 14403: Remove warn in Koha::NorwegianPatronDB 2015-06-19 11:34:16 -03:00
Object.pm Bug 13019 [QA Followup] - Allow chaining 2015-02-12 15:21:13 -03:00
Objects.pm Bug 13967 - System preferences need a package 2015-06-04 10:39:11 -03:00
Plugins.pm Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
RecordProcessor.pm Bug 14646: Koha::RecordProcessor should accept more than one filter 2015-08-20 13:44:15 -03:00
Schema.pm Bug 11891: (follow-up) remove custom storage class 2014-06-19 11:55:03 -03:00
SimpleMARC.pm Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
SuggestionEngine.pm Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
XSLT_Handler.pm Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00