b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
143 lines
3.1 KiB
Perl
Executable file
143 lines
3.1 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
#
|
|
# Copyright (C) 2011 ByWater Solutions
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use strict;
|
|
use warnings;
|
|
BEGIN {
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/../kohalib.pl" };
|
|
}
|
|
|
|
# possible modules to use
|
|
use Getopt::Long;
|
|
|
|
use Koha::Script;
|
|
use C4::Context;
|
|
use C4::Biblio;
|
|
use Pod::Usage;
|
|
|
|
|
|
sub usage {
|
|
pod2usage( -verbose => 2 );
|
|
exit;
|
|
}
|
|
|
|
# Database handle
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
# Benchmarking variables
|
|
my $startime = time();
|
|
my $goodcount = 0;
|
|
my $badcount = 0;
|
|
my $totalcount = 0;
|
|
|
|
# Options
|
|
my $verbose;
|
|
my $whereclause = '';
|
|
my $help;
|
|
my $outfile;
|
|
|
|
GetOptions(
|
|
'o|output:s' => \$outfile,
|
|
'v' => \$verbose,
|
|
'where:s' => \$whereclause,
|
|
'help|h' => \$help,
|
|
);
|
|
|
|
usage() if $help;
|
|
|
|
if ($whereclause) {
|
|
$whereclause = "WHERE $whereclause";
|
|
}
|
|
|
|
# output log or STDOUT
|
|
my $fh;
|
|
if (defined $outfile) {
|
|
open ($fh, '>', $outfile) || die ("Cannot open output file");
|
|
} else {
|
|
open($fh, '>&', \*STDOUT) || die ("Couldn't duplicate STDOUT: $!");
|
|
}
|
|
|
|
my $sth1 = $dbh->prepare("SELECT biblionumber, frameworkcode FROM biblio $whereclause");
|
|
$sth1->execute();
|
|
|
|
# fetch info from the search
|
|
while (my ($biblionumber, $frameworkcode) = $sth1->fetchrow_array){
|
|
my $record = GetMarcBiblio({ biblionumber => $biblionumber });
|
|
|
|
my $modok = ModBiblio($record, $biblionumber, $frameworkcode);
|
|
|
|
if ($modok) {
|
|
$goodcount++;
|
|
print $fh "Touched biblio $biblionumber\n" if (defined $verbose);
|
|
} else {
|
|
$badcount++;
|
|
print $fh "ERROR WITH BIBLIO $biblionumber !!!!\n";
|
|
}
|
|
|
|
$totalcount++;
|
|
|
|
}
|
|
close($fh);
|
|
|
|
# Benchmarking
|
|
my $endtime = time();
|
|
my $time = $endtime-$startime;
|
|
my $accuracy = ($goodcount / $totalcount) * 100; # this is a percentage
|
|
my $averagetime = 0;
|
|
$averagetime = $time / $totalcount if $totalcount;
|
|
print "Good: $goodcount, Bad: $badcount (of $totalcount) in $time seconds\n";
|
|
printf "Accuracy: %.2f%%\nAverage time per record: %.6f seconds\n", $accuracy, $averagetime if (defined $verbose);
|
|
|
|
=head1 NAME
|
|
|
|
touch_all_biblios.pl
|
|
|
|
=head1 SYNOPSIS
|
|
|
|
touch_all_biblios.pl
|
|
touch_all_biblios.pl -v
|
|
touch_all_biblios.pl --where=STRING
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
When changes are made to ModBiblio (or the routines that are called by those),
|
|
it is sometimes necessary to run ModBiblio on all or some records in the catalog
|
|
when upgrading. This script does this.
|
|
|
|
=over 8
|
|
|
|
=item B<--help>
|
|
|
|
Prints this help
|
|
|
|
=item B<-v>
|
|
|
|
Provide verbose log information.
|
|
|
|
=item B<--where>
|
|
|
|
Limits the search with a user-specified WHERE clause.
|
|
|
|
=back
|
|
|
|
=cut
|
|
|