Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Marcel de Rooy 434162c175 Bug 17380: Graceful resolution of missing reporting tag in merge 
Altough this patch deals with a mostly hypothetical case and this report
makes it practically impossible anymore to merge with records in the
Default framework (having no reporting tag), we can make the code of
sub merge still a bit more robust here.

If you would merge biblio records from one authtype to another and the new
framework would not have a reporting tag, before this patch the result would
be data loss. Merge would handle this request as a delete. This patch makes
merge handle it differently: instead of clearing the biblio records, it
keeps $a and $9 in order to make a future corrective merge possible.

Note: The additional condition on line 1468 for $tags_using_authtype
makes sure that we do not select all fields when the authtype should
unexpectedly be empty string (Default). This prevents crashing on
a "Control fields do not have subfields" error.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-09-12 12:07:47 -03:00
..
Acquisition Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
api/v1 Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth
Authority Bug 17380: Graceful resolution of missing reporting tag in merge 2017-09-12 12:07:47 -03:00
Biblio Bug 18951: Adjust Isbd.t 2017-07-24 13:37:18 -03:00
Circulation Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t 2017-09-07 13:56:08 -03:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
data
Exporter Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
Items Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
Koha Bug 19268: Fix TestBuilder parameter in C/Branch.t and K/P/Messaging.t 2017-09-07 13:56:08 -03:00
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
LDAP
Letters Bug 19277: Make sure the tests will pass even if they are slow 2017-09-12 11:29:11 -03:00
Members Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
OAI Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Patron Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record
Reports Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
Reserves Bug 19025: Move GetReserveInfo to Koha::Holds 2017-08-30 15:06:10 -03:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-26 14:36:34 -03:00
selenium Bug 18982: Remove data in the correct order 2017-07-26 13:50:44 -03:00
Serials Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
SIP Bug 18812 - SIP Patron status does not respect OverduesBlockCirc 2017-09-01 13:00:05 -03:00
Template/Plugin Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
www Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
XSLT_Handler
00-strict.t Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl 2017-05-08 09:22:27 -04:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Acquisition.t Bug 19256: (QA followup) Remove warn from unit test 2017-09-07 15:03:04 -03:00
AdditionalField.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Amazon.t
ArticleRequests.t Bug 18766: Remove itemtype-related warnings from ArticleRequests.t 2017-06-09 10:50:53 -03:00
AudioAlerts.t
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-07-26 14:36:34 -03:00
Auth_with_cas.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Bookseller.t Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
Breeding.t
Budgets.t Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
Calendar.t Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
Circulation.t Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace 2017-09-01 17:05:17 -03:00
ClassSource.t
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
Context.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
DecreaseLoanHighHolds.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds.t Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace 2017-09-01 17:05:17 -03:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-07-24 14:12:27 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Elasticsearch_Indexer.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Languages.t
Letters.t Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
Linker_FirstMatch.t
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-08-25 12:12:04 -03:00
MungeMarcPrice.t
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Plugins.t Bug 15879: Add Tests 2017-01-11 14:03:00 +00:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
Reserves.t Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
rollingloans.t Bug 17829: Execute rollingloans tests in a transaction 2017-07-26 16:39:17 -03:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Stats.t
SuggestionEngine_ExplodedTerms.t Bug 9857: Fix failing tests 2017-09-01 16:22:02 -03:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
sysprefs.t
Tags.t
Templates.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
TestBuilder.t Bug 15339: Remove extra 'my' 2017-09-07 13:56:08 -03:00
Upload.t Bug 18300: [QA Follow-up] Fix return value inconsistency 2017-04-21 00:11:40 +00:00
UsageStats.t Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
Virtualshelves.t Bug 18672: [QA Follow-up] Simplify without sleep 2017-07-17 13:19:43 -03:00
XISBN.t
XSLT_Handler.t Bug 17807: Add format parameter to XSLT_Handler->transform 2017-08-30 15:06:40 -03:00
zebra_config.pl