43d999cc7c
When fixing Bug 23589 Theodoros Theodoropoulos noticed that we are sending
headers and html after pdf output to browser.
Using exit inside eval block doesn't stop plack from generating
headers and html page after exit since CGI::Compile will catch
exit but doesn't stop emiting output. Example is:
eval {
warn "in eval";
exit;
};
warn "after eval";
Under CGI, this would print just "in eval", but under plack we get both lines
and thus generate additional header and html after we already sent pdf data.
Signed-off-by: Theodoros Theodoropoulos <theod@lib.auth.gr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
116 lines
3.3 KiB
Perl
Executable file
116 lines
3.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Copyright 2013 BibLibre
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 NAME
|
|
|
|
discharges.pl
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
Allows librarian to edit and/or manage borrowers' discharges
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
use Carp;
|
|
|
|
use CGI qw( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Members;
|
|
use C4::Reserves;
|
|
use C4::Letters;
|
|
use Koha::Patron::Discharge;
|
|
use Koha::Patrons;
|
|
|
|
use Koha::DateUtils;
|
|
|
|
my $input = new CGI;
|
|
|
|
my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user({
|
|
template_name => 'members/discharge.tt',
|
|
query => $input,
|
|
type => 'intranet',
|
|
authnotrequired => 0,
|
|
flagsrequired => { 'borrowers' => 'edit_borrowers' },
|
|
});
|
|
|
|
my $borrowernumber = $input->param('borrowernumber');
|
|
|
|
unless ( C4::Context->preference('useDischarge') ) {
|
|
print $input->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrowernumber&nopermission=1");
|
|
exit;
|
|
}
|
|
|
|
my $logged_in_user = Koha::Patrons->find( $loggedinuser ) or die "Not logged in";
|
|
my $patron = Koha::Patrons->find( $borrowernumber );
|
|
output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } );
|
|
|
|
my $can_be_discharged = Koha::Patron::Discharge::can_be_discharged({
|
|
borrowernumber => $borrowernumber
|
|
});
|
|
|
|
# Generating discharge if needed
|
|
if ( $input->param('discharge') and $can_be_discharged ) {
|
|
my $is_discharged = Koha::Patron::Discharge::is_discharged({
|
|
borrowernumber => $borrowernumber,
|
|
});
|
|
unless ($is_discharged) {
|
|
Koha::Patron::Discharge::discharge({
|
|
borrowernumber => $borrowernumber
|
|
});
|
|
}
|
|
eval {
|
|
my $pdf_path = Koha::Patron::Discharge::generate_as_pdf(
|
|
{ borrowernumber => $borrowernumber, branchcode => $patron->branchcode } );
|
|
|
|
binmode(STDOUT);
|
|
print $input->header(
|
|
-type => 'application/pdf',
|
|
-charset => 'utf-8',
|
|
-attachment => "discharge_$borrowernumber.pdf",
|
|
);
|
|
open my $fh, '<', $pdf_path;
|
|
my @lines = <$fh>;
|
|
close $fh;
|
|
print @lines;
|
|
};
|
|
if ( $@ ) {
|
|
carp $@;
|
|
$template->param( messages => [ {type => 'error', code => 'unable_to_generate_pdf'} ] );
|
|
} else {
|
|
# no error, pdf is sent, so stop sending data to browser
|
|
exit;
|
|
}
|
|
}
|
|
|
|
# Already generated discharges
|
|
my @validated_discharges = Koha::Patron::Discharge::get_validated({
|
|
borrowernumber => $borrowernumber,
|
|
});
|
|
|
|
$template->param(
|
|
patron => $patron,
|
|
can_be_discharged => $can_be_discharged,
|
|
validated_discharges => \@validated_discharges,
|
|
);
|
|
|
|
$template->param( dischargeview => 1, );
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|