Koha/koha-tmpl/intranet-tmpl/prog/en/modules
Fridolyn SOMERS 4458e86865 Bug 10689: make public note appear in subscriptions search
In a serials module, when searching subscriptions, the results table as
a "Notes" column.
In TT code, you see that it tries to display public note
"subscription.notes" and internal note "subscription.internalnotes".

The internal note is displayed well but not the public note.

You can see the 2 notes in serial details in summary tab.

The problem commes from the SQL query. A join is perform on subscription
and biblio, both containing a "notes" column.

This patch solves the problem by using a alias in query for both columns
(biblio.notes is acutally not used in template but could be).

Test plan :
- Edit a subscription
- Add public and internal notes. For example : "too busy" and "on holiday"
- Perform a subscription search that returns this subscription
=> "Notes" column contains both notes. For example : "too busy (on holiday)"
- Test with only public note
- Test with only internal note

Works as described.
Signed-off-by:Mathieu Saby <mathieu.saby@uhb.fr>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Works as described, fixes a bug as the templates show that
the intention was to display both notes in the column.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-10-11 04:21:47 +00:00
..
acqui Bug 10705: follow-up - change one more instance of "shippment cost" 2013-10-09 05:00:37 +00:00
admin Bug 10240: Offline circulation using HTML5 and IndexedDB 2013-10-11 01:53:34 +00:00
authorities bug 5202: (follow-up) adjust for the move of the merge record Javascript 2013-10-10 21:50:08 +00:00
basket Bug 10592: fix display of favicon 2013-07-22 14:00:23 +00:00
batch Bug 7760: Add ids and classes to every staff page to help with customizaton (batch, error) 2012-03-22 18:12:24 +01:00
catalogue Bug 10868 - Use new DataTables include in catalog templates 2013-09-21 19:27:08 +00:00
cataloguing Bug 9747: Fix NSB/NSE sorting issues on z3950 search results 2013-10-09 04:21:03 +00:00
circ Bug 10240: (follow-up) correctly record fines and fix label 2013-10-11 01:57:05 +00:00
course_reserves Bug 10634 - Use datatables for course details items table 2013-09-04 14:19:03 +00:00
errors Bug 2780 - Capitalize strings consistently (Error pages) 2012-04-10 10:03:32 +02:00
help Bug 9295: Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. 2013-10-10 23:03:30 +00:00
installer Bug 2774 - Path to theme is hard-coded in many places 2013-06-07 09:04:15 -07:00
labels Bug 9618: (follow-up) include link to jQuery only if needed 2013-09-16 16:05:51 +00:00
members Bug 10924: fix updating contact note from OPAC 2013-09-23 18:05:46 +00:00
offline_circ Bug 10288 - Fix a tiny typo on "Pending offline circulation actions" 2013-05-20 12:23:32 -07:00
patroncards Bug 9924 - Simplify and rename patron card creator error message include 2013-09-08 19:19:23 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 10718: fix items with no checkouts report 2013-09-08 20:04:43 +00:00
reserve Bug 10917: allow staff to update hold pickup location without modify_holds_priority 2013-10-08 14:23:07 +00:00
reviews Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version 2012-06-10 15:22:58 +02:00
rotating_collections Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections) 2012-04-10 10:04:13 +02:00
serials Bug 10689: make public note appear in subscriptions search 2013-10-11 04:21:47 +00:00
services Bug 10475 - Item form in acquisition not hiding subfields properly 2013-07-12 20:40:15 +00:00
sms Bug 2780 - Capitalize strings consistently - various 2012-04-10 10:04:16 +02:00
suggestion Bug 10668 - Improve suggestion detail page - QA Followup 2013-10-04 03:15:59 +00:00
tags Bug 10730: (follow-up) restore background color for cells 2013-09-25 16:48:21 +00:00
test Bug 2774 - Path to theme is hard-coded in many places 2013-05-20 11:11:04 -07:00
tools Bug 10853 - followup to correct tabs 2013-10-11 02:16:17 +00:00
virtualshelves Bug 9757: Remove duplicated action buttons. 2013-06-26 09:04:37 -07:00
z3950 Bug 9265 - Switch to HTML5 doctype in OPAC and staff client 2013-01-31 11:47:04 -05:00
about.tt Bug 10915: (QA followup) warn if cannot read history.txt 2013-09-20 17:25:57 +00:00
auth.tt Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
intranet-main.tt Bug 10888: Don't hide authorities module from users who lack permission to edit authorities 2013-09-21 17:59:05 +00:00