a10aeb1b0d
To test 1. Log in to the staff client. Note your logged in library. 2. Navigate to Circulation -> Holds queue. 3. Select a holds queue report for a library other than your own. 4. From the holds queue report page, click the "Check out" tab and enter the card number of a patron who has holds. 5. On the circulation page for that patron, click the "Holds" tab. 6. Click one of the titles in the list of holds. Your logged in branch will now match the library you chose for the holds queue report. Alternate sequence: 4. From the holds queue report page, click the "Check out" tab and do a non-exact search (search which will return more than one result) for a patron who has holds. 5. Choose the correct patron from the list of results. Your logged in branch will now match the library you chose for the holds queue report. Apply the patch and repeat, this time it should not change your logged in branch Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Weird bug, the patch works for me. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
80 lines
2.3 KiB
Perl
Executable file
80 lines
2.3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along with
|
|
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
|
|
# Suite 330, Boston, MA 02111-1307 USA
|
|
|
|
|
|
=head1 view_holdsqueue
|
|
|
|
This script displays items in the tmp_holdsqueue table
|
|
|
|
=cut
|
|
|
|
use strict;
|
|
use warnings;
|
|
use CGI;
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Koha; # GetItemTypes
|
|
use C4::Branch; # GetBranches
|
|
use C4::HoldsQueue qw(GetHoldsQueueItems);
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "circ/view_holdsqueue.tmpl",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { circulate => "circulate_remaining_permissions" },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $params = $query->Vars;
|
|
my $run_report = $params->{'run_report'};
|
|
my $branchlimit = $params->{'branchlimit'};
|
|
my $itemtypeslimit = $params->{'itemtypeslimit'};
|
|
|
|
if ( $run_report ) {
|
|
# XXX GetHoldsQueueItems() does not support $itemtypeslimit!
|
|
my $items = GetHoldsQueueItems($branchlimit, $itemtypeslimit);
|
|
$template->param(
|
|
branchlimit => $branchlimit,
|
|
total => scalar @$items,
|
|
itemsloop => $items,
|
|
run_report => $run_report,
|
|
);
|
|
}
|
|
|
|
# getting all itemtypes
|
|
my $itemtypes = &GetItemTypes();
|
|
my @itemtypesloop;
|
|
foreach my $thisitemtype ( sort keys %$itemtypes ) {
|
|
push @itemtypesloop, {
|
|
value => $thisitemtype,
|
|
description => $itemtypes->{$thisitemtype}->{'description'},
|
|
};
|
|
}
|
|
|
|
$template->param(
|
|
branchloop => GetBranchesLoop(C4::Context->userenv->{'branch'}),
|
|
itemtypeloop => \@itemtypesloop,
|
|
);
|
|
|
|
# writing the template
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|