ed7543287b
Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious This patch: - adds a Template::Toolkit plugin that generates <script> and <link> tags for JS and CSS files, and inserts automatically the Koha version in the filename - use the new plugin to remove all occurences of [% KOHA_VERSION %] - remove the code that was adding KOHA_VERSION as a template variable Test plan: 1. Apply patch 2. Go to several different pages in Koha (opac and intranet) while checking your browser's dev tools (there should be no 404 for JS and CSS files, and the Koha version should appear in filenames) and the server logs (there should be no "File not found") 3. `git grep KOHA_VERSION` should return nothing 4. prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
155 lines
7 KiB
Text
155 lines
7 KiB
Text
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › [% IF ( op_new ) %]OAI sets configuration › Add a new OAI set[% ELSE %]OAI sets configuration[% END %]</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="admin_oai_sets" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › [% IF ( op_new ) %]<a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets configuration</a> › Add a new OAI set[% ELSIF ( op_mod ) %]<a href="/cgi-bin/koha/admin/oai_sets.pl">OAI sets configuration</a> › Edit OAI set '[% spec |html %]'[% ELSE %] OAI sets configuration[% END %]</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
[% IF ( op_new || op_mod ) %]
|
|
<form method="post" action="/cgi-bin/koha/admin/oai_sets.pl" class="validated">
|
|
[% IF ( op_new ) %]
|
|
<h2>Add a new OAI set</h2>
|
|
<input type="hidden" name="op" value="savenew" />
|
|
[% ELSIF ( op_mod ) %]
|
|
<h2>Edit OAI set '[% spec |html %]'</h2>
|
|
<input type="hidden" name="op" value="savemod" />
|
|
<input type="hidden" name="id" value="[% id %]" />
|
|
[% END %]
|
|
<fieldset id="oaidetails" class="rows">
|
|
<ol>
|
|
<li>
|
|
<label for="spec" class="required">setSpec: </label>
|
|
<input type="text" id="spec" name="spec" value="[% spec %]" required="required" class="required" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="name" class="required">setName: </label>
|
|
<input type="text" id="name" name="name" value="[% name %]" required="required" class="required" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
[% FOREACH desc IN descriptions %]
|
|
<li>
|
|
<label>setDescription: </label>
|
|
<textarea style="vertical-align:middle" rows="2" cols="30" name="description">[% desc.description %]</textarea>
|
|
<a class="remove_description" href="#"><i class="fa fa-fw fa-trash"></i> Remove</a>
|
|
</li>
|
|
[% END %]
|
|
<li id="adddescription"><span class="label"> </span><a href="#" class="add_description"><i class="fa fa-fw fa-plus"></i> Add description</a></li>
|
|
|
|
</ol>
|
|
</fieldset>
|
|
<fieldset class="action">
|
|
<input type="submit" value="Save" /> <a class="cancel" href="/cgi-bin/koha/admin/oai_sets.pl">Cancel</a>
|
|
</fieldset>
|
|
</form>
|
|
[% ELSE %]
|
|
|
|
<div id="toolbar" class="btn-toolbar">
|
|
<a class="btn btn-default btn-sm" id="newoaiset" href="/cgi-bin/koha/admin/oai_sets.pl?op=new"><i class="fa fa-plus"></i> New set</a>
|
|
</div>
|
|
|
|
<h2>OAI sets</h2>
|
|
[% IF sets_loop %]
|
|
<table>
|
|
<thead>
|
|
<tr>
|
|
<th>setSpec</th>
|
|
<th>setName</th>
|
|
<th>setDescriptions</th>
|
|
<th> </th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH set IN sets_loop %]
|
|
<tr>
|
|
<td>[% set.spec |html %]</td>
|
|
<td>[% set.name |html %]</td>
|
|
<td>
|
|
[% IF set.descriptions %]
|
|
<ul>
|
|
[% FOREACH desc IN set.descriptions %]
|
|
<li>[% desc.description |html %]</li>
|
|
[% END %]
|
|
</ul>
|
|
[% ELSE %]
|
|
<em>No descriptions</em>
|
|
[% END %]
|
|
</td>
|
|
<td>
|
|
<div class="dropdown">
|
|
<a class="btn btn-default btn-xs dropdown-toggle" id="oaisetsactions[% set.id %]" role="button" data-toggle="dropdown" href="#">
|
|
Actions <b class="caret"></b></a>
|
|
<ul class="dropdown-menu pull-right" role="menu" aria-labelledby="oaisetsactions[% set.id %]">
|
|
<li><a href="/cgi-bin/koha/admin/oai_sets.pl?op=mod&id=[% set.id %]"><i class="fa fa-fw fa-pencil"></i> Edit</a></li>
|
|
<li><a class="delete_oai_set" href="/cgi-bin/koha/admin/oai_sets.pl?op=del&id=[% set.id %]"><i class="fa fa-fw fa-trash"></i> Delete</a></li>
|
|
<li><a href="/cgi-bin/koha/admin/oai_set_mappings.pl?id=[% set.id %]"><i class="fa fa-fw fa-info"></i> Define mappings</a></li>
|
|
</ul>
|
|
</div>
|
|
</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
[% ELSE %]
|
|
<div class="dialog message"><p>There are no sets defined.</p></div>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") %]
|
|
<script type="text/javascript">
|
|
function newDescField() {
|
|
$("#adddescription").before(
|
|
'<li><label>' + _("setDescription: ") + '</label>' +
|
|
'<textarea style="vertical-align:middle" rows="2" cols="30" name="description"></textarea>' +
|
|
'<a class="remove_description" href="#"><i class="fa fa-fw fa-trash"></i>' + _(" Remove") + '</a>' +
|
|
'</li>'
|
|
);
|
|
}
|
|
|
|
function delDescField(minusButton) {
|
|
var li = minusButton.parent('li');
|
|
$(li).remove();
|
|
}
|
|
|
|
function confirmDelete() {
|
|
return confirm(_("Are you sure you want to delete this OAI set?"));
|
|
}
|
|
|
|
$(document).ready(function() {
|
|
$(".delete_oai_set").on("click",function(){
|
|
return confirmDelete();
|
|
});
|
|
|
|
$("body").on("click", ".remove_description", function(e){
|
|
e.preventDefault();
|
|
delDescField($(this));
|
|
});
|
|
|
|
$(".add_description").on("click", function(e){
|
|
e.preventDefault();
|
|
newDescField();
|
|
});
|
|
|
|
});
|
|
</script>
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|