Owen Leonard
bb505d77f4
This follow-up makes drastic changes to the templates in order to bring them into compliance with established patterns and markup guidelines. Only minor changes are made to perl scripts. Changes: - Add a toolbar include for displaying new, edit, transfer, and delete buttons. - Improve title and breadcrumbs with collection titles and better specificity. - Correct page structure which was inconsistent with the markup of similarly-structured pages. - Correct styling of error and informational messages. - Added detailed error messages for a couple of conditions which were not defined in the template. - Add link to the detail page of titles which are in a collection using the view defined in the IntranetBiblioDefaultView preference. - Add a link to remove an item from a collection directly without having to scan the barcode. - Add client-side validation to collection creation form. - In RotatingCollections.pm, add biblionumber to the list of columns returned by GetItemsInCollection. - In rotating_collections/*.pl, remove obsolete declaration of system preference variables. To test, perform all the operations associated with Rotating Collections: - Add a new collection - Edit an existing collection - Add items to a collection - Remove items from a collection (via barcode and link) - Test the behavior of all new toolbar buttons - Verify that titles and breadcrumbs look correct and links work correctly. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
104 lines
3 KiB
Perl
Executable file
104 lines
3 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along with
|
|
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
|
|
# Suite 330, Boston, MA 02111-1307 USA
|
|
#
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use C4::Context;
|
|
use C4::RotatingCollections;
|
|
use C4::Items;
|
|
|
|
use CGI;
|
|
|
|
my $query = new CGI;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "rotating_collections/addItems.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { tools => 'rotating_collections' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
if ( $query->param('action') eq 'addItem' ) {
|
|
## Add the given item to the collection
|
|
my $colId = $query->param('colId');
|
|
my $barcode = $query->param('barcode');
|
|
my $removeItem = $query->param('removeItem');
|
|
my $itemnumber = GetItemnumberFromBarcode($barcode);
|
|
|
|
my ( $success, $errorCode, $errorMessage );
|
|
|
|
$template->param( barcode => $barcode );
|
|
|
|
if ( !$removeItem ) {
|
|
( $success, $errorCode, $errorMessage ) =
|
|
AddItemToCollection( $colId, $itemnumber );
|
|
|
|
$template->param(
|
|
previousActionAdd => 1,
|
|
);
|
|
|
|
if ($success) {
|
|
$template->param( addSuccess => 1 );
|
|
}
|
|
else {
|
|
$template->param( addFailure => 1 );
|
|
$template->param( failureMessage => $errorMessage );
|
|
}
|
|
}
|
|
else {
|
|
## Remove the given item from the collection
|
|
( $success, $errorCode, $errorMessage ) =
|
|
RemoveItemFromCollection( $colId, $itemnumber );
|
|
|
|
$template->param(
|
|
previousActionRemove => 1,
|
|
removeChecked => 1,
|
|
);
|
|
|
|
if ($success) {
|
|
$template->param( removeSuccess => 1 );
|
|
}
|
|
else {
|
|
$template->param( removeFailure => 1 );
|
|
$template->param( failureMessage => $errorMessage );
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
my ( $colId, $colTitle, $colDescription, $colBranchcode ) =
|
|
GetCollection( $query->param('colId') );
|
|
my $collectionItems = GetItemsInCollection($colId);
|
|
if ($collectionItems) {
|
|
$template->param( collectionItemsLoop => $collectionItems );
|
|
}
|
|
|
|
$template->param(
|
|
colId => $colId,
|
|
colTitle => $colTitle,
|
|
colDescription => $colDescription,
|
|
colBranchcode => $colBranchcode,
|
|
);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|