Nick Clemens
45ec6ba3a4
This patch moves get_prepped_report to Koha:Report->prep_report and adds some basic tests To test: 1 - Using the report created in last test, hit the report svc api like: http://localhost:8081/cgi-bin/koha/svc/report?id=6¶m_name=One&sql_params=One¶m_name=Listy|list&sql_params=2345%0D%0A423%0D%0A3%0D%0A2%0D%0A12 2 - Note the use of %0D%0A to separate list params 3 - Test with combinations with and without param_name specified http://localhost:8081/cgi-bin/koha/svc/report?id=6&sql_params=5&sql_params=2345%0D%0A423%0D%0A3%0D%0A2%0D%0A12 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: Perltidy prep_report Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
89 lines
2.7 KiB
Perl
Executable file
89 lines
2.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Copyright (C) 2011 Chris Cormack <chris@bigballofwax.co.nz>
|
|
# Copyright (C) 2013 Mark Tompsett
|
|
# Updated 2013 by Chris Cormack <chris@bigballofwax.co.nz>
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 3 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Output qw(output_with_http_headers);
|
|
use C4::Reports::Guided;
|
|
use Koha::Reports;
|
|
use JSON;
|
|
use CGI qw ( -utf8 );
|
|
|
|
use Koha::Caches;
|
|
|
|
my $query = CGI->new();
|
|
my $report_id = $query->param('id');
|
|
my $report_name = $query->param('name');
|
|
my $report_annotation = $query->param('annotated');
|
|
|
|
my $report_recs = Koha::Reports->search( $report_name ? { 'report_name' => $report_name } : { 'id' => $report_id } );
|
|
if ( !$report_recs || $report_recs->count == 0 ) { die "There is no such report.\n"; }
|
|
my $report_rec = $report_recs->next();
|
|
|
|
die "Sorry this report is not public\n" unless $report_rec->public;
|
|
|
|
my @sql_params = $query->multi_param('sql_params');
|
|
my @param_names = $query->multi_param('param_names');
|
|
|
|
my $cache = Koha::Caches->get_instance();
|
|
my $cache_active = $cache->is_cache_active;
|
|
my ($cache_key, $json_text);
|
|
if ($cache_active) {
|
|
$cache_key =
|
|
"opac:report:"
|
|
. ( $report_name ? "name:$report_name:" : "id:$report_id:" )
|
|
. join( '-', @sql_params )
|
|
. join( '_'. @param_names );
|
|
$json_text = $cache->get_from_cache($cache_key);
|
|
}
|
|
|
|
unless ($json_text) {
|
|
my $offset = 0;
|
|
my $limit = C4::Context->preference("SvcMaxReportRows") || 10;
|
|
my $sql = $report_rec->savedsql;
|
|
|
|
my ( $sql, undef ) = $report_rec->prep_report( \@param_names, \@sql_params );
|
|
|
|
my ( $sth, $errors ) =
|
|
execute_query( $sql, $offset, $limit, undef, $report_id );
|
|
if ($sth) {
|
|
my $lines;
|
|
if ($report_annotation) {
|
|
$lines = $sth->fetchall_arrayref({});
|
|
}
|
|
else {
|
|
$lines = $sth->fetchall_arrayref;
|
|
}
|
|
$json_text = encode_json($lines);
|
|
|
|
if ($cache_active) {
|
|
$cache->set_in_cache( $cache_key, $json_text,
|
|
{ expiry => $report_rec->cache_expiry } );
|
|
}
|
|
}
|
|
else {
|
|
$json_text = encode_json($errors);
|
|
}
|
|
}
|
|
|
|
output_with_http_headers( $query, undef, $json_text, 'json');
|