Main Koha release repository https://koha-community.org
Find a file
Mark Tompsett 463c5a0f25 Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost
Reworking based on output of:
git grep "gp\/reader"
Additionally, some changes might be in order though gp/reader works.
https://affiliate-program.amazon.com/help/topic/t64/a1
suggests using dp
A dp was discovered, so that part of the URL was left unchanged.
The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}")
if defined.

TEST PLAN
---------
 1) Added:
     "100 years of Canadian foreign policy /
      edited by Robert Bothwell and Jean Daudelin."
 2) Added a second book with the word foreign in the title.
 3) Waited for reindex
 4) Checked out the Canadian foreign policy book.
 5) Applied patch
 6) Made sure that:
    - AmazonAssocTag was set to TEST (easy to notice)
    - AmazonCoverImages was set to 'Show'
    - OPACAmazonCoverImages was set to 'Show'
 7) Searched intranet for 'foreign' to find the detail page
    -- hovering over picture shows URL with ?tag=TEST in it.
 8) Went to the OPAC Detail page
 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for
    the picture contained ?tag=TEST in it.
10) Logged into the OPAC
11) Confirmed the URL in the checked out list on your summary
    page contained ?tag=TEST in it.
12) Confirmed the URL in the checked out list on your reading
    history page contained ?tag=TEST in it.
13) Confirmed links worked (went to expected page)
14) run koha qa test tools

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-05-12 08:51:44 -04:00
acqui Bug 18482 False duplicates detected on adding a batch from a stage file 2017-04-28 06:50:21 -04:00
admin Bug 18299 - Removed unused env_tz_test.pl based on user testing feedback 2017-05-08 09:24:07 -04:00
api/v1 Bug 18409: Make the controller for holds use Koha::Holds 2017-04-24 09:40:40 -04:00
authorities Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
basket Bug 18124: Change the calls to generate and check CSRF tokens 2017-03-30 09:07:09 +00:00
C4 Bug 12063 - Remove checking of ExpireReservesMaxPickUpDelay in CancelExpiredReserves(). Koha::Hold::set_waiting calculate expiration date from today instead of hold's waiting date. 2017-05-09 08:59:40 -04:00
catalogue Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
cataloguing Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
circ Bug 12063 - Fix QA failures 2017-05-09 08:59:39 -04:00
clubs Bug 12461 - (QA Followup) 2017-04-28 08:37:45 -04:00
course_reserves Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
debian Bug 18502: Make koha-shell set the right PERL5LIB on dev installs 2017-05-05 12:12:04 -03:00
docs Bug 7143: Add Patricio Marrone to history.txt 2017-03-31 13:45:33 +00:00
errors
etc Bug 18098: Add an index with the count of not onloan items 2017-05-08 09:21:41 -04:00
installer Bug 12063 - DBRev 16.12.00.032 2017-05-09 09:16:49 -04:00
Koha Bug 18579: Fix call to append_fields, fix tests 2017-05-12 08:43:18 -04:00
koha-tmpl Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost 2017-05-12 08:51:44 -04:00
labels Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
members Revert "Bug 18179: Update existing calls" 2017-04-28 12:48:56 -04:00
misc Bug 16758: Use the default cache instance 2017-05-12 08:49:42 -04:00
offline_circ Bug 17501: Remove Koha::Upload::get from Koha::Upload 2017-01-20 14:20:05 +00:00
opac Bug 18560: RSS link in opac shelves is broken 2017-05-12 08:45:02 -04:00
OpenILS
patron_lists
patroncards Bug 18246: Patron card creator: Unit not always displays properly in layouts 2017-03-22 20:58:10 +00:00
plugins
reports Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
reserve Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database 2017-05-09 08:59:39 -04:00
reviews
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
services
skel
sms
suggestion Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class 2017-04-14 10:43:52 -04:00
svc Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database 2017-05-09 08:59:39 -04:00
t Bug 18579: Fix call to append_fields, fix tests 2017-05-12 08:43:18 -04:00
tags
test
tmp/modified_authorities
tools Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
virtualshelves Bug 7663: Fix bad merge conflict with bug 15584 2017-03-03 18:18:14 +00:00
xt Bug 17855: Onboarding tool 2017-04-28 08:36:19 -04:00
.editorconfig
.htaccess
.mailmap
about.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
changelanguage.pl
edithelp.pl
fix-perl-path.PL
help.pl
INSTALL
install-CPAN.pl
Koha.pm Bug 12063 - DBRev 16.12.00.032 2017-05-09 09:16:49 -04:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl
LICENSE
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
Makefile.PL Bug 18373: Re-add UpgradeBackup.pm 2017-04-14 10:41:03 -04:00
MANIFEST.SKIP
README
README.md
README.robots
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-comminity.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo