Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin
History
Marcel de Rooy 476179a123 Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls 
In aqbudgetperiods.pl a commented line is removed that contains a
wrong userenv hash key. Should be branch instead of branchcode.

In aqbudgets GetBudgetHierarchy is called with the same wrong userenv
hash key. Should be userenv->{branch}.
This made another bug visible: if you call GetBudgetHierarchy with a
branch and without owner, the where clause should take into account
that the branchcode can be empty (not null).

Test plan:
[1] Run Budgets.t
[2] Run aqbudgets.pl from Administration
[3] Add the show_mine=1 parameter in the URL
[4] Change owner of one of the funds and repeat step 2 and 3.

t/Budgets.t returns green. Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-04-13 08:34:15 -04:00
..
searchengine/elasticsearch Bug 17169: (QA followup) Add NORMARC and UNIMARC definitions for CCODE 2017-03-22 19:24:22 +00:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
admin-home.pl
aqbudgetperiods.pl Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls 2017-04-13 08:34:15 -04:00
aqbudgets.pl Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls 2017-04-13 08:34:15 -04:00
aqcontract.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
aqplan.pl Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
audio_alerts.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
auth_subfields_structure.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
auth_tag_structure.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
authorised_values.pl Bug 17216: Internal AV should be correctly handled when creating a new category 2016-10-11 07:30:32 +00:00
authtypes.pl
biblio_framework.pl Bug 17189: Replace occurrences of 'use Koha::Cache' 2016-09-08 10:24:47 +00:00
branch_transfer_limits.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
branches.pl Bug 16259: Replace CGI->param with CGI->multi_param in list context - part 2 2016-05-16 17:28:06 +00:00
categories.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
check_budget_parent.pl
check_parent_total.pl
checkmarc.pl
cities.pl
classsources.pl Bug 17208: Checking if classification source or filing rule already exists before adding 2016-12-23 11:33:48 +00:00
clone-rules.pl Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
columns_settings.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
columns_settings.yml Bug 17346: Make checkin column hidable 2017-03-31 13:24:02 +00:00
currency.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
didyoumean.pl
edi_accounts.pl Bug 17144: Fix variable scope issues in edi_account.pl 2016-09-25 13:18:14 +00:00
edi_ean_accounts.pl Bug 17692: Remove 'CGI::param called in list context' warnings 2016-12-21 12:27:29 +00:00
env_tz_test.pl
fieldmapping.pl Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
import_export_framework.pl Bug 18111: Swap framework_name and frameworkcode 2017-02-21 19:53:18 +00:00
item_circulation_alerts.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
items_search_field.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
items_search_fields.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
itemtypes.pl Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
koha2marclinks.pl Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences 2016-09-08 10:24:46 +00:00
localization.pl
marc_subfields_structure.pl Bug 17216: Use Koha::AVC from mss.pl 2016-10-11 07:30:31 +00:00
marctagstructure.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
matching-rules.pl Bug 17318: Allow chosing fixed normalization routines 2016-10-21 16:16:34 +00:00
oai_set_mappings.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
oai_sets.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
patron-attr-types.pl Bug 13757: Add the option to set patron attributes editable in the OPAC 2017-03-24 18:44:51 +00:00
preferences.pl Bug 18026: Correct URL to database columns from .pref files 2017-02-21 19:54:23 +00:00
printers.pl
smart-rules.pl Bug 15581: Add a circ rule to limit the auto renewals given a delay 2016-11-02 10:28:57 +00:00
sms_providers.pl
sru_modmapping.pl
systempreferences.pl
transport-cost-matrix.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
usage_statistics.pl Bug 18066: Hea V2 2017-03-23 00:10:46 +00:00
z3950servers.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00