Kyle M Hall
47e4f3ed84
There is a flaw in C4::Members::Messaging::GetMessagingPreferences where the system assumes that every transport will use the same letter. This is not necessarily true. Even with the default preferences of just 'email' and 'sms', we should be able to have different letters for each, as one has a maximum character length ( sms ) and one does not. GetMessagingPreferences currently uses the letter code of the last result of its query as the letter code for every transport type. The returned data is a hashref with a key 'transport_types' that is an array of transport_types this borrower has selected for the given alert. This commit modifies GetMessagingPreferences such that the the 'transport_types' array is now a hash where the name of the transport type is now a key to the value of the letter code set for that transport type. It also modifies code calling GetMessagingPreferences where necessary, and as a side benefit will correctly get the letter codes for email and sms correctly, if they are defined differently. http://bugs.koha-community.org/show_bug.cgi?id=4246 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> In use in production by two libraries: Middletown and Washoe who give their sign off but don't have git to do so. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> |
||
|---|---|---|
| .. | ||
| admin | ||
| bin | ||
| cronjobs | ||
| interface_customization | ||
| load_testing | ||
| maintenance | ||
| migration_tools | ||
| release_notes | ||
| translator | ||
| batchCompareMARCvsFrameworks.pl | ||
| batchDeleteUnusedSubfields.pl | ||
| batchImportMARCWithBiblionumbers.pl | ||
| batchRebuildBiblioTables.pl | ||
| batchRepairMissingBiblionumbers.pl | ||
| batchupdateISBNs.pl | ||
| check_sysprefs.pl | ||
| commit_biblios_file.pl | ||
| exportauth.pl | ||
| koha-install-log | ||
| kohalib.pl | ||
| link_bibs_to_authorities.pl | ||
| perlmodule_ls.pl | ||
| perlmodule_rm.pl | ||
| recreateIssueStatistics.pl | ||
| sax_parser_print.pl | ||
| sax_parser_test.pl | ||
| stage_biblios_file.pl | ||