Koha/acqui/orderreceive.pl
Jared Camins-Esakov 480841965e Bug 10403: add ability to change fund on receipt
Right now there is no way to change the budget or fund when receiving an
item, which is annoying, particularly at the end of the fiscal year when
every item not already received has to be switched to the following
year's budget. This patch adds the ability to change the budget and fund
when receiving.

To test:
1) Apply patch.
2) Create an order for a vendor, choosing a fund to use for that order.
3) Receive the order, leaving the fund unchanged. Make sure the fund
   did not change.
4) Create another order for a vendor, choosing a fund to use for that
   order.
5) Receive the order, this time changing the fund. Make sure the fund
   is changed.
6) Run the unit test:
    > prove t/db_dependent/Acquisition.t
7) Sign off.

(Notes: this patch depends on the Acquisitions.t unit test improvements
in bug 10274; the seemingly-unrelated change in SQLHelper quiets an
irritating warning caused by the NewOrder call in ModReceiveOrder)

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-10-22 12:57:25 +00:00

275 lines
8.7 KiB
Perl
Executable file

#!/usr/bin/perl
#script to recieve orders
#written by chris@katipo.co.nz 24/2/2000
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
=head1 NAME
orderreceive.pl
=head1 DESCRIPTION
This script shows all order already receive and all pendings orders.
It permit to write a new order as 'received'.
=head1 CGI PARAMETERS
=over 4
=item booksellerid
to know on what supplier this script has to display receive order.
=item invoiceid
the id of this invoice.
=item freight
=item biblio
The biblionumber of this order.
=item datereceived
=item catview
=item gst
=back
=cut
use strict;
use warnings;
use CGI;
use C4::Context;
use C4::Koha; # GetKohaAuthorisedValues GetItemTypes
use C4::Acquisition;
use C4::Auth;
use C4::Output;
use C4::Dates qw/format_date/;
use C4::Bookseller qw/ GetBookSellerFromId /;
use C4::Budgets qw/ GetBudget GetBudgetHierarchy CanUserUseBudget GetBudgetPeriods /;
use C4::Members;
use C4::Branch; # GetBranches
use C4::Items;
use C4::Biblio;
use C4::Suggestions;
my $input = new CGI;
my $dbh = C4::Context->dbh;
my $invoiceid = $input->param('invoiceid');
my $invoice = GetInvoice($invoiceid);
my $booksellerid = $invoice->{booksellerid};
my $freight = $invoice->{shipmentcost};
my $datereceived = $invoice->{shipmentdate};
my $ordernumber = $input->param('ordernumber');
$datereceived = $datereceived ? C4::Dates->new($datereceived, 'iso') : C4::Dates->new();
my $bookseller = GetBookSellerFromId($booksellerid);
my $results;
$results = SearchOrders({
ordernumber => $ordernumber
}) if $ordernumber;
my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
{
template_name => "acqui/orderreceive.tmpl",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => {acquisition => 'order_receive'},
debug => 1,
}
);
unless ( $results and @$results) {
output_html_with_http_headers $input, $cookie, $template->output;
exit;
}
# prepare the form for receiving
my $order = $results->[0];
# Check if ACQ framework exists
my $acq_fw = GetMarcStructure(1, 'ACQ');
unless($acq_fw) {
$template->param('NoACQframework' => 1);
}
my $AcqCreateItem = C4::Context->preference('AcqCreateItem');
if ($AcqCreateItem eq 'receiving') {
$template->param(
AcqCreateItemReceiving => 1,
UniqueItemFields => C4::Context->preference('UniqueItemFields'),
);
} elsif ($AcqCreateItem eq 'ordering') {
my $fw = ($acq_fw) ? 'ACQ' : '';
my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber});
my @items;
foreach (@itemnumbers) {
my $item = GetItem($_);
if($item->{homebranch}) {
$item->{homebranchname} = GetBranchName($item->{homebranch});
}
if($item->{holdingbranch}) {
$item->{holdingbranchname} = GetBranchName($item->{holdingbranch});
}
if(my $code = GetAuthValCode("items.notforloan", $fw)) {
$item->{notforloan} = GetKohaAuthorisedValueLib($code, $item->{notforloan});
}
if(my $code = GetAuthValCode("items.restricted", $fw)) {
$item->{restricted} = GetKohaAuthorisedValueLib($code, $item->{restricted});
}
if(my $code = GetAuthValCode("items.location", $fw)) {
$item->{location} = GetKohaAuthorisedValueLib($code, $item->{location});
}
if(my $code = GetAuthValCode("items.ccode", $fw)) {
$item->{collection} = GetKohaAuthorisedValueLib($code, $item->{ccode});
}
if(my $code = GetAuthValCode("items.materials", $fw)) {
$item->{materials} = GetKohaAuthorisedValueLib($code, $item->{materials});
}
my $itemtype = getitemtypeinfo($item->{itype});
$item->{itemtype} = $itemtype->{description};
push @items, $item;
}
$template->param(items => \@items);
}
$order->{quantityreceived} = '' if $order->{quantityreceived} == 0;
$order->{unitprice} = '' if $order->{unitprice} == 0;
my $rrp;
my $ecost;
my $unitprice;
if ( $bookseller->{listincgst} ) {
if ( $bookseller->{invoiceincgst} ) {
$rrp = $order->{rrp};
$ecost = $order->{ecost};
$unitprice = $order->{unitprice};
} else {
$rrp = $order->{rrp} / ( 1 + $order->{gstrate} );
$ecost = $order->{ecost} / ( 1 + $order->{gstrate} );
$unitprice = $order->{unitprice} / ( 1 + $order->{gstrate} );
}
} else {
if ( $bookseller->{invoiceincgst} ) {
$rrp = $order->{rrp} * ( 1 + $order->{gstrate} );
$ecost = $order->{ecost} * ( 1 + $order->{gstrate} );
$unitprice = $order->{unitprice} * ( 1 + $order->{gstrate} );
} else {
$rrp = $order->{rrp};
$ecost = $order->{ecost};
$unitprice = $order->{unitprice};
}
}
my $suggestion = GetSuggestionInfoFromBiblionumber($order->{biblionumber});
my $authorisedby = $order->{authorisedby};
my $member = GetMember( borrowernumber => $authorisedby );
my $budget = GetBudget( $order->{budget_id} );
$template->param(
AcqCreateItem => $AcqCreateItem,
count => 1,
biblionumber => $order->{'biblionumber'},
ordernumber => $order->{'ordernumber'},
subscriptionid => $order->{subscriptionid},
booksellerid => $order->{'booksellerid'},
freight => $freight,
name => $bookseller->{'name'},
date => format_date($order->{entrydate}),
title => $order->{'title'},
author => $order->{'author'},
copyrightdate => $order->{'copyrightdate'},
isbn => $order->{'isbn'},
seriestitle => $order->{'seriestitle'},
bookfund => $budget->{budget_name},
quantity => $order->{'quantity'},
quantityreceivedplus1 => $order->{'quantityreceived'} + 1,
quantityreceived => $order->{'quantityreceived'},
rrp => sprintf( "%.2f", $rrp ),
ecost => sprintf( "%.2f", $ecost ),
memberfirstname => $member->{firstname} || "",
membersurname => $member->{surname} || "",
invoiceid => $invoice->{invoiceid},
invoice => $invoice->{invoicenumber},
datereceived => $datereceived->output(),
datereceived_iso => $datereceived->output('iso'),
notes => $order->{notes},
suggestionid => $suggestion->{suggestionid},
surnamesuggestedby => $suggestion->{surnamesuggestedby},
firstnamesuggestedby => $suggestion->{firstnamesuggestedby},
);
my $borrower = GetMember( 'borrowernumber' => $loggedinuser );
my @budget_loop;
my $periods = GetBudgetPeriods( { 'budget_period_active' => 1 } );
foreach my $period (@$periods) {
my $budget_hierarchy = GetBudgetHierarchy( $period->{'budget_period_id'} );
my @funds;
foreach my $r ( @{$budget_hierarchy} ) {
next unless ( CanUserUseBudget( $borrower, $r, $userflags ) );
if ( !defined $r->{budget_amount} || $r->{budget_amount} == 0 ) {
next;
}
push @funds,
{
b_id => $r->{budget_id},
b_txt => $r->{budget_name},
b_sel => ( $r->{budget_id} == $order->{budget_id} ) ? 1 : 0,
};
}
@funds = sort { uc( $a->{b_txt} ) cmp uc( $b->{b_txt} ) } @funds;
push @budget_loop,
{
'id' => $period->{'budget_period_id'},
'description' => $period->{'budget_period_description'},
'funds' => \@funds
};
}
$template->{'VARS'}->{'budget_loop'} = \@budget_loop;
# regardless of the content of $unitprice e.g 0 or '' or any string will return in these cases 0.00
# and the 'IF' in the .tt will show 0.00 and not 'ecost' (see BZ 7129)
# So if $unitprice == 0 we don't create unitprice
if ( $unitprice != 0) {
$template->param(
unitprice => sprintf( "%.2f", $unitprice),
);
}
my $op = $input->param('op');
if ($op and $op eq 'edit'){
$template->param(edit => 1);
}
output_html_with_http_headers $input, $cookie, $template->output;