Josef Moravec
898b17ba8e
When the barcode is empty or invalid, an "Internal Server Error"
is triggered on the kohadev box.
TEST PLAN
---------
0) back up your database if you care about it.
1) Run the following commands:
git checkout master
git pull
git checkout -b bug_19771 origin/master
git bz apply 19771
-- This should be quite uneventful. Standard promptings.
2) Continue to run the following commands:
git checkout master
reset_all
sudo koha-shell -c bash kohadev
./misc/cronjobs/create_te_koc_db.pl --sqlite3
-- This will create a borrowers.db in your current directory.
3) On the host where you intend on running the koct install it.
-- https://sourceforge.net/projects/koha-oc/files/
download and install.
4) get the borrowers.db file to your host where you installed koct
5) point koct at the file you downloaded
Database -> Select Borrowers DB File
6) Create a .koc file with the following transactions.
check in, check out, check in (bad barcode),
pay fines (any non-zero amount).
7) Run the following commands:
restart_all
-- we want to make sure caching for plack isn't in the way.
8) In the staff client: Home -> Circulation
-> Upload offline circulation file (.koc)
9) Choose the file created and click 'Upload file'.
10) Add to offline circulation queue.
11) View pending offline circulation actions
-- This should die. Reading /var/log/koha/kohadev/plack-error.log
should be the same error as comment #0.
However, this was only the bad biblio error.
12) Run the following commands:
git checkout bug_19771
restart_all
13) Refresh staff client page.
-- it should all come up.
14) Select the bad biblio line, and delete it.
15) Run the following commands:
git checkout master
restart_all
16) Refresh the staff client page.
-- it should die. Same error as comment #0.
This confirms the fine payment issue.
17) Run the following commands
git checkout bug_19771
restart_all
18) Refresh the staff client page.
-- it should all come up.
19) run the koha qa test tools
20) if you backed up your database, restore it. :)
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
66 lines
2 KiB
Perl
Executable file
66 lines
2 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# 2009 BibLibre <jeanandre.santoni@biblibre.com>
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
#
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use C4::Koha;
|
|
use C4::Context;
|
|
use C4::Circulation;
|
|
use C4::Members;
|
|
use C4::Biblio;
|
|
use Koha::Patrons;
|
|
|
|
use Koha::Items;
|
|
|
|
my $query = CGI->new;
|
|
|
|
my ($template, $loggedinuser, $cookie) = get_template_and_user({
|
|
template_name => "offline_circ/list.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { circulate => "circulate_remaining_permissions" },
|
|
});
|
|
|
|
my $operations = GetOfflineOperations;
|
|
|
|
for (@$operations) {
|
|
my $item = $_->{barcode} ? Koha::Items->find({ barcode => $_->{barcode} }) : undef;
|
|
if ($item) {
|
|
my $biblio = $item->biblio;
|
|
$_->{'bibliotitle'} = $biblio->title;
|
|
$_->{'biblionumber'} = $biblio->biblionumber;
|
|
}
|
|
my $patron = $_->{cardnumber} ? Koha::Patrons->find( { cardnumber => $_->{cardnumber} } ) : undef;
|
|
if ($patron) {
|
|
$_->{'borrowernumber'} = $patron->borrowernumber;
|
|
$_->{'borrower'} = ($patron->firstname ? $patron->firstname:'').' '.$patron->surname;
|
|
}
|
|
$_->{'actionissue'} = $_->{'action'} eq 'issue';
|
|
$_->{'actionreturn'} = $_->{'action'} eq 'return';
|
|
$_->{'actionpayment'} = $_->{'action'} eq 'payment';
|
|
}
|
|
$template->param(pending_operations => $operations);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|