Nick Clemens
22cc378e4c
The code currently uses itemnumber to fetch old_issues for notices. This doesn't seem to be used in any current notices except the CHECKINSLIP: SELECTY letter.code,content FROM letter WHERE content LIKE 'old\\_%'\G For issues we use itemnumber, however, issues has a constraint to limit issues for an itemnumber to 1 Old issues has no such constraint, we try to rectify this in the old code by adding 'ORDER BY returndate DESC LIMIT 1" As the code is not used by default and buggy I think we can make a change to using 'issue_id' as the key and announcing the change - it prevents leaky data To test: 1. Check something out to patron A. Check it in. 2. Check something out to patron B. Check it in. 3. Check something out to patron C. Check it in and print the check-in slip. (Leave the checkin paghe open) 4. You will see the checkin repeat itself 3 times, one for each line in old_issues. 5. Apply patch and restart_all 6. Click the 'Print checkin slip' button again 7. You see a single checkin 8. Checkout a different item to patron A. Check it in and print the check-in slip 9. See the correct checkins Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> |
||
|---|---|---|
| .. | ||
| accountline-details.pl | ||
| apikeys.pl | ||
| boraccount.pl | ||
| cancel-charge.pl | ||
| default_messageprefs.pl | ||
| deletemem.pl | ||
| discharge.pl | ||
| discharges.pl | ||
| files.pl | ||
| guarantor_search.pl | ||
| holdshistory.pl | ||
| housebound.pl | ||
| ill-requests.pl | ||
| mancredit.pl | ||
| maninvoice.pl | ||
| member-flags.pl | ||
| member-password.pl | ||
| member.pl | ||
| memberentry.pl | ||
| members-home.pl | ||
| members-update-do.pl | ||
| members-update.pl | ||
| merge-patrons.pl | ||
| mod_debarment.pl | ||
| moremember.pl | ||
| notices.pl | ||
| patronimage.pl | ||
| pay.pl | ||
| paycollect.pl | ||
| print_overdues.pl | ||
| printfeercpt.pl | ||
| printinvoice.pl | ||
| printslip.pl | ||
| purchase-suggestions.pl | ||
| readingrec.pl | ||
| routing-lists.pl | ||
| setstatus.pl | ||
| statistics.pl | ||
| summary-print.pl | ||
| update-child.pl | ||