Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/koha-tmpl/opac-tmpl/bootstrap/en/modules
History
Aleisha Amohia 4a5c946d95 Bug 27961: Ensure external URLs are filtered 
TT variables are used to build the link in items.uri . This is a problem
particularly when TrackClicks is enabled because the items.uri value
doesn't get escaped, resulting in a 404.

To test:
1) Enable the TrackClicks system preference (set to Track or Track
    anonymously)
2) Find a record with an item
3) Edit the item and put an external URL under the Uniform Resource
Identifier field
4) Go to that record in the OPAC
5) Click on Link to resource
6) Confirm you are not redirected to the URL and instead see a 404
7) Apply the patch and refresh the page
8) Click on Link to resource
9) Confirm you are redirected as expected
10) Go back to the staff client to edit your item. This time put two
URLs in the Uniform Resource Identifier field, separated by ' | '.
(Don't forget the spaces around the pipe, and don't forget to add a
 trailing slash to the URL).
11) Go back to the OPAC and refresh the page.
12) Confirm both URLs redirect as expected.

Sponsored-by: Parliamentary Library New Zealand

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-04-16 14:15:37 +02:00
..
clubs Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
errors Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
sci Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
sco Bug 28047: Standardize: Call number, callnumber, Call no. etc. 2021-04-06 15:56:31 +02:00
svc Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
text
ilsdi.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
maintenance.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-account-pay-error.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-account.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-addbybiblionumber.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-advsearch.tt Bug 27889: Adjust responsive width of OPAC advanced search form 2021-04-06 15:56:30 +02:00
opac-alert-subscribe.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-auth-detail.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-auth-MARCdetail.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-auth.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-authorities-home.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-authoritiessearchresultlist.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-basket.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-blocked.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-browse.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-browser.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-course-details.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-course-reserves.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-detail.tt Bug 27961: Ensure external URLs are filtered 2021-04-16 14:15:37 +02:00
opac-discharge.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-downloadcart.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-downloadshelf.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-full-serial-issues.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-holdshistory.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-ics.tt
opac-idref.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-illrequests.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-imageviewer.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-ISBDdetail.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-issue-note.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-library.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-main.tt Bug 27610: (follow-up) Hide <h1> on opac-main.tt 2021-04-01 18:51:38 +02:00
opac-MARCdetail.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-memberentry-update-submitted.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-memberentry.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-messaging.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-mymessages.tt
opac-news-rss.tt
opac-opensearch.tt Bug 26921: Don't generate an invalid custom cover image if the url cannot be generated 2020-12-21 10:07:48 +01:00
opac-overdrive-search.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-passwd.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-password-recovery.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-patron-consent.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-privacy.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-readingrecord.tt Bug 28047: Standardize: Call number, callnumber, Call no. etc. 2021-04-06 15:56:31 +02:00
opac-recordedbooks-search.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-registration-confirmation.tt Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
opac-registration-email-sent.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-registration-invalid.tt Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 2020-09-09 14:13:03 +02:00
opac-reportproblem.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-request-article.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-reserve.tt Bug 28066: Remove select tag's size attribute where it is 1 2021-04-06 15:56:31 +02:00
opac-restrictedpage.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-results.tt Bug 27748: Encoding problem in link to OverDrive results 2021-04-06 15:56:30 +02:00
opac-retrieve-file.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-review.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-routing-lists.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-search-history.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-sendbasket.tt
opac-sendbasketform.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-sendshelf.tt
opac-sendshelfform.tt Bug 27742: Page titles have unique info first 2021-04-01 18:51:38 +02:00
opac-serial-issues.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-shareshelf.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-shelves-rss.tt
opac-shelves.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-showmarc.tt
opac-showreviews-rss.tt Bug 26921: Don't generate an invalid custom cover image if the url cannot be generated 2020-12-21 10:07:48 +01:00
opac-showreviews.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-suggestions.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-tags.tt Bug 28018: Replace obsolete title-string sorting: OPAC templates 2021-04-06 15:56:31 +02:00
opac-tags_subject.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-topissues.tt Bug 27610: Changed pages of OPAC to have a <h1> 2021-04-01 18:51:38 +02:00
opac-user.tt Bug 28047: Standardize: Call number, callnumber, Call no. etc. 2021-04-06 15:56:31 +02:00