Koha/opac/opac-downloadshelf.pl
Katrin Fischer c1c3b49668
Bug 33069: Fix error in MARC download for OPAC lists
There was a code typo causing an error when you tried
to download a list in MARC format:

Not a CODE reference at /kohadevbox/koha/opac/opac-downloadshelf.pl line 93

To test:
* In the OPAC: create a new list, public or private, with some records
* Open the list
* Try to download the list as MARC
* Verify you get an error
* Apply patch
* Verify you now get the expected download file
* Sign off :)

Co-authored-by: Kévin AYRAULT <kevin.ayrault87@gmail.com>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Nasty error before the patch; nice, tasty MARC download after.
Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-05-09 10:57:55 -03:00

163 lines
5.2 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2009 BibLibre
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use CGI qw ( -utf8 );
use C4::Auth qw( get_template_and_user );
use C4::Biblio qw( GetFrameworkCode GetISBDView );
use C4::Output qw( output_html_with_http_headers );
use C4::Record;
use C4::Ris qw( marc2ris );
use Koha::Biblios;
use Koha::CsvProfiles;
use Koha::RecordProcessor;
use Koha::Virtualshelves;
use utf8;
my $query = CGI->new;
# if virtualshelves is disabled, leave immediately
if ( ! C4::Context->preference('virtualshelves') ) {
print $query->redirect("/cgi-bin/koha/errors/404.pl");
exit;
}
my ( $template, $borrowernumber, $cookie ) = get_template_and_user (
{
template_name => "opac-downloadshelf.tt",
query => $query,
type => "opac",
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
}
);
my $patron = Koha::Patrons->find( $borrowernumber );
my $shelfnumber = $query->param('shelfnumber');
my $format = $query->param('format');
my $context = $query->param('context');
my $shelf = Koha::Virtualshelves->find( $shelfnumber );
if ( $shelf and $shelf->can_be_viewed( $borrowernumber ) ) {
if ($shelfnumber && $format) {
my $contents = $shelf->get_contents;
my $marcflavour = C4::Context->preference('marcflavour');
my $output;
my $extension;
my $type;
# CSV
if ($format =~ /^\d+$/) {
my $csv_profile = Koha::CsvProfiles->find($format);
if ( not $csv_profile or $csv_profile->staff_only ) {
print $query->redirect('/cgi-bin/koha/errors/404.pl');
exit;
}
my @biblios;
while ( my $content = $contents->next ) {
push @biblios, $content->biblionumber;
}
$output = marc2csv(\@biblios, $format);
# Other formats
} else {
my $record_processor = Koha::RecordProcessor->new({
filters => 'ViewPolicy'
});
while ( my $content = $contents->next ) {
my $biblionumber = $content->biblionumber;
my $biblio = Koha::Biblios->find($biblionumber);
my $record = $biblio->metadata->record(
{
embed_items => 1,
opac => 1,
patron => $patron,
}
);
my $framework = $biblio->frameworkcode;
$record_processor->options({
interface => 'opac',
frameworkcode => $framework
});
$record_processor->process($record);
next unless $record;
if ($format eq 'iso2709') {
$output .= $record->as_usmarc();
}
elsif ($format eq 'ris' ) {
$output .= marc2ris($record);
}
elsif ($format eq 'bibtex') {
$output .= marc2bibtex($record, $biblionumber);
}
elsif ( $format eq 'isbd' ) {
$output .= GetISBDView({
'record' => $record,
'template' => 'opac',
'framework' => $framework,
});
$extension = "txt";
$type = "text/plain";
}
}
}
# If it was a CSV export we change the format after the export so the file extension is fine
$format = "csv" if ($format =~ m/^\d+$/);
print $query->header(
-type => ($type) ? $type : 'application/octet-stream',
-'Content-Transfer-Encoding' => 'binary',
-attachment => ($extension) ? "shelf.$format.$extension" : "shelf.$format"
);
print $output;
} else {
# if modal context is passed set a variable so that page markup can be different
if($context eq "modal"){
$template->param(modal => 1);
} else {
$template->param(fullpage => 1);
}
$template->param(
csv_profiles => Koha::CsvProfiles->search(
{
type => 'marc',
used_for => 'export_records',
staff_only => 0
}
),
shelf => $shelf,
);
output_html_with_http_headers $query, $cookie, $template->output;
}
} else {
$template->param(invalidlist => 1);
output_html_with_http_headers $query, $cookie, $template->output;
}